[jbinkley60]

i getting that, my alternatives turn into a massive side project just to avoid 2 small lines of code because theyre frowned on

i think the decision will be either it works this way, i can make it manual from settings or do away with it and allow people to add their own sources - im weighing them

Writing directly to the database can be a bit more work depending upon how flexible you want this to be.  For instance I detect the version of Kodi and maintain a map to the underlying database file name.  Then there is the MySQL support or not, which adds another layer of complexity for direct writes.  I don't support MySQL with Mezzmo because there is no use case which would make sense but with KSCleaner I was asked to support both SQLite and MySQL. 

Lastly, there is a question not just of database adds but also changes and deletions.    I've seen folks with path tables of 2,000+ entries <sigh>  .  With my approach using Mezzmo to get the various addon files, scrape them and publish / sync them to Kodi,  my path table has 4 entries in the video database (the parent and one for each media type: movies, tvshows and music videos) and gets cleaned / refreshed daily. 

It gets down to how flexible you want your addon to be with various use cases.  Given that you don't care about being in the Kodi repo you have a lot of flexibility on how you do this.  You are welcome to any of my direct writing code.  


Thanks,

Jeff

[izprtxqkft]

UPDATE

i spent a good deal of time over the weekend writing a new tmdbv3 api module and then integrating that module into this project

the results are disappointing as there is no improvement, it is capable of scanning and caching it's own information and presenting it to kodi with it's content set as 'metadata.local'

but, there is no advantage over using an already available scraper in kodi, at the same time i did not integrate fanart.tv so this would be a loss of a feature at the same time meaning it is less robust

so i am archiving my latest version and reverting to the version already listed on the first post in order to look for other ways of improving


Secondly

primary slowdowns come from listing the content out of other addons and not the process of looking up their information for scraping purposes so i will look in this direction but i doubt there will be much to improve upon

towards that end i did already add the feature to the last version for tv show exclusions which will prevent 'Ended' and 'Cancelled' shows from being uselessly updated, if the option is used


Third (and final)

i do feel it will be better for source management to add the sources manually in kodi either via 'Add Source' or by editing the sources.xml, however, less convenient

the next test version will not include any automatic methods

[jbinkley60]

but, there is no advantage over using an already available scraper in kodi, at the same time i did not integrate fanart.tv so this would be a loss of a feature at the same time meaning it is less robust

Is that how Kodi scrapes fanart for TV shows (from fanart.tv)  vs. the scrapers getting it directly from TMDB ?  I've not looked at the TMDB v3 API that closely.  


Thanks,

Jeff

[izprtxqkft]

but, there is no advantage over using an already available scraper in kodi, at the same time i did not integrate fanart.tv so this would be a loss of a feature at the same time meaning it is less robust

Is that how Kodi scrapes fanart for TV shows (from fanart.tv)  vs. the scrapers getting it directly from TMDB ?  I've not looked at the TMDB v3 API that closely.  


Thanks,

Jeff

pkscout has it as an additional source in his tmdb tvshows scraper, settings can be changed to include fanart.tv

https://github.com/xbmc/metadata.tvshows...mdb.py#L48


the movie scraper has an added option over that to prioritize fanart.tv

[jbinkley60]

pkscout has it as an additional source in his tmdb tvshows scraper, settings can be changed to include fanart.tv

https://github.com/xbmc/metadata.tvshows...mdb.py#L48


the movie scraper has an added option over that to prioritize fanart.tv

Ok.  I looked at the TMDB APi and you can get the backdrop there if you know the series id.  I tested with series id:  32692  .  It has numerous results and sizes.


Thanks,

Jeff

[izprtxqkft]

pkscout has it as an additional source in his tmdb tvshows scraper, settings can be changed to include fanart.tv

https://github.com/xbmc/metadata.tvshows...mdb.py#L48


the movie scraper has an added option over that to prioritize fanart.tv

Ok.  I looked at the TMDB APi and you can get the backdrop there if you know the series id.  I tested with series id:  32692  .  It has numerous results and sizes.


Thanks,

Jeff

fanart.tv as an artwork source, not specifically for the artwork type 'fanart'

https://fanart.tv/movie/458156/john-wick...parabellum

in my own opinion they have better art, i have my jellyfin server configured to prefer it

as well when providing something to others i wouldnt want to remove the option even if my opinion were tmdb has better art

[LongMan]

Are you already taking advantage of this?

https://github.com/xbmc/xbmc/pull/19459

[izprtxqkft]

Are you already taking advantage of this?

https://github.com/xbmc/xbmc/pull/19459

not currently, sounds like a great option

it looks like that PR has more to do with InfoTagGame though https://github.com/xbmc/xbmc/pull/19459/files

[LongMan]

The aim was to speed up importation of videos. Only video imports have been implemented in MediaImport. As I have stated earlier, he is usually thorough in the way he approaches his work so if other areas are affected or could be improved, he will make the changes. However I am sure that the original aim was to improve video import. Maybe video was done in a previous PR and this was a follow up of the other types.

What I do know is that The MediaImport builds are more efficient in some ways because only the improvements that are not specific to it have been PR'd to mainline.

Cheers,
LongMan

[jbinkley60]

fanart.tv as an artwork source, not specifically for the artwork type 'fanart'

https://fanart.tv/movie/458156/john-wick...parabellum

in my own opinion they have better art, i have my jellyfin server configured to prefer it

as well when providing something to others i wouldnt want to remove the option even if my opinion were tmdb has better art

Interesting information about fanart.tv .  Mezzmo isn't flexible to allow me to change scrapers and it doesn't have as much artwork support as Kodi but it's always been sufficient for me with the exception of actor artwork where I wrote an entire tool to manage it.  My point above was simply that I thought it was available via TMDB.   I am likely less critical than some on the quality of my artwork.   I have been giving some thought to how the Mezzmo Kodi addon can bridge the gap in some artwork types Kodi supports that Mezzmo doesn't (i.e clearlogo).


Thanks,

Jeff

[izprtxqkft]

@LongMan

i believe the media import fork and this addon are in parallel with no intersecting paths

with the media import fork a plugin is telling kodi where to locate media which is then imported and maintained, what i saw as the initial use was upnp://

with this addon it will do the same, tell kodi where to locate media which is then imported and maintained
if you wanted to import upnp it would also be capable as it is just a path that would be in the bookmarks, the only change in the addon would be where i show an import button

i dont think i have been able to accurately describe the function of this addon as it seems nobody is actually knows how it works

-----

in a normal kodi, kodi has sources, kodi then lists the contents of folders and files and tries to determine what they are base on the filename or foldername

with this addon, the only interaction is the listing of the folders and files, presenting virtual files and folders as if they were physical media and then redirecting them to physical paths on playback

it functions about the same as a kodi binary VFS addon, without having to be a binary

if you were to use SSH as a source it would be the same as what this addon does - lists files and folders
https://kodi.wiki/view/Add-on:SFTP_support

[izprtxqkft]

Interesting information about fanart.tv .  Mezzmo isn't flexible to allow me to change scrapers and it doesn't have as much artwork support as Kodi but it's always been sufficient for me with the exception of actor artwork where I wrote an entire tool to manage it.  My point above was simply that I thought it was available via TMDB.   I am likely less critical than some on the quality of my artwork.   I have been giving some thought to how the Mezzmo Kodi addon can bridge the gap in some artwork types Kodi supports that Mezzmo doesn't (i.e clearlogo).


Thanks,

Jeff

it has been a learning curve for me, i never really payed attention to the artwork in kodi because the thumbnail shown when you select "Choose art" in kodi to change it is so tiny with no details

i started paying attention when i started managing my library in a web browser (jellyfin control panal) and could see the full quality art i was selecting as well as it's details about resolution

your mezzmo addon sitting between the server and kodi you could easily add artwork to kodi with "additional artwork" but with the deficits of the way kodi shows that you may still not see a difference

it will also only ever be in kodi and not centrally located like mezzmo artwork

[jbinkley60]

it has been a learning curve for me, i never really payed attention to the artwork in kodi because the thumbnail shown when you select "Choose art" in kodi to change it is so tiny with no details

i started paying attention when i started managing my library in a web browser (jellyfin control panal) and could see the full quality art i was selecting as well as it's details about resolution

your mezzmo addon sitting between the server and kodi you could easily add artwork to kodi with "additional artwork" but with the deficits of the way kodi shows that you may still not see a difference

it will also only ever be in kodi and not centrally located like mezzmo artwork

Yeah, that's the jist of it for Kodi artwork types Mezzmo doesn't but Mezzmo does have a great GUI database editor and other tools for artwork which it does support, especially for movies, shows and stuff which can't be scraped.  It allows you to select your artwork in a GUI format so if you had a bunch of images for a movie (say a poster) you can quickly go through them and pick one or do an Internet search for something better.  It also supports farnart, poster and folder files in the folders (without displaying them when browsing) so you can always roll your own.  It also supports cerntralized artwork sizing to balance space and quality.  Actor images is even more flexible.  Anyway, it is these reasons why I've ever spent a lot of time looking at other artwork and I don't run more than stock skins, where this might become desirable.  I am going to keep this in mind for the future.  I just don't relish the idea of client based solutions vs. centralized.


Thanks,

Jeff

[izprtxqkft]

Update

Added (lengthy) modules for Trakt (trending, popular, watchlist, custom lists, collection) and TMDB scraping for Movie content, speed tests are great taking less than 3 seconds to scrape and display 100 movies on initial listing.
Employing an sqlite3 cache the subsequent listings of already scraped content taking on average 0.5-0.8 seconds for the same 100 movies.

But, I wrote the modules on my Linux development machine using pyCurl for the speed increase only to realize this is not part of Kodi and is not available on Android platforms (potentially not Windows either, untested).
So that will need to be re-written using requests, hoping it will be comparable in speed to pyCurl but I have my doubts.
Potentially I will include both and on the unavailability of pyCurl on a platform just fallback to requests - if I cannot get requests to the same performance.

The idea would be to integrate Trakt for Lists (watchlist+custom) and the JustWatch unofficial api to expand what can be imported to Kodi beyond addons available.
Links to unsupported services by lack of Kodi addons could be presented to the user so they may take external actions to watch the media. f.e. Vudu, Movies Anywhere

[jbinkley60]

Added (lengthy) modules for Trakt (trending, popular, watchlist, custom lists, collection) and TMDB scraping for Movie content, speed tests are great taking less than 3 seconds to scrape and display 100 movies on initial listing.
Employing an sqlite3 cache the subsequent listings of already scraped content taking on average 0.5-0.8 seconds for the same 100 movies.

But, I wrote the modules on my Linux development machine using pyCurl for the speed increase only to realize this is not part of Kodi and is not available on Android platforms (potentially not Windows either, untested).
So that will need to be re-written using requests, hoping it will be comparable in speed to pyCurl but I have my doubts.
Potentially I will include both and on the unavailability of pyCurl on a platform just fallback to requests - if I cannot get requests to the same performance.

Are you using pyCurl to pull images or metadata ?  Both can be pulled via normal urllib commands.  Here's an example of image and xml fetching / parsing that I use for TMDB and it is lightening fast.


Thanks,

Jeff