[enen92]

Hey guys,

I've decided to spend some time improving our picture metadata handling for v22 since most of the exif tags, as you may have noticed, are broken. My plan is to delegate this to an external library (exiv2 being the most complete one I could find since it covers both EXIF and IPTC) and remove our internal parsing. The work has started here: https://github.com/xbmc/xbmc/pull/24109

Having said that, for those that use pictures in Kodi - or simply are more familiar with photos in general - which information do you find missing in Kodi that you'd like to see exposed in the UI (or other APIs)? I don't mean those that don't work currently and were supposed to work

You can see the available tags exiv2 provides here:

exiv: https://exiv2.org/tags.html
iptc: https://exiv2.org/iptc.html

Kodi provides a subset of them: https://github.com/xbmc/xbmc/blob/master....h#L49-L75

Cheers

[Buschel]

Thanks for looking into this and bringing this to the next level for future Kodi versions.

But let me ask: Is there any chance to fix the functionality which broke after Kodi 19.5? For the same images the JSON API on Kodi 19.5 provides EXIF data, but not on 20 and 21 anymore. It seems not to be a problem of the tags not being interpreted correctly, but something else (JSON API?).

[enen92]

Thanks for looking into this and bringing this to the next level for future Kodi versions.

But let me ask: Is there any chance to fix the functionality which broke after Kodi 19.5? For the same images the JSON API on Kodi 19.5 provides EXIF data, but not on 20 and 21 anymore. It seems not to be a problem of the tags not being interpreted correctly, but something else (JSON API?).

I had a look into it first but the issue is precisely the fact most of the tags (except camera make, model and others) not being extracted in the first place. This was caused by a few backports from chromium libexif to fix security issues (reading out specific offsets). The effort and energy to fix this is IMOH quite a waste of time since this is better delegated to external and well maintained libraries than using a custom parser like kodi does. I also plan to add a few unit tests to make sure it doesn't break accidentally in the future.
That being said, at least I won't pursue a band-aid fix for v21 (but others are for sure free to take the initiative).

[Buschel]

This was caused by a few backports from chromium libexif to fix security issues (reading out specific offsets). The effort and energy to fix this is IMOH quite a waste of time since this is better delegated to external and well maintained libraries than using a custom parser like kodi does.

Thanks for sharing the background, this makes sense.