•  Previous
  • 1
  • 2
  • 3
  • 4(current)
  • 5
  • 6
  • 26
  • Next 
  Thread Closed
 
Thread Rating:
  • 1 Vote(s) - 5 Average
[RELEASE] CU Lyrics (Script) Addon
#46
Amet Wrote:Thanks for all the reports, I think its fixed in 0.7.3. Give it a go when you have some time.

Zeljko

Hello Zeljko, boy are you making it hard to find bugs! This new version is ALMOST perfect. Below is the only songs I've issues with. The funny thing is your script tries to scrape from the proper page but some songs work, yet others come back 'No Lyrics Have Been Found'. Maybe you have some debugging options to see what is causing the script to come back empty.

Work Fine:
NOTICE: Title:[Creedence Clearwater Revival:Fortunate Son]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

NOTICE: Title:[Creedence Clearwater Revival: Down On The Corner] (I had to add space between : & D to avoid smiley)
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

No Lyrics Have Been Found:
NOTICE: Title:[Creedence Clearwater Revival:Hey Tonight]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

NOTICE: Title:[Creedence Clearwater RevivalTongueroud Mary]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

Good luck troubleshooting!
#47
mvdaat Wrote:Hi Amet,

Still have the problem with internet radio that it doesn't refresh
if I exit the script and go back then it's finding the correct lyric

With this new version a lot of songs are working that didn't work before
Thanks!!!

Internet radio? wouldnt even know how to test.

post the debug log let me have a look.

Zeljko
#48
internet radio may not trigger the player start event on song change even though the title changes.

so it wouldn't work without a constant thread checking song title (not good)
For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
#49
paco Wrote:Hello Zeljko, boy are you making it hard to find bugs! This new version is ALMOST perfect. Below is the only songs I've issues with. The funny thing is your script tries to scrape from the proper page but some songs work, yet others come back 'No Lyrics Have Been Found'. Maybe you have some debugging options to see what is causing the script to come back empty.

Hopefully we'll get to the point that it just works Smile. Thanks a lot for your help debugging it.

paco Wrote:No Lyrics Have Been Found:
NOTICE: Title:[Creedence Clearwater Revival:Hey Tonight]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

NOTICE: Title:[Creedence Clearwater RevivalTongueroud Mary]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

Good luck troubleshooting!

hehe, the problem is actually on the LyricWiki page.

I have fixed the Creedence Clearwater Revival:Hey Tonight and left Creedence Clearwater RevivalTongueroud Mary for you to see.

the lyrics need to be wrapped in "<lyrics>" tag, whoever edited the Proud Marry and Hey Tonight songs has put "<lyric>" as a tag and thats why we are not seeing it.

If a lot of those start popping up I will add the check for "<lyric>" tag.

Zeljko
#50
Amet Wrote:hehe, the problem is actually on the LyricWiki page.

I have fixed the Creedence Clearwater Revival:Hey Tonight and left Creedence Clearwater RevivalTongueroud Mary for you to see.

the lyrics need to be wrapped in "<lyrics>" tag, whoever edited the Proud Marry and Hey Tonight songs has put "<lyric>" as a tag and thats why we are not seeing it.

If a lot of those start popping up I will add the check for "<lyric>" tag.

Zeljko

Good find. I don't know how I missed that when comparing the working songs with the failed songs. I ran into a few other problem songs last night and after reading your post I went back to check them. Yup, the same issue (<lyric> instead of <lyrics>). Here is a sample:

http://lyrics.wikia.com/index.php?title=...ction=edit

http://lyrics.wikia.com/index.php?title=...ction=edit

I could just edit the songs on lyricwiki, but there may be many more we're not aware of. If it's possible, it might be better to add a check for <lyric> as well (maybe if <lyrics> returns 0 results?).

Another suggestion I wanted to make was the handling of Instrumentals. Rather than have the script search every time one is played and return 'No Lyrics Have Been Found', I think it would be better to save the text file for the song with words "Instrumental" for lyrics. That would prevent a needless search (and subsequent fail) when part of a playlist. I notice most Instrumentals have the following tag inside the lyrics {{Instrumental}}.
#51
paco Wrote:Good find. I don't know how I missed that when comparing the working songs with the failed songs. I ran into a few other problem songs last night and after reading your post I went back to check them. Yup, the same issue (<lyric> instead of <lyrics>). Here is a sample:

http://lyrics.wikia.com/index.php?title=...ction=edit

http://lyrics.wikia.com/index.php?title=...ction=edit

I could just edit the songs on lyricwiki, but there may be many more we're not aware of. If it's possible, it might be better to add a check for <lyric> as well (maybe if <lyrics> returns 0 results?).

I'll work on that, it shouldnt take too long

paco Wrote:Another suggestion I wanted to make was the handling of Instrumentals. Rather than have the script search every time one is played and return 'No Lyrics Have Been Found', I think it would be better to save the text file for the song with words "Instrumental" for lyrics. That would prevent a needless search (and subsequent fail) when part of a playlist. I notice most Instrumentals have the following tag inside the lyrics {{Instrumental}}.

I will add that as well, have to find one with instrumental. I dont even have music library scanned in XBMC Smile

Thanks
Zeljko
#52
Amet Wrote:I will add that as well, have to find one with instrumental. I dont even have music library scanned in XBMC Smile

Thanks
Zeljko

Sounds great.

Here are links to a few Instrumentals:

http://lyrics.wikia.com/index.php?title=...ction=edit

http://lyrics.wikia.com/index.php?title=...ction=edit

http://lyrics.wikia.com/index.php?title=...ction=edit
#53
paco Wrote:Sounds great.

Here are links to a few Instrumentals:

http://lyrics.wikia.com/index.php?title=...ction=edit

http://lyrics.wikia.com/index.php?title=...ction=edit

http://lyrics.wikia.com/index.php?title=...ction=edit

0.7.4 is on SVN Repo, when you get a chance give it a go.

Quote:0.7.4 is available via SVN Repo Installer / 09.12.09
- 0.7.4 Fixed:Search for <lyric> tag as well, save to file if song is instrumental, thanks again paco

Zeljko
#54
Nuka1195 Wrote:internet radio may not trigger the player start event on song change even though the title changes.

so it wouldn't work without a constant thread checking song title (not good)

Hi Amet,

Seems to do with the refresh of internet radio
Is there away to do a check on the change of the song title?
It would be great if that could be fixed

Otherwise I just have to play music from harddisc if I want lyrics
#55
Amet Wrote:0.7.4 is on SVN Repo, when you get a chance give it a go.

Zeljko

Hello Zeljko, your new version is very good. One suggestion is to not save a txt file when a search comes back empty or when the title is there but there are no lyrics. After testing this version, I had a few files saved that had the following:

<!-- PUT LYRICS HERE (and delete this entire line) -->

IMO it's better to let the user know that no results were found (maybe a message to ask them to check the spelling or capitalization of their files?). I had a couple files that were missing a capital letter in the name. The downside to saving an empty file is that there is no 'refresh' option (I had to manually delete the text file, go to lyricwiki and find out whether it or my tags were at fault and fix the issue).

All in all, this release is excellent and I'm loving how well it works. When you're finished with this version, you may want to consider adding these features to your Batch Lyrics script.

P.S. Instrumentals are working great!
#56
I just wanted to say that I love this script! Together with Transparency! 2.11 this is a jawdropping combination! Thank you for your hard work on this - I just wanted to let you know that it's highly appreciated.

Best Regards,
Thomas
#57
just tried it out and it works great Smile
#58
thomash72 Wrote:I just wanted to say that I love this script! Together with Transparency! 2.11 this is a jawdropping combination! Thank you for your hard work on this - I just wanted to let you know that it's highly appreciated.

Best Regards,
Thomas

I am also using Transparency! 2.11 and unfortunately, dont get it to work. The "old script" XBMC Lyrics finds the song, but then gives an error fetching the lyrics. The "new one" CU Lyrics states "please select a song", but nothing shows up.

Any thoughts?!
Server: Asus Sabertooth Z77 | Intel Core i5 3.4 GHz | 16 GB DDR3 | 128 GB SSD, 82 TB (9 x 6 TB, 7 x 4 TB)
HTPC 1: Raspberry Pi 2 | HTPC 2: Raspberry Pi 2 | HTPC 3: Raspberry Pi
#59
steve1977 Wrote:I am also using Transparency! 2.11 and unfortunately, dont get it to work. The "old script" XBMC Lyrics finds the song, but then gives an error fetching the lyrics. The "new one" CU Lyrics states "please select a song", but nothing shows up.

Any thoughts?!

debug log?
#60
paco Wrote:Hello Zeljko, your new version is very good. One suggestion is to not save a txt file when a search comes back empty or when the title is there but there are no lyrics. After testing this version, I had a few files saved that had the following:

<!-- PUT LYRICS HERE (and delete this entire line) -->

IMO it's better to let the user know that no results were found (maybe a message to ask them to check the spelling or capitalization of their files?). I had a couple files that were missing a capital letter in the name. The downside to saving an empty file is that there is no 'refresh' option (I had to manually delete the text file, go to lyricwiki and find out whether it or my tags were at fault and fix the issue).

All in all, this release is excellent and I'm loving how well it works. When you're finished with this version, you may want to consider adding these features to your Batch Lyrics script.

P.S. Instrumentals are working great!

sorry it took a while. Please let me know if it is okay.

Quote:0.7.5 is available via SVN Repo Installer / 05.01.2010
- 0.7.5 Fixed:do not save to file if lyrics download failed, added auto scroll timer(enable it under script settings)
  •  Previous
  • 1
  • 2
  • 3
  • 4(current)
  • 5
  • 6
  • 26
  • Next 
  Thread Closed
 
Thread Rating:
  • 1 Vote(s) - 5 Average



Logout Mark Read Team Forum Stats Members Help
[RELEASE] CU Lyrics (Script) Addon51