Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
Is it possible to get a boolean for skins to use if the xbmc build is a pvr build. I want to use it to hide the livetv settings for regular xbmc builds while maintaining the pvr xml's in the skin.
I know I can use a skin setting for that, but imo that would make no sense to put it somewhere in the skinsettings to enable livetv.
Posts: 1,514
Joined: Jul 2010
Reputation:
60
+1 for this
Makes sense to me and would be a worthwile addition!
mad-max
- - - Tribute to Metallica - - -
If I managed to help you, please click my reputation
Posts: 120
Joined: Jan 2012
Reputation:
0
salora
Senior Member
Posts: 120
maybe you can just add the option to activate livetv or not in the parameters?
like confluence or influence do
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
Confluence has separate skins for pvr and non-pvr and can do this because it's delivered with the program build itself, something not yet possible for other skins because there's no separate pvr addon branch. I don't know influence, but if by parameters you mean skin settings I think I already explained myself in the first post for that.
Posts: 17,414
Joined: Aug 2007
Reputation:
590
Hitcher
Team-Kodi Member
Posts: 17,414
2012-03-16, 16:26
(This post was last modified: 2012-03-16, 16:27 by Hitcher.)
I used <visible>System.GetBool(pvrmanager.enabled)</visible> for XeeBo which has PVR in the main skin.
Posts: 5,292
Joined: Jun 2006
Reputation:
62
Jezz_X
Team-XBMC Skinner
Posts: 5,292
Nothing will probably work unless it's also back ported to the main branch. Because the condition will always fail on the normal builds
Posts: 17,414
Joined: Aug 2007
Reputation:
590
Hitcher
Team-Kodi Member
Posts: 17,414
It fails thus it's not true and any PVR stuff remains hidden, no?
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
It will generate a error in the normal builds, but will never return true, so it will do what we want. And as long as you don't use it as a visible condition, but only with conditional includes, the log won't be spammed with errors.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
I think we've well-lost the usefulness of the "error" in the log - your thoughts?
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
Could be useful if you made a typo, but with PVR builds in mind I'd rather see it go. Then again, if there was a System.PVR in both pvr and normal builds we could use that instead of reading guisettings. All other pvr related settings are normally loaded in pvr xml's and are never loaded in regular builds, so no errors will be generated. In that case the error logging could stay.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
I'll make pvrmanager.enabled a valid setting in Eden (returning false, ofcourse). Sound good?
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
That doesn't work to hide the LiveTV settings in regular builds (otherwise the settings will be hidden for everybody, because the setting to set pvrmanager.enabled to true is in the livetv settings), but could be useful for skins that have that as a visiblitiy condition in the home window.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Right, you mean a settings category on the main settings screen - will discuss with opdenkamp.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Ok, the setting pvrmanager.enabled will return false (and not spam the log) in Eden.
Also, system.haspvr is now available (infobool) in Eden for switching items off that don't belong.
6e91544 has the goodies.
Cheers,
Jonathan