[Jönke]

@FernetMenta is this PR any help to get http://forum.kodi.tv/showthread.php?tid=142333&page=9 closer to working better with Kodi ? ( in sync and possible to chose subtile in Kodi video player menu )

[allan87]

Wow! That's tremendous. I can make more samples for you. What would you like?

there are various window styles, see here: http://en.wikipedia.org/wiki/CEA-708#Pre...ndow_style
if you had a couple of short samples recorded from different channels, I could test those.

Here are three samples from three different channels, recorded today. After you click on the link, a window opens with the video in flash format. The link to download the actual file is the small arrow above the flash video.
https://drive.google.com/folderview?id=0...sp=sharing

[FernetMenta]

Wow! That's tremendous. I can make more samples for you. What would you like?

there are various window styles, see here: http://en.wikipedia.org/wiki/CEA-708#Pre...ndow_style
if you had a couple of short samples recorded from different channels, I could test those.

Here are three samples from three different channels, recorded today. After you click on the link, a window opens with the video in flash format. The link to download the actual file is the small arrow above the flash video.
https://drive.google.com/folderview?id=0...sp=sharing

Thanks. All three are working here. Two of them use rollup style.

[FernetMenta]

@FernetMenta is this PR any help to get http://forum.kodi.tv/showthread.php?tid=142333&page=9 closer to working better with Kodi ? ( in sync and possible to chose subtile in Kodi video player menu )

Teletext Subtitles is a different technology but this could use the same design I used for CC. Instead of parsing the video packets it would need to parse teletext packets.

[allan87]

there are various window styles, see here: http://en.wikipedia.org/wiki/CEA-708#Pre...ndow_style
if you had a couple of short samples recorded from different channels, I could test those.

Here are three samples from three different channels, recorded today. After you click on the link, a window opens with the video in flash format. The link to download the actual file is the small arrow above the flash video.
https://drive.google.com/folderview?id=0...sp=sharing

Thanks. All three are working here. Two of them use rollup style.

Thank you very much. I see it is well on its way to making it into a nightly build and am eagerly looking forward to testing and using it.

[FernetMenta]

I merged it into master branch, should be in the nightlies tomorrow. Parsing cc has to switched on in system-video-subtitle settings.

[Jönke]

@FernetMenta is this PR any help to get http://forum.kodi.tv/showthread.php?tid=142333&page=9 closer to working better with Kodi ? ( in sync and possible to chose subtile in Kodi video player menu )

Teletext Subtitles is a different technology but this could use the same design I used for CC. Instead of parsing the video packets it would need to parse teletext packets.

Ok , let me know if you need any samples to take a look at it
Cause i know for sure it would make a lot of non tvheadend users for kodi pvr very happy

[rd1979]

I merged it into master branch, should be in the nightlies tomorrow. Parsing cc has to switched on in system-video-subtitle settings.

Thanks for putting in the work! This has been a long time coming.

[allan87]

FernetMenta, I have tested your excellent CC enhancement, and have some feedback. It mostly works very well:

- The added load has no detectable negative impact on playback on most content on a Raspberry Pi, including HD. On the two recordings I found that had some stuttering, disabling subtitles on the on-screen menu resolved the problem. The system preference did not have to be turned off.

- It seems to work very well on most, but not all recordings. The recordings with problems seemed to be restricted to two channels. On one channel the subtitles could not be enabled because they were not detected (i.e. there was no option in the onscreen menu to enable the captions). On the other channel, the captioning was detected and enabled, but displayed irregularly - mostly no captions were shown, and often when captions were shown, they were incorrect.

Would you like further samples from the recordings that had issues?

Thank you again for this very significant enhancement.

[FernetMenta]

Yes, please provide those samples.

[Ace]

Slightly of topic, but does anyone has a sample with (dvb) hearing impaired subtitles?

[allan87]

Yes, please provide those samples.

I have added two more files to https://drive.google.com/folderview?id=0...sp=sharing

• 1492_20141222131000 - captions can be enabled but do not play correctly. Mostly no captions are shown, and often when captions are shown, they are incorrect.
  
• 1023_20141226120000 - captions can not be enabled. There is no "enable" option in the onscreen subtitles menu. the only option is "download".
  

Both are ten minute samples. I can provide longer or different samples if useful.

[FernetMenta]

I fixed 1492_20141222131000 https://github.com/xbmc/xbmc/pull/6076
THe other one has only CEA 608 captions, not CEA 708. I am not sure if it's worth the effort implementing 608. What do you think? How many material with only 608 is out there?

[allan87]

I will check to see if other content on the same channel is affected. In terms of my testing so far, most of the ones that did not work were like 1492-xxx, which you have now fixed. The 1023-xxx recording is the only instance I have, at the moment, where no captions are shown at all.

I have also noticed a couple of cosmetic/gui issuesl, but I will wait until I have tested further before I report them here.

Thanks again.

[Ace]

Slightly of topic, but does anyone has a sample with (dvb) hearing impaired subtitles?

Got one.