(2015-11-07, 11:30)DaveBlake Wrote: @Jeron is still sounds that you are angry and offended by me.
I am not angry, just annoyed by the response as I see discussions on Git all the time. I think it's healthy and that it encourages involvement of the (developer) community. But as I said, I understand now what your comments about clutter and wanting to move this discussion to the forum were based on, even though I don't agree with them.
Quote:I did not intentionally twist any words, I simply responded to what I thought you were saying. I want to discuss this issue reasonably and calmly even though it is one where opinion is clearly divided.
I reported that the merged PR is causing a problem for me as a skin developer, and you explain this as me wanting to "dumb down Kodi" user features. That
is twisting my words, be it intentionally or not.
But let's leave this false start behind us and focus on the matter.
(2015-11-07, 11:27)jjd-uk Wrote: Could you explain why this is wrong? seems logical to me that a folder of music contains a content type of Songs?
Yes, that is logical (in most cases), and I am not claiming otherwise. In this folder / file listing:
Code:
[filesystem]
[folder]
[song1.mp3]
[song2.mp3]
[...]
It is totally logical to set the content type of the folder to songs.
In this example
Code:
[filesystem]
[folder]
[folder]
[folder]
I don't find it logical at all to set the content type to songs, as there are none in this listing. Yet this is what Kodi currently does, simply because of the fact that this folder structure is present in music's files node.
In this example
Code:
[filesystem]
[folder1]
[folder2]
[subfolder]
[song1.mp3]
[...]
I find it logical to set the content type of the subfolder of folder2 to songs, but nothing else. Yet, Kodi treats everything in this listing as songs.
Futhermore it is very dependant on the file and folder structure,
epecially in a files view as different people use different structures.
I can have this layout for example
Code:
[filesystem]
[folder]
[subfolder]
image1.jpg
booklet.pdf
somefile.foo
[song1.mp3]
[song2.mp3]
The subfolder could contain album art, digital booklets, whatever. They are related to my music, but they are not songs and as such do not contain any song related tags or metadata on which skinners often base the chosen layout, infolabels, etc.
I have said on multiple occasions over the years that I feel that content types should be used for the library, or files mode should simply be set to a "files" content type (for music, video, pictures, everything). That way skinners can simply base their layout in the files nodes on ListItem.HasFiles, ListItem.IsFolder, etc. And maybe for music there could be specific infolabels that interpret the tags / file properties. I am in no way saying that reading file properties should be removed from Kodi. Quite the contrary, I feel that a file properties based listing should be the default, with the optional retrieval of rich metadata from the web. That would truly be a unified music section.
But to me the heart of the matter is, don't make assumptions about the content type. Content types should be set according to:
- What the user has set the content type to (when setting up media sources)
- What an add-on reports the content type to be (this is hardly without it's own set of problems, but that's another discussion)
And not based solely on the fact that some folder happens to be somewhere in the music's sources.