(2016-06-12, 11:40)black_eagle Wrote: Users DO NOT need the ability to edit their tags if they are using MBID's as editing them afterwards just causes issues.
Mistakes in the MB database - how can you possibly expect this to be handled in software 
A mistake is just that, and if/when discovered it needs fixing in the MB database. This isn't down to Kodi or it's devs, but the users. Admittedly it's probably the more 'power' users rather than casual, but it's still a meta-data issue that requires fixing at the source, not with some cobbled together code in Kodi.
Users may not NEED the ability to edit tags, but, being able to correct MBids information for a user is key (I have an artist: The smashing pumpkins (most often tagged by MBids) and smashing pumpkins (both names are correct/used), Now if i would like the name to be "smashing pumpkins" all the time how do you correct that? you wont be able to have MB correct it since both are correct. So, it needs to be handled in SW ie... edit the tag .
As for handling it in SW its easy.... but the issue is Kodi as Dave has stated... Kodi matches on the first instance if that is an incorrect match the rest of your library is F'd.
SW can easy look at an array and make a determination....
if
b,a=1,2
b=2
b=2
b=2
c=3
what does a=?
if you can see a most likely equal to 1 so can SW ( and i will agree that a=1 is just a guess/ but add 100 more data points and that guess gets better)
Now, the way kodi handles it is (using the data set above) when it sees b,a =1,2 it sets b=1 and a=2;
Kodi will end up with the following results;
b=1
a=2
b=1
b=1
b=1
c=3
this happens all the time if the wrong artist is before the correct match and is why i suggested to look at the whole DB before signing an artist to a MBid. Making a guess on the first occurrence is just lazy programing.
I will agree only "power users" are going to track down MB and have them correct it.... hence the reason i said "normal" users will just move on to another program.
Quote:Such code might fix an issue for yourself, but create issues for others. Fixing the meta-data fixes it for everyone that uses it.
You could be correct that's what quality testing is for and the way the SW works.... now seems to be incorrect and does not work with my data. So, is the reason for not changing the code could break other users then the same weight has to be given to condemning the current code.
Quote:Fix the meta-data. Why do you need to jump through hoops to ensure everything is matching (given that scanning can take a while on a large collection anyway, without extra stuff added in) when fixing the meta-data once cures the problem for everyone.
The reason to make sure everything is matching is to give the user correct matches? but, to your point... fixing the meta-date is a burden put upon the user that does not need to be there. Kodi ignores/makes assumption the the first instance it sees the error is correct. when a mismatch happens the "normal" user has no way to correct the issue. you do not see MBids in Itunes for example (if i remember correctly) So, Fixing the meta-data in your suggestion is going to MB and setting up an account and suggesting a change, wating for that change to be approved, then re running your music for MBids... this is the easiest solution? when a simple edit locally would do it.
....talk about the time it would take to scanning a large collection
not related to the above...
? before multi artist did you have a library of artist that showed as an example Artist1 and another for Artist1 feat artist2 and another for Artist2?
you have a thread on compilations.... in the past did you change the album id to Various Artists or let your library display all the different artist?
Im just wondering if you ever edited a tag or used whatever you were given....because, i know gracenotes didnt take suggestions from users... and back then were the only option for getting CD ripping info.
Quote:So, you want Kodi to match an unknown (to MB) artist to the MBID associated with the 'most consistent id3 tag(s)' I can't see how that would possibly help - indeed it would likely create a great mess.
Im not sure what you mean by unknown? but statistically if artist X shows to have MBid XXF24 assigned to it 100 times and artist B has it once... It would be a better guess that artist X = MBid 24 than artist B.... making B an unknown or when MBids had a second entry for that song where it was assigned Artist X, you could assume artist B was the other MBid and check.... and if artist B was assigned an Id somewhere else in the collection and the IDS matched you found artist B MBid.
like i said before this corrects kodi making an assumption on a MBid when it first sees it..... if you were blind and someone tells you red was really green but, 50 other people told you red was red.... would you say no the first person told me what red is.... are all 50 people of you are wrong?
Quote:Yes, I use MBID's. Yes, I tag all my files with Picard. Kodi's library is pretty much exactly how I want it to be. It certainly doesn't frustrate me.
There are certain times when having the ability to edit an artist inside of Kodi would be advantageous but generally, I would suggest that all the tag editing is done outside of Kodi. If Kodi produces a result you don't like, then this is, in the vast majority of cases, down to the tagging being incorrect. Users have a choice as to whether or not to tag with MBID's. In most cases, doing so gives a far better library experience than not although of course each individual user is entitled to do as they wish.
I would agree with you that editing Tags outside of Kodi is Great... however, because Kodi uses MBids correcting your id3 Tags will have NO effect on your Kodi library.
and my suggestion to edit was only say the artists name so if you had artist a and wanted it to be artist A you could change that.... I guess i when further and said if a user changed artist A to artist B it might be a good time to see if artist A was assigned artist B's MBid for some reason. and to take the users input as having more weight.
"...individual user is entitled to do as they wish." this is all that im saying .... Kodi needs to give users a say in how the library is organized... and like i suggested in the beginning of the thread to Dave when trying to solve my issues i see ( not believing ... the user should correct their tags was the right answer)... but add more weight to the ID3 tags and not MBids....
but then asked how SW was to correct Mismatches, i gave my opinion (showed a low level example) on how i would go about it......
Anytime the simple order of your files/data effects the results... the SW is broke!!! and is not an issue that should be pushed onto the user.
and while you could do this in the cleanup of the library (after getting the initial data), writing code to fix bad code is just bad programing and should be corrected at the source.
BR
Troy
[Edited to make quotes more readble - DB]
