Not sure which thread to post in so feel free to move if needed.
@
sualfred @
pkscout @
roni (not sure if you are the correct developers or if you can pass this on)
Using v20, I get two addon pop-up errors re: Embuary Helper and Artist Slideshow. Also, the Kodi log file updater is not compatible yet either. Thought perhaps you could have a look. Thank you.
https://paste.kodi.tv/vekukoheyo.kodi
(2021-04-07, 19:56)brazen1 Wrote: [ -> ]Not sure which thread to post in so feel free to move if needed.
FYI, there is now a v20 prefix available for forum threads.
AS is still using xbmc.translatePath, and that was depreciated for Kodi 19 and removed in Kodi 20. I thought I had gotten all those updated for Matrix, but I guess I missed the ones in AS. To get it working in Kodi 20 for now, you can edit resources/lib/kodisettings.py and change lines 3 to 13 to read:
python:
from kodi_six import xbmc, xbmcaddon, xbmcvfs
ADDON = xbmcaddon.Addon()
ADDONNAME = ADDON.getAddonInfo('id')
ADDONLONGNAME = ADDON.getAddonInfo('name')
ADDONVERSION = ADDON.getAddonInfo('version')
ADDONPATH = ADDON.getAddonInfo('path')
ADDONDATAPATH = xbmcvfs.translatePath( ADDON.getAddonInfo('profile') )
ADDONICON = xbmcvfs.translatePath('%s/icon.png' % ADDONPATH )
ADDONLANGUAGE = ADDON.getLocalizedString
SKINNAME = xbmc.getSkinDir()
@
pkscout
Thank you very much. That took care of Artist Slideshow error. Perhaps merge into nightlies.
@
brazen1 FYI, the embuary error is more than likely the same thing as I stumbled across that myself earlier today. Lines that need fixing are
python:
./script.embuary.helper/resources/lib/utils.py:571: path = xbmc.translatePath(remove_quotes(params.get('path')))
./script.embuary.helper/resources/lib/helper.py:23:ADDON_DATA_PATH = os.path.join(xbmc.translatePath("special://profile/addon_data/%s" % ADDON_ID))
./script.embuary.helper/resources/lib/helper.py:24:ADDON_DATA_IMG_PATH = os.path.join(xbmc.translatePath("special://profile/addon_data/%s/img" % ADDON_ID))
./script.embuary.helper/resources/lib/helper.py:25:ADDON_DATA_IMG_TEMP_PATH = os.path.join(xbmc.translatePath("special://profile/addon_data/%s/img/tmp" % ADDON_ID))
./script.embuary.helper/resources/lib/image.py:209: img = Image.open(xbmc.translatePath(cache))
./script.embuary.helper/resources/lib/image.py:223: img = Image.open(xbmc.translatePath(image))
./script.embuary.helper/resources/lib/plugin_content.py:152: resource_dir = xbmc.translatePath('resource://%s/' % resource_addon)
Just replace each instance of
xbmc.translatePath with
xbmcvfs.translatePath and you should be good.
@
black_eagle
Awesome! That takes care of Embuary Helper. Great support. Thank you very much.
(2021-04-11, 16:42)brazen1 Wrote: [ -> ]Awesome! That takes care of Embuary Helper. Great support. Thank you very much.
No worries, I'll ask the dev if he can kick out an update as others will probably encounter this too.
First link is to PR's that have been raised against master. For those 'not in the know', these are requests to alter Kodi's code in some way. E.G. adding new features, fixing bugs etc. Issues are a different thing and are at
https://github.com/xbmc/xbmc/issues
Progressing PR's is often slow. People have jobs, families etc and those needed to review the code are not always available. I know it can grate but it's just the way things are. Best I can say is to just keep an eye on things.
(2021-04-11, 16:06)brazen1 Wrote: [ -> ]@pkscout
Thank you very much. That took care of Artist Slideshow error. Perhaps merge into nightlies.
Add-ons aren't done as nightly builds. They are in the repo, and I believe v20 is still using the Matrix repo (at least until v20 gets a name). And then I think the repo inherits all the add-ons from the repo for the current version. Bottom line, I need to update AS and put in a PR in repo-scripts to update it. There are some other things I need to work on with AS, and the repo code reviewers are kind of overwhelmed with people finally doing Matrix updates for their add-ons. So I don't want to submit an update to fix a problem that only occurs in v20 nightlies unless there are other updates for v19 to go with it.
Using v20, I seem to have lost some of the common player controls that were working previously such as skip chapters, skip steps forward/back , FF/REW, video info (pressing O or Alt+O) etc. Some controls such as pause/play were not affected.
For me, iso's will not work at all but mkv's do.
I have tested some builds to narrow down what builds work and what builds do not.
These do not work:
KodiSetup-20210507-20966dcf-master-x64.exe
KodiSetup-20210428-1e9e4aa0-master-x64.exe
KodiSetup-20210424-d8553f51-master-x64.exe
KodiSetup-20210421-513944f1-master-x64.exe
KodiSetup-20210416-5fc65649-master-x64.exe
KodiSetup-20210408-8dfbce10-master-x64.exe
These do work:
KodiSetup-20210404-7ad079de-master-x64.exe
KodiSetup-20210401-145e4133-master-x64.exe
So, it appears whatever changed after the 4/04 build inadvertently affected some of the player controls for us iso users. Understand iso means with full video menus.
I doubt a debug log(s) is needed but if it would help I can provide one upon request.
(2021-05-09, 23:46)brazen1 Wrote: [ -> ]Using v20, I seem to have lost some of the common player controls that were working previously such as skip chapters, skip steps forward/back , FF/REW, video info (pressing O or Alt+O) etc. Some controls such as pause/play were not affected.
For me, iso's will not work at all but mkv's do.
I have tested some builds to narrow down what builds work and what builds do not.
These do not work:
KodiSetup-20210507-20966dcf-master-x64.exe
KodiSetup-20210428-1e9e4aa0-master-x64.exe
KodiSetup-20210424-d8553f51-master-x64.exe
KodiSetup-20210421-513944f1-master-x64.exe
KodiSetup-20210416-5fc65649-master-x64.exe
KodiSetup-20210408-8dfbce10-master-x64.exe
These do work:
KodiSetup-20210404-7ad079de-master-x64.exe
KodiSetup-20210401-145e4133-master-x64.exe
So, it appears whatever changed after the 4/04 build inadvertently affected some of the player controls for us iso users. Understand iso means with full video menus.
I doubt a debug log(s) is needed but if it would help I can provide one upon request.
I can try and help test this out, is it via remote(which kind) or keyboard inputs?
It doesn't matter. I use a Harmony 900 remote with a Microsoft Keyboard added as a device for it. Button presses mimic a physical keyboard exactly. On top of that, I use a Microsoft physical keyboard. The problem exists using either one.
okay i can confirm these controls do not work ISO and folder in kodi 19.3 git date 27/10/21 and i found a build from 23/07/21 and they do not work there either will hunt around for any earlier builds i might have dotted around on usb sticks or something
got a build from june 5th am installing
don't work there either
folder or ISO does not seem to matter is just an issue when using JAVA menu's