Release skin helper service - Printable Version +- Kodi Community Forum (https://forum.kodi.tv) +-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32) +--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12) +---- Forum: Skin helper addons (https://forum.kodi.tv/forumdisplay.php?fid=300) +---- Thread: Release skin helper service (/showthread.php?tid=235676) Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
|
RE: skin helper service - User 224999 - 2016-12-02 (2016-12-02, 19:25)Angelinas Wrote: 1-stil same problem about movies -always find tvshow(if excist) I'm sorry but I can't follow this. Please make sure to seperate your questions and not mix them up. That combined with bad English makes it impossible for me to read as English, sorry. If I understand correctly, you have the folowing issues: 1) The PVR Art function is still not working correctly in your case, it prefers tvshows all the time while it should be movies. Question a) Can you please check whatever is set in the infolabel $INFO[ListItem.genre] in your case ? Question b) If you chooce "manual lookup" from the context menu, are presented with a dialog to choose if it's a movie or tvshow ? Question c) Do you actually see the "TMDB results" selection box when you do a manual search for PVR artwork ? 2) The SkinHelper.Pvrbackground doesn't show fanarts from TV channels, only from recordings. Answer: You probably have cleared the cache. Now it will take up to 30 minutes before the backgrounds will start showing. They're lazy loaded in the background to not stress the load too much. The other questions/reports I couldn't make heads or tails about them so please rephrase them more clearly. RE: skin helper service - Angelinas - 2016-12-02 Sorry but english is not mine native language Other who know english will write about this....For me PVR dont work as should I write Tarzan english..but I put images to see what I cant explain with word. 1: a) Genre is "Adventure" (pvr is collect from epg.xml as label<genre>,not by number "19516") b) Yes after search dialog open top menu dialog to choose if it's a movie or tvshow c) yes, and no ( no, is when I have in same channel EPG Evants Title no:1 "spider-man 2" and no:2 "spider-man 3") 2 I can live without this RE: skin helper service - User 224999 - 2016-12-03 (2016-12-02, 23:32)Angelinas Wrote: Sorry but english is not mine native language No worries, it's not my native language too so that makes it extra difficult I guess. What exactly do you use in your skin to display the genre ? Type EXACTLY what you use as $INFO[something]... Also, please give me the results of $INFO[ListItem.genre] - I know you're not using that but I need to know what it's displaying. EDIT: found more more bug in the pvrart code. Please test with new version RE: skin helper service - wheatfield - 2016-12-03 (2016-12-02, 22:13)marcelveldt Wrote:(2016-12-02, 09:15)wheatfield Wrote: Hey Marcel, I've noticed that in PVR recordings, images no longer display at the group folder level. Is this intentional? Thanks. I only got it to work by using manual lookup and ignoring the active filter warning. When the keyboard dialog pops up, it is only displaying the first word of the title, so I type in the rest. I guess I'm not understanding how the filters work. The folders are named like the title of the movie or tv show, though there are episode titles for the actual episode recordings in the folder. EDIT: It looks like artwork will appear inside movie folders (since the file and the folder are named the same), but not episode folders (folder is TV Show title, but file may be named "S01E01 - Pilot" for example). All this is only possible with manual lookup. RE: skin helper service - echo - 2016-12-03 (2016-12-02, 22:30)marcelveldt Wrote: Ok, so that might not be related, but the problem with multiple eps shown is still there. Sorry I dont know how else to help...there is nothing in the log.. Is there any other info I can provide you to help out with sorting this out? RE: skin helper service - Angelinas - 2016-12-03 (2016-12-03, 02:49)marcelveldt Wrote: What exactly do you use in your skin to display the genre ? Type EXACTLY what you use as $INFO[something]...here is one excample: $INFO[ListItem.Title] ---> Home $INFO[ListItem.Genre] ---> Adventure In simplecache.db have id "pvr_artwork.home.sky movies family uk" for this id have data: Code: {'art': {u'fanart': u'C:\\Kodi\\Music\\Home\\fanart.jpg', u'banner': u'C:\\Kodi\\Music\\Home\\banner.jpg'}, 'cachestr': u'pvr_artwork.home.sky movies family uk', 'pvrtitle': u'Home', 'pvrchannel': u'Sky Movies Family UK', 'pvrgenre': u'Adventure', 'genre': [u'Adventure'], 'media_type': ''} In simplecache.db have meny pages for tmdb.get_data.search/multi tmdb.get_data.search/multi.{'query': u'home', 'page': 4, 'language': 'en'} and one for tmdb.get_data.search/movie Only this data with ID "artutils.get_tmdb_details...home.." is ok.This info is that I want to see on Kodi.(strange name for ID with lot of ...) For manual lookup chosen "movie" have new id in simplecache.db with name Code: pvr_artwork.home.sky movies family uk Code: {'art': {u'fanart': u'C:\\Kodi\\Music\\Home\\fanart.jpg', u'banner': u'C:\\Kodi\\Music\\Home\\banner.jpg'}, 'cachestr': u'pvr_artwork.home.sky movies family uk', 'pvrtitle': u'Home', 'pvrchannel': u'Sky Movies Family UK', 'pvrgenre': u'Adventure', 'genre': [u'Adventure'], 'media_type': 'movie'} This is real info that now is on PVR https://www.themoviedb.org/movie/228161-home RE: skin helper service - User 224999 - 2016-12-03 (2016-12-03, 06:29)wheatfield Wrote: I only got it to work by using manual lookup and ignoring the active filter warning. When the keyboard dialog pops up, it is only displaying the first word of the title, so I type in the rest. I guess I'm not understanding how the filters work. The folders are named like the title of the movie or tv show, though there are episode titles for the actual episode recordings in the folder. Please give me an exact example of one of your grouped recordings, so the title of the grouped folder AND one of the titles of the underlying episodes. Also notice that your naming convention is most probably causing the issue. You named it "S01E01 Pilot", there should be an tvshow title in the filename becaus ethat's what's used for lookups. A lookup for S01E01 will return exactly nothing. RE: skin helper service - User 224999 - 2016-12-03 (2016-12-03, 14:01)Angelinas Wrote: In simplecache.db have id "pvr_artwork.home.sky movies family uk" for this id have data: Are you aware that you're using "c:\Kodi\Music\" as a custom path for the pvrart ? Maybe it's just for test but it's kind of a strange path to save pvr art ;-) Can you please test without the custom folder in the addon settings ? I found a small bug where it completely skips the online scraper if any artwork is found in the custom folder. I will fix the bug now so you can also wait for next version. RE: skin helper service - Angelinas - 2016-12-03 (2016-12-03, 14:26)marcelveldt Wrote: Maybe it's just for test but it's kind of a strange path to save pvr art ;-)Yes,that is folder name (testing as you write) For manual storing Art (that working, I have all art in that folder) Please see why have that "point" (.) in "artutils.get_tmdb_details...home.." That cosing isue and Script can find right ID,Change when you have time ,I will change manual modul for testing Edit: yes...you find u bug when I Set without the custom folder in the addon settings Have ok resultats Only stay isue with tvshow (TVShow have in my library) in pvr dont have info from scraper. PVR is now in full power, tnx on your patience Title "Home" showing info RE: skin helper service - User 224999 - 2016-12-03 (2016-12-03, 14:35)Angelinas Wrote: Please see why have that "point" (.) in "artutils.get_tmdb_details...home.." No, that's not related, you can ignore that. It's just the way how the cache ids are structured, nothing of importance there. (2016-12-03, 14:35)Angelinas Wrote: yes...you find u bug OK, great. Version 1.0.15 of script.module.skinhelper.artutils is now uploading to the repo. That should fix the issues, thanks for testing and patience! It should also fix the lookup isses for grouped recordings reported by others. Note that the cache has to be reset or a manual lookup started to grab the new results RE: skin helper service - JohnyBee - 2016-12-03 (2016-12-02, 22:28)marcelveldt Wrote:Hi Marcel,(2016-12-02, 11:46)JohnyBee Wrote: Hi, Quote:It's working correctly on my setup with those exact same settings.Yes, I have the same structure of catalogs for music. Quote:Any errors in the logfile ?At logfile there is no errors for SkinHelper. My test for following settings: Lookup atrwork in a custom folder (e.g. recording folder) -ON Download (missing) atwork to my custom folder - ON Durring test for chosen artist I start function: Refresh (auto lookup) I found problem at fuction get_customfolder_path (file: \addons\script.module.skin.helper.artutils\lib\helpers\musicartwork.py) (when I was analizing and testing your code (is huge ) You function always analizing only first artist folder at custom folder and give back empty string. Your code: PHP Code: def get_customfolder_path(self, customfolder, foldername): My code after testing works good (it found folder of artist, copy banner.jpg, fanar.jpg, folder.jpg, logo.jpg to this folder and save to properties of SkinHelper) My code for testing: PHP Code: def get_customfolder_path(self, customfolder, foldername): If you find a litte time, check it please. RE: skin helper service - User 224999 - 2016-12-04 (2016-12-03, 17:27)JohnyBee Wrote: I found problem at fuction get_customfolder_path (file: \addons\script.module.skin.helper.artutils\lib\helpers\musicartwork.py) (when I was analizing and testing your code (is huge ) Thanks for the catch and the help. There was indeed a stupid error in the code. The fix however was a little more complicated than your change because it should be recursive. I have just fixed it. Do you mind testing it in the next update ? I will put it on the repo later today or first thing tomorrow. RE: skin helper service - wheatfield - 2016-12-04 (2016-12-03, 14:14)marcelveldt Wrote: Please give me an exact example of one of your grouped recordings, so the title of the grouped folder AND one of the titles of the underlying episodes. I figured the naming of the episodes was incorrect, I'm just sort of stuck with how the pvr names them. But I thought that I'd get images for the folders themselves since it's the title of the show. There's some additional debug information at the top of these screencaps. The artwork that is displaying is coming from the pvr itself, but it's really limited. RE: skin helper service - xodi - 2016-12-04 Got this error when opening an album. Code: WARNING: Skin Helper Service --> Traceback (most recent call last): RE: skin helper service - JohnyBee - 2016-12-04 (2016-12-04, 00:30)marcelveldt Wrote:(2016-12-03, 17:27)JohnyBee Wrote: I found problem at fuction get_customfolder_path (file: \addons\script.module.skin.helper.artutils\lib\helpers\musicartwork.py) (when I was analizing and testing your code (is huge ) Hi Marcel, script.module.skin.helper.artutils ver. "1.0.15 The problem still exists. Your code: PHP Code: def get_customfolder_path(self, customfolder, foldername): PHP Code: def get_customfolder_path(self, customfolder, foldername): If you find a little time, check it again please. |