+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: diffuse colour in texture attributes (/showthread.php?tid=104993)
diffuse colour in texture attributes - lemonboy - 2011-07-06
I have a simple patch for applying a diffuse colour in any texture as part of the xml attributes, this would apply to any control and any texture definition.
First - is there any interest in a patch of this nature?
Second - how can I put the patch forward for consideration?
I am new to this forum and would appreciate any help.
Thanks.
- jmarshall - 2011-07-07
Hi there, and welcome!
First: Probably - as you know, the base class handles it, so why not?
Second: A pull request on github please.
Cheers,
Jonathan
- lemonboy - 2011-07-08
Thanks for the quick reply.
Am really struggling with the git pull stuff.
I have forked the main source and am now trying to create the required number of branches with which I can then put forward one change.
I understand that for minor changes I must keep a set of branches for each change (still unsure of what a change v a branch v a fork is).
I understand how difficult it is to maintain a code base such as this, but surely the approach you have taken restricts contributions from external contributors and the guide is a bit light.
(this may be excessively harsh but I have read the guides for XBMC and GIT and am still confused, I can understand the XBMC code enough to propose changes but not how to actually propose them)
- Hitcher - 2011-07-08
I'm guessing this means we'll be able to do the following -
PHP Code:
<texturefocus colordiffuse="green">button.png</texturefocus>
<texturenofocus colordiffuse="grey">button.png</texturenofocus>
- jmarshall - 2011-07-09
@lemonboy: You don't HAVE to do a pull req - posting a patch is fine as well - we take code anyway you want to, the pull req is simply the preferred option. The next preferred option would be a git format-patch HEAD~1 (assuming 1 commit).
The advantage with a pull req however is huge once you've done it a couple times
To create a pull req for any project on github:
1. Fork the repo on github.
2. Add your repo as a remote to your existing clone of xbmc/xbmc, or just clone from your repo.
git remote add lemonboy <read_write_url_to_your_repo>
3. Fetch branches from your repo:
git fetch lemonboy
4. Create a branch off xbmc master:
git branch diffusecolor_everywhere origin/master
git checkout diffusecolor_everywhere
5. Commit your changes.
git add <foo>
git commit -m "awesome commit msg"
6. Push your branch to your repo
git push lemonboy diffuse_coloreverywhere
7. On github, send a pull req.
The advantage here is that as and when any changes are requested, you can just do them in your diffuse_coloreverywhere branch and push them to your repo. The pull request is then automatically updated.
Cheers,
Jonathan
- lemonboy - 2011-07-10
Hitcher - yes that is the idea.
jmarshall - Thanks for the advice, I see the advantages, but was just getting a little frustrated in the initial setup. I will try and use the pull request method - please be gentle if I get it a bit wrong.
- Hitcher - 2011-07-10
lemonboy Wrote:Hitcher - yes that is the idea.
Cool, it'll be welcomed by all of us I'm sure.
- Jeroen - 2011-07-10
Absolutely, I could definitely make good use of this
- Hitcher - 2011-07-28
Any progress on this yet?
I can't stress enough how this feature will help in reducing skin code.
Thanks.
- lemonboy - 2011-08-02
Have put in a pull request #268, waiting for approval/rejection. Try it yourself and let me know if it is good/bad.
- jmarshall - 2011-08-02
Apologies - I missed the update (no email from github for some reason) - have made some more comments.