diffuse colour in texture attributes
#1
I have a simple patch for applying a diffuse colour in any texture as part of the xml attributes, this would apply to any control and any texture definition.

First - is there any interest in a patch of this nature?

Second - how can I put the patch forward for consideration?

I am new to this forum and would appreciate any help.

Thanks.
Reply
#2
Hi there, and welcome!

First: Probably - as you know, the base class handles it, so why not?

Second: A pull request on github please.

Cheers,
Jonathan
Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


Image
Reply
#3
Thanks for the quick reply.

Am really struggling with the git pull stuff.

I have forked the main source and am now trying to create the required number of branches with which I can then put forward one change.

I understand that for minor changes I must keep a set of branches for each change (still unsure of what a change v a branch v a fork is).

I understand how difficult it is to maintain a code base such as this, but surely the approach you have taken restricts contributions from external contributors and the guide is a bit light.

(this may be excessively harsh but I have read the guides for XBMC and GIT and am still confused, I can understand the XBMC code enough to propose changes but not how to actually propose them)
Reply
#4
I'm guessing this means we'll be able to do the following -

PHP Code:
<texturefocus colordiffuse="green">button.png</texturefocus>
<
texturenofocus colordiffuse="grey">button.png</texturenofocus
Reply
#5
@lemonboy: You don't HAVE to do a pull req - posting a patch is fine as well - we take code anyway you want to, the pull req is simply the preferred option. The next preferred option would be a git format-patch HEAD~1 (assuming 1 commit).

The advantage with a pull req however is huge once you've done it a couple times Wink

To create a pull req for any project on github:

1. Fork the repo on github.
2. Add your repo as a remote to your existing clone of xbmc/xbmc, or just clone from your repo.

git remote add lemonboy <read_write_url_to_your_repo>

3. Fetch branches from your repo:

git fetch lemonboy

4. Create a branch off xbmc master:

git branch diffusecolor_everywhere origin/master
git checkout diffusecolor_everywhere

5. Commit your changes.

git add <foo>
git commit -m "awesome commit msg"

6. Push your branch to your repo

git push lemonboy diffuse_coloreverywhere

7. On github, send a pull req.

The advantage here is that as and when any changes are requested, you can just do them in your diffuse_coloreverywhere branch and push them to your repo. The pull request is then automatically updated.

Cheers,
Jonathan
Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


Image
Reply
#6
Hitcher - yes that is the idea.

jmarshall - Thanks for the advice, I see the advantages, but was just getting a little frustrated in the initial setup. I will try and use the pull request method - please be gentle if I get it a bit wrong.
Reply
#7
lemonboy Wrote:Hitcher - yes that is the idea.

Cool, it'll be welcomed by all of us I'm sure.
Reply
#8
Absolutely, I could definitely make good use of this Smile
Reply
#9
Any progress on this yet?

I can't stress enough how this feature will help in reducing skin code.

Thanks.
Reply
#10
Have put in a pull request #268, waiting for approval/rejection. Try it yourself and let me know if it is good/bad.
Reply
#11
Apologies - I missed the update (no email from github for some reason) - have made some more comments.
Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


Image
Reply

Logout Mark Read Team Forum Stats Members Help
diffuse colour in texture attributes0