+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111)
+---- Forum: Android (https://forum.kodi.tv/forumdisplay.php?fid=164)
+---- Thread: Kodi + Shield + Dolby Vision (/showthread.php?tid=349140)
RE: Kodi + Shield + Dolby Vision - jjd-uk - 2020-12-04
Well it appears Plex are using ffmpeg v4.2 and we are using ffmpeg v4.3 so it's possible there's a difference between those 2 releases that means it doesn't work. For those able to build for themselves then perhaps try with https://github.com/xbmc/FFmpeg/tree/release/4.2-kodi with the patch applied against that.
RE: Kodi + Shield + Dolby Vision - quietvoid - 2020-12-04
For anyone interested in this, I've pulled the whole diff of Plex's code onto ffmpeg v4.1, on the last changelog commit.
https://github.com/quietvoid/FFmpeg/commit/ee2c3377a5fb5b9836f89d77f0fde579949761ab
There's a bunch of tests that I forgot to remove, but overall it should be somewhat easy to spot differences.
Seems to be a bunch of Android MediaCodec code, might be relevant.
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-18
(2020-12-02, 01:05)Hitcher Wrote:Can you point me which commit is responsible for DV in mp4?(2020-12-01, 23:45)quietvoid Wrote: I'm still just trying to build Kodi master so that it works with mp4
It already works with mp4 on certain devices.
I have no idea how different mkv combined layers are compared to MP4 with BL EL and RPU and I can't find anything on Kodi.
EDIT: Nevermind found what I was looking for:
https://github.com/MediaArea/MediaInfoLib/commit/d8ef463e6ee5e9775fcdba6ac0e64211f3b2aff4
Those descriptors have to be implemented in Kodi for proper DV playback
Kodi + Shield + Dolby Vision - hoppel118 - 2020-12-19
Hi @fandangos
what does it mean? Did you get mkv Dolby Vision to work with Kodi Matrix?
If so, can you please collaborate with @quietvoid ?
(2020-12-04, 23:30)quietvoid Wrote: For anyone interested in this, I've pulled the whole diff of Plex's code onto ffmpeg v4.1, on the last changelog commit.
https://github.com/quietvoid/FFmpeg/commit/ee2c3377a5fb5b9836f89d77f0fde579949761ab
There's a bunch of tests that I forgot to remove, but overall it should be somewhat easy to spot differences.
Seems to be a bunch of Android MediaCodec code, might be relevant.
@quietvoid Have you made any progress?
Regards Hoppel
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-19
(2020-12-19, 03:59)hoppel118 Wrote: Hi @fandangos
what does it mean? Did you get mkv Dolby Vision to work with Kodi Matrix?
If so, can you please collaborate with @quietvoid ?
No, I have not.
I just wanted to figure out how much work is involved in getting mkv DV working.
RE: Kodi + Shield + Dolby Vision - looun - 2020-12-19
(2020-12-18, 23:01)fandangos Wrote: Can you point me which commit is responsible for DV in mp4?
dolby itself.
mp4 its container support by dolby vision SDK, MKV it's a "piracy" not supported by dolby ...obvious.
RE: Kodi + Shield + Dolby Vision - fritsch - 2020-12-19
(2020-12-19, 16:21)looun Wrote:(2020-12-18, 23:01)fandangos Wrote: Can you point me which commit is responsible for DV in mp4?
dolby itself.
mp4 its container support by dolby vision SDK, MKV it's a "piracy" not supported by dolby ...obvious.
You did not get the question at all ... he asked: why of the commits linked, make it possible to play DV from mp4s ..
About your pirated stance: The mp4 you have in hand, was that given to you by Dolby itself?
RE: Kodi + Shield + Dolby Vision - looun - 2020-12-19
there are demo file available on netflix a and also dolby web site
https://opencontent.netflix.com/
https://developer.dolby.com/tools-media/sample-media/video-streams/dolby-vision-streams/
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-19
(2020-12-19, 16:24)fritsch Wrote:I envy your patience, Fritsch LoL(2020-12-19, 16:21)looun Wrote:(2020-12-18, 23:01)fandangos Wrote: Can you point me which commit is responsible for DV in mp4?
dolby itself.
mp4 its container support by dolby vision SDK, MKV it's a "piracy" not supported by dolby ...obvious.
You did not get the question at all ... he asked: why of the commits linked, make it possible to play DV from mp4s ..
About your pirated stance: The mp4 you have in hand, was that given to you by Dolby itself?
RE: Kodi + Shield + Dolby Vision - jjd-uk - 2020-12-19
(2020-12-18, 23:01)fandangos Wrote: Can you point me which commit is responsible for DV in mp4?
No change has been done to Kodi to allow DV playback from mp4, we suspect it was something that came in via the last ffmpeg bump although no one appears sure exactly what enabled it to be done.
(2020-12-19, 12:20)fandangos Wrote:Have you seen the ffmpeg changes take from the Plex version https://github.com/xbmc/FFmpeg/pull/18 however it seems however that alone is not enough, so perhaps so Kodi side changes are also required.(2020-12-19, 03:59)hoppel118 Wrote: Hi @fandangos
what does it mean? Did you get mkv Dolby Vision to work with Kodi Matrix?
If so, can you please collaborate with @quietvoid ?
No, I have not.
I just wanted to figure out how much work is involved in getting mkv DV working.
The mkv org specification change was https://github.com/ietf-wg-cellar/matroska-specification/pull/390
Plex use Exoplayer for Android, so perhaps the additional changes there got it working them, yje Exoplayer changes are https://github.com/google/ExoPlayer/pull/7667 so maybe something similar on the player side required for Kodi
?
RE: Kodi + Shield + Dolby Vision - jjd-uk - 2020-12-19
Perhaps I should have said there's been no deliberate changes for mp4 with the aim of allowing DV mp4 playback. There's been work done for DV for Inputstream addons for services such as Netflix & Amazon Prime, but as far as I'm aware those changes should have had no effect on file playback.
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-19
(2020-12-19, 18:12)jjd-uk Wrote:ok..(2020-12-18, 23:01)fandangos Wrote: Can you point me which commit is responsible for DV in mp4?
No change has been done to Kodi to allow DV playback from mp4, we suspect it was something that came in via the last ffmpeg bump although no one appears sure exactly what enabled it to be done.
(2020-12-19, 12:20)fandangos Wrote:Have you seen the ffmpeg changes take from the Plex version https://github.com/xbmc/FFmpeg/pull/18 however it seems however that alone is not enough, so perhaps so Kodi side changes are also required.(2020-12-19, 03:59)hoppel118 Wrote: Hi @fandangos
what does it mean? Did you get mkv Dolby Vision to work with Kodi Matrix?
If so, can you please collaborate with @quietvoid ?
No, I have not.
I just wanted to figure out how much work is involved in getting mkv DV working.
The specification change was https://github.com/google/ExoPlayer/pull/7667
Exoplayer for Android added support so perhaps that might give hints https://github.com/google/ExoPlayer/pull/7667
So, grabbing the latest ffmpeg directly from FFmpeg git wasn't enough?
I'm trying to compile the android version on linux as I type this and trying to figure out if changing
~/kodi/tools/depends/target/ffmpeg/FFMPEG-VERSION
BASE_URL=https://github.com/FFmpeg/FFmpeg
like so, could be an easy start to work with the latest ffmpeg.
It's building here.
RE: Kodi + Shield + Dolby Vision - jjd-uk - 2020-12-19
(2020-12-19, 18:27)fandangos Wrote: So, grabbing the latest ffmpeg directly from FFmpeg git wasn't enough?
For mkv then no upstream FFmpeg git is not enough. Plex have forked ffmpeg so the pull https://github.com/xbmc/FFmpeg/pull/18 was an attempt to extract those changes from the Plex tarball (as typical Plex they make things awkward by having no public git hosting their fork), when it was discovered those alone weren't working the quietnoid then did the full diff https://github.com/quietvoid/FFmpeg/commit/ee2c3377a5fb5b9836f89d77f0fde579949761ab
RE: Kodi + Shield + Dolby Vision - jjd-uk - 2020-12-19
Also someone on the Kodi team did contact the ffmpeg devs, they suggested what Plex seem to have done for mkv was a copy & paste of some parts that were added to the ffmpeg code for mp4 resulting in code duplication, hence they said what submitted to us is not in a state that could be submitted to their upstream git.
[edit] As far as I can tell the ffmpeg changes for DV in mp4 were https://github.com/FFmpeg/FFmpeg/commit/1483cfa8177176b3d5d1c611424058bb9b59cf9f
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-19
Ok... you guys are very familiar that I'm noob AF when comes to dev work but...
@quietvoid aren't you missing BLOCK_ADDITIONAL_ID_DVCC = 0x64766343; ?