+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111)
+---- Forum: Android (https://forum.kodi.tv/forumdisplay.php?fid=164)
+---- Thread: Kodi + Shield + Dolby Vision (/showthread.php?tid=349140)
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-21
(2020-12-21, 22:30)hoppel118 Wrote:(2020-12-21, 21:54)fandangos Wrote: The FFMpeg changes needed are here:
https://github.com/fandangos/FFmpeg/tree/release/4.3-kodi
The changes needed in Kodi are here:
https://github.com/xbmc/xbmc/pull/18965
Build comming soon.
Am I getting you right? Does this code work?
Regards Hoppel
Yes
Kodi + Shield + Dolby Vision - hoppel118 - 2020-12-21
WOW!!! Thank you so much for making this happen. This is a really fantastic christmas present.
Thanks to @quietvoid @fandangos @sk83 @fritsch @Irusak @jjd-uk and Plex.
I am going to ask @Maven from the German Kodinerds community to build us a custom build.
The German Kodi community is ready to test that.
Regards
RE: Kodi + Shield + Dolby Vision - fritsch - 2020-12-21
Jenkins is already running and builds are finished. Fandangos will post these after they are tested.
RE: Kodi + Shield + Dolby Vision - rob87 - 2020-12-21
What a great surprise! I just upgraded to the new shield this weekend and i thought i have to switch to the emby client for DV files until kodi 20. Now it seems like perfect timing!
Thanks at all for your hard work.
Wish you a nice Christmas time!
RE: Kodi + Shield + Dolby Vision - Hitcher - 2020-12-21
(2020-12-21, 23:04)fritsch Wrote: Jenkins is already running and builds are finished. Fandangos will post these after they are tested.
Just ran some tests myself and everything is working perfectly as far as I can tell. Great work guys.
Kodi + Shield + Dolby Vision - hoppel118 - 2020-12-22
@Maven already gave us a test build. Dolby Vision is triggered! Yes!!!! So far so good. I am really impressed!
But there are some situations where movies do not start. Sometimes the frame rate changes to 23.9x fps, the osd shows the loading wheel and then nothing happens. The frame rate remains at 23.9x fps, even though it’s configured to „start / stop“.
Where is the right place to post debug log files, here in this thread?
Regards Hoppel
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-22
Ok, first build is here:
http://mirrors.kodi.tv/test-builds/android/arm64-v8a/
and here:
http://mirrors.kodi.tv/test-builds/android/arm/
If using this build set refresh rate change to always instead of on/off.
I believe I know why this is happening. This build uses amc-hevc for dolby vision, while using dvh1 with refresh rate switching doesn't produce the same error.
For people compiling their own versions:
Change this:
https://github.com/fandangos/Kodi-HDR-Edition/commit/0282f847d57567054afef72b4d93256c7d3c52ca#diff-1b6daeb37ffecaec8c337573af6035748aa92c3938748e9f8db583ed33d00a29R505
This line:
m_formatname = "amc-dvh1";
RE: Kodi + Shield + Dolby Vision - MrMagic - 2020-12-22
(2020-12-22, 01:19)fandangos Wrote: Ok, first build is here:First of all let me say thank you for all the work you are putting into this, together with the other people you mentioned.
http://mirrors.kodi.tv/test-builds/android/arm64-v8a/
and here:
http://mirrors.kodi.tv/test-builds/android/arm/
If using this build set refresh rate change to always instead of on/off.
I believe I know why this is happening. This build uses amc-hevc for dolby vision, while using dvh1 with refresh rate switching doesn't produce the same error.
What are the differences between those two decoders anyway?
Going to give your test build a go now, thanks again!
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-22
(2020-12-22, 01:45)MrMagic Wrote:(2020-12-22, 01:19)fandangos Wrote: Ok, first build is here:First of all let me say thank you for all the work you are putting into this, together with the other people you mentioned.
http://mirrors.kodi.tv/test-builds/android/arm64-v8a/
and here:
http://mirrors.kodi.tv/test-builds/android/arm/
If using this build set refresh rate change to always instead of on/off.
I believe I know why this is happening. This build uses amc-hevc for dolby vision, while using dvh1 with refresh rate switching doesn't produce the same error.
What are the differences between those two decoders anyway?
Going to give your test build a go now, thanks again!
I have no idea.
Those are requests made to the Android box.
We will set on the right one by experimenting.
AMC-HEVC is obviously for hevc. Which is the video encoder of 4k content. Dolby Vision is just dynamic metadata on top of it.
Since it worked for me during some testing I opted for it.
AMC-DVHE should be the one to go but for me, it crashes.
AMC-DVH1 is the one that actually works it seems but since dvhe was crashing and amc-hevc seemed to work I haven't tested the dvh1 before.
So, better change it and see what most people report
RE: Kodi + Shield + Dolby Vision - hoppel118 - 2020-12-22
Ok, will check it out.
Here I have a log file for you. I tested the linked dv samples linked in the wiki
https://kodi.wiki/view/Samples#4K_.28UltraHD.29 -> Dolby Vision MKV Test Samples (hosted by MakeMKV)
My Kodi GUI default frame rate is 50 fps and frame rate switch is configured to happen at "start / stop".
I tested the following files in the following order:
- P7_FEL_GIJoe_The_Rise_of_Cobra.mkv -> didn't play (spinning wheel) -> fps changed from 50 fps to 23.9x fps and stayed at 23.9x fps
- P7_MEL_GIJoe_The_Rise_of_Cobra.mkv -> didn't play (spinning wheel) -> fps still at 23.9x fps
- P81_GlassBlowing2_3840x2160@59_94fps_15200kbps.mkv -> played -> fps changed from 23.9x fps to 59.9x fps and stopped at 50 fps
- P7_FEL_GIJoe_The_Rise_of_Cobra.mkv -> played -> fps changed from 50 fps to 23.9x fps and stopped at 50 fps
- P7_MEL_GIJoe_The_Rise_of_Cobra.mkv -> played -> fps changed from 50 fps to 23.9x fps and stopped at 50 fps
- P81_GlassBlowing2_3840x2160@59_94fps_15200kbps.mkv -> played -> fps changed from 23.9x fps to 59.9x fps and stopped at 50 fps
- P7_MEL_GIJoe_The_Rise_of_Cobra.mkv -> played -> fps changed from 50 fps to 23.9x fps and stopped at 50 fps
- P7_FEL_GIJoe_The_Rise_of_Cobra.mkv -> played -> fps changed from 50 fps to 23.9x fps and stopped at 50 fps
I think these are the relevant profiles for the shield (about profile 8.1 I am not sure).
The behavior seems a bit sporadic. If I restart Kodi, it is possible that the P7_FEL/MEL files work directly, but not always. I don't know where to upload the debug log. 5.7MB are to big for Kodi hastebin, to big for pastebin and ubuntu paste runs into an error. The logs are 219KB, if I zip them. I uploaded them in the kodinerds forum, because here it's ssemingly not possible to upload a zip file. Maybe you want to have a look at the logfile:
https://www.kodinerds.net/index.php/Attachment/48132-kodi-zip/
Let me check your build with refresh rate change to always.
Regards Hoppel
RE: Kodi + Shield + Dolby Vision - quietvoid - 2020-12-22
Are the Kodi test builds a different version? I still don't want to install over my Leia.
RE: Kodi + Shield + Dolby Vision - fandangos - 2020-12-22
(2020-12-22, 02:21)quietvoid Wrote: Are the Kodi test builds a different version? I still don't want to install over my Leia.
If Jenkins builds, it will replace the one from play store.
Here are 2 versions that I've compiled that will not replace the original one:
This one uses DVH1:
https://mega.nz/file/SJsGhCBS#CqGRc7vvlwsVq4rz9BQUXldeXGhLe1AlUSzRMZ6-mW8
This one uses amc-hevc:
https://mega.nz/file/iNlUwa6b#P0Z9RA_S8yivKAbQE6lNGu2pK1CAEe2WmW8YHd7rMWU
I would say the first one will work without any problem.
RE: Kodi + Shield + Dolby Vision - quietvoid - 2020-12-22
(2020-12-22, 02:23)fandangos Wrote: If Jenkins builds, it will replace the one from play store.Thanks but those are not armv7a
Here are 2 versions that I've compiled that will not replace the original one:
This one uses DVH1:
https://mega.nz/file/SJsGhCBS#CqGRc7vvlwsVq4rz9BQUXldeXGhLe1AlUSzRMZ6-mW8
This one uses amc-hevc:
https://mega.nz/file/iNlUwa6b#P0Z9RA_S8yivKAbQE6lNGu2pK1CAEe2WmW8YHd7rMWU
I would say the first one will work without any problem.
I guess I will have to rebuild mine.
RE: Kodi + Shield + Dolby Vision - MrMagic - 2020-12-22
(2020-12-22, 01:57)fandangos Wrote: I have no idea.
Those are requests made to the Android box.
We will set on the right one by experimenting.
AMC-HEVC is obviously for hevc. Which is the video encoder of 4k content. Dolby Vision is just dynamic metadata on top of it.
Since it worked for me during some testing I opted for it.
AMC-DVHE should be the one to go but for me, it crashes.
AMC-DVH1 is the one that actually works it seems but since dvhe was crashing and amc-hevc seemed to work I haven't tested the dvh1 before.
So, better change it and see what most people report
Ok thanks. I have no clue either
I was just wondering that if you use the "wrong" decoder it would send a DV signal to the TV, but not use the metadata or something. But like you said you would need an HD Fury to be sure.I tested the Jenkins build and it seems to work fine with refresh rate changing set to "Always".
I will test your debug build with the DVH1 decoder tomorrow.
Kodi + Shield + Dolby Vision - hoppel118 - 2020-12-22
I tried it with the Jenkins build and it was the same behavior. It’s late here in Germany!
Will do some more tests tomorrow.
Thanks again!
Bye