Login at Kodi Home

Ben91 · 2012-01-04, 01:12

Hello.

I would like some help because I need to make (or someone makes it for me Smile

) a pull request on GitHub and as I'm not a developper and I have no idea how to do it...

As the devs are dead since 5 months (but work / code seems to be done...) and XBMC team didn't relay the old patches from trac.xbmc.org to GitHub (and either the information concerning that change ?) It may take some time to release the code...

Here you are the patch : http://trac.xbmc.org/ticket/11750

It seems that jmarshall fixed some issues (see post #37) and it's on his GitHub (https://github.com/jmarshallnz/xbmc/tree...eo_ratings)

Thank you for the help.

Cheers.

PS: I saw the last post on track ticket it's why I post here, absolutely don't know how to deal with "diff" stuffs and GitHub and so on...

jhsrennie · 2012-01-04, 12:13

Hi Ben. You'll need to get the work on GitHub (or find someone else to do it for you). Create a GitHub account then fork the XBMC repository. Make the changes to your fork of XBMC, then click the Pull request" button and this will send us a request to pull your changes into the XBMC repository.

JR

~~Ned Scott~~ · 2012-01-04, 15:47

jhsrennie Wrote:Hi Ben. You'll need to get the work on GitHub (or find someone else to do it for you). Create a GitHub account then fork the XBMC repository. Make the changes to your fork of XBMC, then click the Pull request" button and this will send us a request to pull your changes into the XBMC repository.

JR

Looks like JM already did that (minus the PR) at https://github.com/jmarshallnz/xbmc/tree...eo_ratings

Ben91 · 2012-01-04, 16:14

Ned Scott Wrote:Looks like JM already did that (minus the PR) at https://github.com/jmarshallnz/xbmc/tree...eo_ratings

Thanks for the help guys !

So what can I do more ? (Is it on the XBMC GitHub ?)

How can I use this feature ?

Cheers.

**spiff** · 2012-01-04, 16:18

the help pages on github are, believe it or not, very good. read. learn. that's what all of us did.

no, it has not been pulled into the main git.

Ben91 · 2012-01-04, 17:21

spiff Wrote:the help pages on github are, believe it or not, very good. read. learn. that's what all of us did.

no, it has not been pulled into the main git.

Ok thank you very much.

I'm going to do it.

Ben91 · 2012-01-05, 16:40

Done !

https://github.com/xbmc/xbmc/pull/607

Whaaaaaouuuu. GitHub is awesome ! Next step : Learn to dev and be a dev !

spiff Wrote:the help pages on github are, believe it or not, very good. read. learn. that's what all of us did.

no, it has not been pulled into the main git.

You were right Wink

! Help pages on github are great ! Thank you.

Cheers.