2014-07-25, 07:42
(2014-07-24, 19:40)DarkAngel2401 Wrote: I agree that this patch should be treated as some proof of concept. However I disagree dual audio (or in generic - multiple audio output) can be some sort of addon.
In my opinion combining sinks for multiple simultaneous audio output is too low level for being a plugin. Shouldn't it rather be handled directly within XMBC core, generally creating one master sink and every audio device which will be activated/configured by the user will be a slave of this master sink? In that way configuration of audio output can easily be configured in a generic way and code duplication is kept in limits.
... and yes I know, playing 'think tank' is one hand, implementing those ideas another ;-) ...
Kindof depends on how low level our addon api is though We have audio codecs as addons now, this is about as low level
Anyhow, if it would use a composite pattern it might even be valid to have in core I'd say, as the impact would be localized to a few files (just the dual audio sink).