2021-06-22, 21:19
(2021-06-22, 20:33)nfm886 Wrote:I have to admit that episode thumbs (especially in a high quality) look much better than only Landscape art(2021-06-22, 20:26)andash Wrote:(2021-06-22, 10:02)nfm886 Wrote: Hey,
I think I will bring back previous behavior on landscape art since it breaks some arts for example that one from YouTube.
Yesterday I was kind of tired to check it out but I found that, when you set Skin Settings > Library > Landscape art to true it will have similar behavior to that one we changed yesterday.
Would you like to test it out? If it's what you want I will bring back landscape arts to default with today's update.
If it not works as you want I will try to implement it in different way
Hi, I can see what's wrong with this approach now.
I only want this behaviour for small landscape view type, but changing this would be for all.
I think I found a solution.
add this this "Includes_Images.xml"
And change line 380 and 392 in Includes_Objects.xml fromxml:<variable name="Image_Landscape_Small">
<value condition="!String.IsEmpty(ListItem.Art(thumb)) + [String.IsEqual(ListItem.DBType,episode) | String.IsEqual(ListItem.DBType,video)] + String.IsEmpty(ListItem.Property(airday))+ !String.IsEqual(ListItem.Art(thumb),ListItem.Art(fanart))">$INFO[ListItem.Art(thumb)]</value>
<value condition="!String.IsEmpty(ListItem.Art(snap))">$INFO[ListItem.Art(snap)]</value>
<value condition="!String.IsEmpty(ListItem.Art(landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[ListItem.Art(landscape)]</value>
<value condition="!String.IsEmpty(ListItem.Art(tvshow.landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[ListItem.Art(tvshow.landscape)]</value>
<value condition="!String.IsEmpty(ListItem.Property(fanart))">$INFO[ListItem.Property(fanart)]</value>
<value condition="!String.IsEmpty(ListItem.Art(fanart))">$INFO[ListItem.Art(fanart)]</value>
<value condition="!String.IsEmpty(ListItem.Art(tvshow.fanart))">$INFO[ListItem.Art(tvshow.fanart)]</value>
<value condition="!String.IsEmpty(ListItem.Thumb)">$INFO[ListItem.Thumb]</value>
<value condition="!String.IsEmpty(ListItem.Art(thumb))">$INFO[ListItem.Art(tvshow.landscape)]</value>
<value condition="!String.IsEmpty(Container.Art(landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[Container.Art(landscape)]</value>
<value condition="!String.IsEmpty(Container.Art(tvshow.landscape)) + Skin.HasSetting(LandscapeArt)">$INFO[Container.Art(tvshow.landscape)]</value>
<value condition="!String.IsEmpty(Container.Property(fanart))">$INFO[Container.Property(fanart)]</value>
<value condition="!String.IsEmpty(Container.Art(fanart))">$INFO[Container.Art(fanart)]</value>
<value condition="!String.IsEmpty(Container.Art(tvshow.fanart))">$INFO[Container.Art(tvshow.fanart)]</value>
<value condition="!String.IsEmpty(Container.Thumb)">$INFO[Container.Thumb]</value>
<value condition="!String.IsEmpty(Container.Art(thumb))">$INFO[Container.Art(thumb)]</value>
<value>$INFO[ListItem.Icon]</value>
</variable>toxml:<param name="icon" value="$VAR[Image_Landscape]" />
xml:<param name="icon" value="$VAR[Image_Landscape_Small]" />
This should also keep episode images intact and take into account the use fanart option
Ok, changes are commited. You can test it if you want now by downloading zip file from main branch. I will probably push an update tomorrow.