[t0mm0]

I'm not sure I can use the self.queries, as I pass a rather commplex data structure, and keywords can clash with existing keywords used by the addon itself, so I have my own pack / unpack function for the savefavorite. For directories I need to keep the original queries intact, and to avoid keyword clashes I created the dict_to_string and string_to_dict functions, which can convert a dict where the values are dict, tuple, list, str, Nonetype, Bol, dict.

sounds complicated of course it is easy for me to say these things without seeing the code!

if you REALLY need access to the original sys.argv[2] (which i still need to be convinced of ) then you could alter the addon.__init__() to store it as a class attribute alongside the parsed version and that will at least save you passing it around again.

This is interesting, and it makes good sense to make it a class for itself, but I need a bit of help with how to do that. Should it be in it's own file, if so how do I make sure it can be imported, where should the file be placed etc

it could probably go in addon.py (at least for now). when using it from an addon, you would then just do

Code:

from t0mm0.common.addon import ContextMenu

Makes sense, and it's easy to do, as the create_favorite only returns a pre-defined dict, the data in the dict is first used/added on add_item / add_dir. This was more of a way to also separate the documentation, as it gave me a headache trying to make it look nice, and communicate the data structure without it getting confusing in the add_item, add_dir docs, and I think it makes it more logical to work with.

i think it makes sense to keep it together as from a user point of view it is just adding a context menu item.

Guess I'll just commit what I have now to my branch, before I break it

cool, git comes in handy when you start breaking things

t0mm0.