2018-04-16, 10:20
While looking at an artist/album local art bug, I have made some baby steps towards better disc set support 
Work is in PR13769 a Win64 test builds availlable 20180415-bc197eda-PR13769 (OSX also on the mirrors, ask for any other platform). Testing and feedback on this thread or on Github are welcome.
What to test? The scanning (from fresh and lib update) into the library of albums that are spread across multiple folders, and have local art files.
Testing doing it with "fetch additional info on update" enabled/disabled. Nice to check what happens with artist art too, either in with music or in the Artist Information Folder (using that feature yet?), particularly if the artist only has one album and it is a disc set. Try out adding local art (to the folder) for an artist that the scraper does not recognise, and then "refresh"...
Too much detail ? Basically if enough of you point it at your music collections it should shake out any silliness on my part.
The bug I have fixed is discussed here, wrong artist and album art being picked up.
How disc set art is now handled is probably best discribed with examples.
1) Local disc set cover art
Say you had this folder/file layout (actual names of folders is irrelevent, it is the content that counts):
artist/
artist/folder.jpg <------ artist art
artist/album/
artist/album/folder.jpg <-------album art
artist/album/CD1
artist/album/CD1/folder.jpg <-------Part1 cover art
artist/album/CD1/track01.mp3
...
artist/album/CD2
artist/album/CD2/folder.jpg <-------Part3 cover art
artist/album/CD2/track01.mp3
...
artist/album/CD3
artist/album/CD3/folder.jpg <-------Part3 cover art
artist/album/CD3/track01.mp3
...
Kodi now uses the art in the disc subfolders properly. Providing that all the music files in a subfolder are tagged with the same DISCNUMBER/TPOS, they all have the same embedded art (or none), and same album of course, then art from that subfolder will be used as the thumb when those songs are listed or played.
2). No disc subfolder art files
However what about when there aren't any disc subfolder art files?
artist/
artist/folder.jpg <------ artist art
artist/album/
artist/album/folder.jpg <-------album art
artist/album/CD1
artist/album/CD1/track01.mp3 <-------Art1 embedded in all disc1 files
...
artist/album/CD2
artist/album/CD2/track01.mp3 <-------Art2 embedded in all disc2 files
...
artist/album/CD3
artist/album/CD3/track01.mp3 <-------Art3 embedded in all disc3 files
...
Art1, Art2 and Art3 respectively will be shown when songs are listed, or when played. It does not fallback to the album art, and Kodi does not have a way to know when art1 = art2 = art3 (folders are processed separately, and that is the point when it has the embedded data to compare).
3) Embedded art varies within a disc
As usual variations in embedded art mean that Kodi uses it in preference to any local disc subfolder or album art. I am looking to add an option to "only use embedded art as a last resort", that should help those users that have inconsistent low res art embedded in their music files yet (because it varies within an album) Kodi keeps showing it during playback rather than the nice album covers they have downloaded.
Remember actual names of folders is irrelevent, it is the content and tagging that counts!!
Work is in PR13769 a Win64 test builds availlable 20180415-bc197eda-PR13769 (OSX also on the mirrors, ask for any other platform). Testing and feedback on this thread or on Github are welcome.
What to test? The scanning (from fresh and lib update) into the library of albums that are spread across multiple folders, and have local art files.
Testing doing it with "fetch additional info on update" enabled/disabled. Nice to check what happens with artist art too, either in with music or in the Artist Information Folder (using that feature yet?), particularly if the artist only has one album and it is a disc set. Try out adding local art (to the folder) for an artist that the scraper does not recognise, and then "refresh"...
Too much detail ? Basically if enough of you point it at your music collections it should shake out any silliness on my part.
The bug I have fixed is discussed here, wrong artist and album art being picked up.
How disc set art is now handled is probably best discribed with examples.
1) Local disc set cover art
Say you had this folder/file layout (actual names of folders is irrelevent, it is the content that counts):
artist/
artist/folder.jpg <------ artist art
artist/album/
artist/album/folder.jpg <-------album art
artist/album/CD1
artist/album/CD1/folder.jpg <-------Part1 cover art
artist/album/CD1/track01.mp3
...
artist/album/CD2
artist/album/CD2/folder.jpg <-------Part3 cover art
artist/album/CD2/track01.mp3
...
artist/album/CD3
artist/album/CD3/folder.jpg <-------Part3 cover art
artist/album/CD3/track01.mp3
...
Kodi now uses the art in the disc subfolders properly. Providing that all the music files in a subfolder are tagged with the same DISCNUMBER/TPOS, they all have the same embedded art (or none), and same album of course, then art from that subfolder will be used as the thumb when those songs are listed or played.
2). No disc subfolder art files
However what about when there aren't any disc subfolder art files?
artist/
artist/folder.jpg <------ artist art
artist/album/
artist/album/folder.jpg <-------album art
artist/album/CD1
artist/album/CD1/track01.mp3 <-------Art1 embedded in all disc1 files
...
artist/album/CD2
artist/album/CD2/track01.mp3 <-------Art2 embedded in all disc2 files
...
artist/album/CD3
artist/album/CD3/track01.mp3 <-------Art3 embedded in all disc3 files
...
Art1, Art2 and Art3 respectively will be shown when songs are listed, or when played. It does not fallback to the album art, and Kodi does not have a way to know when art1 = art2 = art3 (folders are processed separately, and that is the point when it has the embedded data to compare).
3) Embedded art varies within a disc
As usual variations in embedded art mean that Kodi uses it in preference to any local disc subfolder or album art. I am looking to add an option to "only use embedded art as a last resort", that should help those users that have inconsistent low res art embedded in their music files yet (because it varies within an album) Kodi keeps showing it during playback rather than the nice album covers they have downloaded.
Remember actual names of folders is irrelevent, it is the content and tagging that counts!!
