2011-01-13, 18:36
Hi
This looks very nice. However, I think it is somewhat overengineered.
The code is very well documented.
Why create so many files that only contain an empty exception class when you're not using autoloading? I like that you use the different Exception classes though.
Have a look here, for a much more straight-forward implementation for PHP:
https://github.com/kaigoh/XBMC-PHP
You will notice that there is a lot less code. I don't know why exactly uses so much more, perhaps it supports more things that the aforementioned implementation doesn't cover - I haven't looked at your code that closely. Maybe it is also, because of the overengineering - but that may be an "unfortunate" first impression.
This looks very nice. However, I think it is somewhat overengineered.
The code is very well documented.
Why create so many files that only contain an empty exception class when you're not using autoloading? I like that you use the different Exception classes though.
Have a look here, for a much more straight-forward implementation for PHP:
https://github.com/kaigoh/XBMC-PHP
You will notice that there is a lot less code. I don't know why exactly uses so much more, perhaps it supports more things that the aforementioned implementation doesn't cover - I haven't looked at your code that closely. Maybe it is also, because of the overengineering - but that may be an "unfortunate" first impression.
