devkid Wrote:Of course you can do that. I only patched what I needed to make it work on my linux box (debugged on Windows). That was SMB essentially and some linux issues. I dont have it on github so feel free to just merge the plain files.
There are still issues left:
-Sources wont get recognized when there are only RAR or ZIP videos in it. You need at least one not-archived movie to have the source get recognized
-Having completely empty source folders on linux did the JSON RPC GetDirectory call throw an exception for me. Not sure but I am considering this a bug of the JSON API. Thats why the NameException is caught now and handled.
-I guess there might still be some utf encoding issues left
btw movies inside of RAR/ZIPs get recognized correctly in that version also. But maybe it was only broken when used over SMB. Not sure anymore...
Yeah, I also noticed it detected an unadded RARed file on my sources, which I then deleted and tried to replicate using a zipped file but that didn't work for some reason, in theory their path will now be unescaped so you won't see all those %codes on the screen if this happens. Do you think it's necessary to also recognized sources with only archived video files? I'll edit this post later with version 2.1.0 (I hope I merged everything).
Oh and by the way, why did you use both find(os.sep) and [-1] == os.sep?
EDIT:
Missing Movie Viewer 2.1.0:
Changes:
- Support for every XBMC source type (thanks to devkid)
- Fixed Linux support (thanks to devkid)
- Fixed some mistakes in error messages
- Readded newline after every missing file in the output file
EDIT2:
Download