Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
(2016-03-04, 18:51)ashlar Wrote: (2016-03-04, 18:05)un1versal Wrote: If theres several distinct API keys in use on this addon alone, its possible to add, but it wouldn't be a trivial update like weather add-on similar update, but it would be possible.
Google must be strapped for bandwidth and cash these days.
Theoretically there's only one set of keys that's necessary to input. It's a set, so more than one string. But I think that a competent programmer should be able to do it quite easily (it's a matter of taking the in put of a couple of settings requesters and placing it in the right place in the configuration file). If I'm wrong, excuse me, I usually refrain from expressing thoughts about stuff like this, not being a programmer. But this, conceptually at least, seems really easy.
Yea It should be possible, but like I said its not as simple as the weather addon type similar change/support.
Im not a programmer either but I read the code for the weather addons.
Posts: 105
Joined: Dec 2013
Reputation:
0
Does this new plugin break other plugins which rely on the youtube addon? I don't want to fix youtube just to have those break.
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
(2016-03-05, 17:06)mattmartinolc Wrote: Does this new plugin break other plugins which rely on the youtube addon? I don't want to fix youtube just to have those break.
Highly illogical
Posts: 172
Joined: May 2014
Reputation:
34
I sent a pull request to Kolifanes repository... all he has to do is commit and provide a new zip file.
Here's the new feature.
ver 5.1.20.4 - API key in add-on settings
API key is now configurable from add-on settings. Users that have valid API key can now enter their key from add-on settings dialog. API Key from version 5.1.20.3 is never lost if end-user makes a change since version 5.1.20.3 API key is default value in settings.xml file. The youtube-tv key in login_client.py cannot be changed. Only kodi-quota, kodi-fallback and kodi-xx version will change when end-user enters their API key. If end-user enters a non-working key or makes a mistake when entering their key, the youtube add-on will continue to work if the end-user selects 'Default' button in the add-on settings since that will activate the default API key.
This new feature is safer for less experienced end-users since they can enter a valid API key without any python programming knowledge. All end-users who are currently using their own API key will like this new change as well because they will not need to keep editing login_client.py file and future updates should not change their API key setting.