[ekim232]

ah, there is always atleast 10.

settings -> video -> enable it. as i said clearly in the commit message + we said in the blog post

Thanks Spiff. Just saw it quickly on trac and went right for it. Didn't even think it needed to be enabled.

[Gamester17]

Anyone got any good screenshots to show of? Please post them here:
http://xbmc.org/theuni/2009/06/15/media-...g-support/

Thanks CapnBry for the filtering and the wonderful eye candy addition!

[Freddo]

I've just tried this out and it worked flawlessly on my entire movie collection, not that I ever had any doubts! Kudos CapnBry you've done an amazing job.

Just one tiny thing though, is FLAC support something I need to add to my skin, or is it something that needs to be added by the scanner first? I know there's pretty much only me using FLAC inside of mkv's (maybe a few others, for bd rips?) but I did notice it has correctly detected the number of channels, so I was curious to know if all I need do is add it to my skin to get it working.

Either way stunning work so far!

[midgetspy]

Does this feature include support for storing this info in the NFO file by an external NFO manager? Or is it purely up to XBMC to scan the files once they're in the library?

[XBMCG33K]

Will this work then?

Code:

<control type="image">
      <width>56</width>
      <height>25</height>
      <texture>flags\Defs\1080p.png</texture>
      <colordiffuse>ff2f9be1</colordiffuse>
      <aspectratio>keep</aspectratio>
      <include>MediaFlagAnimation</include>
      <visible>substring(ListItem.VideoResolution,1080p)</visible>
    </control>

[ccMatrix]

Will this work then?

Code:

<control type="image">
      <width>56</width>
      <height>25</height>
      <texture>flags\Defs\1080p.png</texture>
      <colordiffuse>ff2f9be1</colordiffuse>
      <aspectratio>keep</aspectratio>
      <include>MediaFlagAnimation</include>
      <visible>substring(ListItem.VideoResolution,1080p)</visible>
    </control>

No, VideoResolution only contains 480, 540, 720 or 1080. It does not have any p/i information.

[XBMCG33K]

OK that is quite simple to fix, other than that the code is fine right?

[CapnBry]

Just one tiny thing though, is FLAC support something I need to add to my skin, or is it something that needs to be added by the scanner first? I know there's pretty much only me using FLAC inside of mkv's (maybe a few others, for bd rips?) but I did notice it has correctly detected the number of channels, so I was curious to know if all I need do is add it to my skin to get it working.

It should just work. I didn't test with any flaac-in-mkv but for a quick test you could just set a label to ListItem.AudioCodec and it should show flaac (or whatever flaac is called to ffmpeg). Theoretically!

[CapnBry]

OK that is quite simple to fix, other than that the code is fine right?

It would work, but really if you're going to do flags you should consider using the shorter form:

Code:

<control type="image">
      <width>56</width>
      <height>25</height>
      <texture>$INFO[ListItem.VideoResolution,flags\Defs\,.png]</texture>
      <colordiffuse>ff2f9be1</colordiffuse>
      <aspectratio>keep</aspectratio>
      <include>MediaFlagAnimation</include>
      <visible>!IsEmpty(ListItem.VideoResolution)</visible>
    </control>

And then just have one control for all resolutions rather than multiple conditionally visible controls. This one control will use whichever icon is appropriate:
flags\Defs\1080.png
flags\Defs\720.png
flags\Defs\540.png
flags\Defs\480.png
or hide the image if no resolution

[CapnBry]

Does this feature include support for storing this info in the NFO file by an external NFO manager? Or is it purely up to XBMC to scan the files once they're in the library?

Yes, external NFOs are read (and written if you export library). MIP has supported it for months, not sure about any others. I posted the format further back in this thread.

[XBMCG33K]

It would work, but really if you're going to do flags you should consider using the shorter form:

Code:

<control type="image">
      <width>56</width>
      <height>25</height>
      <texture>$INFO
[ListItem.VideoResolution,flags\Defs\,.png]</texture>
      <colordiffuse>ff2f9be1</colordiffuse>
      <aspectratio>keep</aspectratio>
      <include>MediaFlagAnimation</include>
      <visible>!IsEmpty(ListItem.VideoResolution)</visible>
    </control>

And then just have one control for all resolutions rather than multiple conditionally visible controls. This one control will use whichever icon is appropriate:
flags\Defs\1080.png
flags\Defs\720.png
flags\Defs\540.png
flags\Defs\480.png
or hide the image if no resolution

A great idea, how would the control for all the res look though?

[watzen]

A great idea, how would the control for all the res look though?

Like he said?

the <texture>$INFO[ListItem.VideoResolution,/flagging/video,p.png]</texture>

will get the correct texture depending on the ListItem... so if the ListItem.VideoResolution contains 1080 the infotag will be equal to /flagging/video/1080p.png

$INFO[(infolabel),(prefix),(postfix)] = (prefix)(infolabel)(postfix)

then you just need images that corresponds to all possible resolutions. with only one control.

[digitalhigh]

Like he said?

the <texture>$INFO[ListItem.VideoResolution,/flagging/video,p.png]</texture>

will get the correct texture depending on the ListItem... so if the ListItem.VideoResolution contains 1080 the infotag will be equal to /flagging/video/1080p.png

$INFO[(infolabel),(prefix),(postfix)] = (prefix)(infolabel)(postfix)

then you just need images that corresponds to all possible resolutions. with only one control.

I'm not complaining by any means...but it would be nice if we could figure out a way to return 1080i or 1080p.

[spiff]

that information is stored nowhere.

we'd have to open the video, play some 20 secs of it (in the middle), analyze the picture and hopefully guess correctly!

you, on the other hand, can guess how likely that happening is

[ronie]

I'm not complaining by any means...but it would be nice if we could figure out a way to return 1080i or 1080p.

Since you're stepping in for fekker lately, do you perhaps have any idea how MIP is detecting progressive or interlaced ?