2018-07-24, 20:28
2018-07-24, 20:56
2018-07-24, 21:18
(2018-07-24, 20:56)smp1 Wrote: That issue was fixed in #0530 and reappeared in #0709.
If it is that issue, then it's the detection of inline asm. Prior to #709 we had a fix for the issue in the patches, but from #709 the fix should be upstream in ffmpeg code.
@Milhouse can you confirm this line is present in the ffmpeg source tree of your build?
https://github.com/xbmc/FFmpeg/blob/4.0....gure#L1039
It should look like
Code:
"\"$2\""
Code:
"$2"
Edit: Milhouse have you bumped to ffmpeg 4.0.2 like kodi has?
2018-07-24, 22:28
The ""\"$2\""" is indeed missing from the patch for some reason. I rebuilt ffmpeg with "\"$2\"" and that video works properly now.
2018-07-24, 23:39
(2018-07-24, 21:18)popcornmix Wrote:(2018-07-24, 20:56)smp1 Wrote: That issue was fixed in #0530 and reappeared in #0709.
If it is that issue, then it's the detection of inline asm. Prior to #709 we had a fix for the issue in the patches, but from #709 the fix should be upstream in ffmpeg code.
@Milhouse can you confirm this line is present in the ffmpeg source tree of your build?
https://github.com/xbmc/FFmpeg/blob/4.0....gure#L1039
It should look like
rather thanCode:"\"$2\""
Code:"$2"
Edit: Milhouse have you bumped to ffmpeg 4.0.2 like kodi has?
No, LE master (and my builds) is still using 4.0-Leia-Alpha-1
This is what I see for the configure in ffmpeg:
I'll try updating to the latest ffmepg-4.0.2-Leia-Alpha3 - not always sure when to make the ffmpeg bump due to the ffmpeg patches we have.
2018-07-24, 23:47
New LibreELEC.tv Leia build #0724: RPi / RPi2
(Supercedes previous build)
SHA256 Checksum:
SHA256 Checksum:
Based on tip of LibreELEC.tv master (2a7ccda, changelog) and tip of XBMC master (c61da79, changelog) with the following modifications:
(Supercedes previous build)
SHA256 Checksum:
5ebe64ceb33154ebfb44bd94c8fe8b9d041445d55701509e7c6665c08987818a
(RPi)SHA256 Checksum:
f6e7dcd0e515da8e3926e0a412c57c8547d0e452fa743aaa1f64bcd5297db372
(RPi2)text:# uname -a
Linux rpi512 4.14.56 #1 Tue Jul 24 21:04:44 BST 2018 armv6l GNU/Linux
# vcgencmd version
Jul 17 2018 13:28:45
Copyright © 2012 Broadcom
version 4da89b2ba95c8826c492b1d734296c8a1a2c7d2b (clean) (release)
# lsb_release
LibreELEC (Milhouse): devel-20180724210326-#0724-g2a7ccda [Build #0724]
# Kodi version
(18.0-ALPHA3 Git:b7583e3). Platform: Linux ARM 32-bit
Based on tip of LibreELEC.tv master (2a7ccda, changelog) and tip of XBMC master (c61da79, changelog) with the following modifications:
- Includes newclock5 patches
- Includes latest commits from kernel branch rpi-4.14.y
- Includes latest bcm2835-driver master (bffe7ee)
- Includes latest kodi-platform master (e8574b8)
- Includes latest libcec master (8adc786)
- Includes latest libnfs master (322148b, ahead +6)
- Includes latest p8-platform master (a822e19)
- Includes latest addons: inputstream.adaptive (faf22f1), inputstream.rtmp (bf5351e), peripheral.joystick (207d433, +3), peripheral.xarcade (07be227, +7), pvr.argustv (37a3a76), pvr.demo (481f2fa), pvr.dvblink (c66203b), pvr.dvbviewer (75e2447), pvr.filmon (93ae10d), pvr.hdhomerun (ced70bd), pvr.hts (306fac5), pvr.iptvsimple (55637c8), pvr.mediaportal.tvserver (6439be6), pvr.mythtv (c4d8899), pvr.nextpvr (6f0515b), pvr.njoy (30aae48), pvr.octonet (1e44819), pvr.pctv (32d4b66), pvr.stalker (bfb875e, +2), pvr.teleboy (0460536), pvr.vbox (12e1304), pvr.vdr.vnsi (bb4fb30, +2), pvr.vuplus (75179a3), pvr.wmc (ec652db), pvr.zattoo (12134c8), vfs.libarchive (1bc1517)
- Include [env] patch: RPi/RPi2: enable Broadcom WiFi debugging (see details)
- Include [env] patch: kodi: remove annoying, excessively repetitive addon logging
- Include [env] patch: rev hack for kodi
- Include [env] patch: HACK: Disable multiple PVR addons during migration. Always enable inputstream.* and os.*
- Include [env] patch: Add experimental splash video for RPi
- Include [env] patch: Bump included addon versions to prevent online updates
- Include [env] patch: Add kodi binary addons (pvr, adsp, inputstream, vfs, peripheral.joystick/xarcade, other)
- Include [env] PR:2837 (perma): linux (RPi): update to linux-4.14.56
- Include [env] PR:2838 (perma): linux (Generic): update to linux-4.17.9
- Include [pkg] PR:10 (perma): Add new ids (RTL8812AU)
- Include [pkg] PR:14137 (perma): addondb: avoid constraint violation
- [Subtitles] Background color and background opacity settings
- [JSON]Fix music source handling to match schema
- LibreELEC.tv:
- distro: allow configurable settings addon (PR:2843, 1 commit, 2 files changed)
- distro: allow configurable settings addon (PR:2843, 1 commit, 2 files changed)
- XBMC:
- [VideoLibrary] Do not scan unsupported plugin sources + fix database cleaning (PR:14210, 2 commits, 8 files changed)
- Use EGLContextUtil in Wayland (PR:13746, 14 commits, 15 files changed)
- RetroPlayer: Remove width and height state from renderers (PR:14208, 5 commits, 16 files changed)
- [Subtitles] Background color and background opacity settings (PR:14056, 9 commits, 13 files changed)
- [JSON]Fix music source handling to match schema (PR:14222, 1 commit, 3 files changed)
- [VideoLibrary] Do not scan unsupported plugin sources + fix database cleaning (PR:14210, 2 commits, 8 files changed)
- peripheral.joystick:
- Updates for addon.xml.in (PR:149, 2 commits, 1 file changed)
- Updates for addon.xml.in (PR:149, 2 commits, 1 file changed)
- peripheral.xarcade:
- newclock5:
- Commits no longer in build:
- OMXImage: Switch filename to std:tring (5605c565)
- OMXImage: Switch filename to std:tring (5605c565)
- Commits no longer in build:
2018-07-25, 00:47
(2018-07-24, 23:39)Milhouse Wrote: I'll try updating to the latest ffmepg-4.0.2-Leia-Alpha3 - not always sure when to make the ffmpeg bump due to the ffmpeg patches we have.
LE master and patches builds OK with ffmepg-4.0.2-Leia-Alpha3 so I'll include the ffmpeg bump in #0725.
2018-07-25, 01:12
2018-07-25, 01:42
I see a hevc issue that started with #0722, fast motion even at 720p on a Rpi3 is jerky, so looking forward to #0725 to see if it is corrected. It isn't unwatchable which is why I didn't post a log file, but can definitely tell something isn't quite right.
The #0722 change log says it already includes ffmepg-4.0.2-Leia-Alpha3, so is that correct milhouse, or is there a newer alpha you meant to reference?
The #0722 change log says it already includes ffmepg-4.0.2-Leia-Alpha3, so is that correct milhouse, or is there a newer alpha you meant to reference?
2018-07-25, 01:55
2018-07-25, 02:17
well that's the build where I noticed the issue, and I ran #0721 which I didn't notice it.
2018-07-25, 07:24
(2018-07-25, 01:42)J_E_F_F Wrote: The #0722 change log says it already includes ffmepg-4.0.2-Leia-Alpha3, so is that correct milhouse, or is there a newer alpha you meant to reference?
LibreELEC builds an "external" ffmpeg, while Kodi is usually built with (and hence maintains) an "internal" ffmpeg version which is essentially irrelevant to LibreELEC (so long as the API remains compatible). In #0722, Kodi bumped the "internal" version, but LibreELEC remained on an older ffmpeg version as bumping ffmpeg isn't always possible until the various ffmpeg patches in LibreELEC are updated. As it happens those patches didn't need bumping (my fault for not checking) and I've now bumped to ffmpeg-4.0.2-Lei-Alpha3 for the next build.
Long story short, even though the Kodi part of the #0722 change log states that ffmpeg has been bumped in Kodi (and it was) there were no ffmpeg (or hevc) changes in the #0722 build.