Login at Kodi Home

Bumpaneer · 2014-06-05, 18:43

Travelling for work currently. I'll fix it in a week or so when I get back home. Thanks for reporting.

**Martijn** · 2014-06-05, 18:45

Maybe a suggestion to make a XBMC version depending check/conversion?

**Jeroen** · 2014-06-06, 07:01

(2014-06-05, 18:43)Bumpaneer Wrote: Travelling for work currently. I'll fix it in a week or so when I get back home. Thanks for reporting.

Thanks! Maybe as a feature suggestion including an option to remove BOM's? The tool I mentioned before is open source, maybe you can use that ?

Bumpaneer · 2014-06-06, 15:32

(2014-06-06, 07:01)Jeroen Wrote:
(2014-06-05, 18:43)Bumpaneer Wrote: Travelling for work currently. I'll fix it in a week or so when I get back home. Thanks for reporting.

Thanks! Maybe as a feature suggestion including an option to remove BOM's? The tool I mentioned before is open source, maybe you can use that ?

It actually will already with what phil had coded. You have to use the program to "convert" (even if all you do is "modify" spacing) and it will remove the BOMs today.

**Jeroen** · 2014-06-06, 15:36

(2014-06-06, 15:32)Bumpaneer Wrote: It actually will already with what phil had coded. You have to use the program to "convert" (even if all you do is "modify" spacing) and it will remove the BOMs today.

Ah ok, I didn't know that. I usually only use it for the checking. Cheers!

**Jeroen** · 2014-06-11, 19:06

I don't think this has been mentioned.

I have this one (and others like it) in my log:

Code:
DialogProgress.xml: Invalid Attribute for height: max

example usage:

PHP Code:
<height max="n">auto</height> 

Applies to textboxes and grouplists.

Bumpaneer · 2014-06-15, 18:58

(2014-06-04, 14:12)Jeroen Wrote: I'm getting

Quote:Undefined Vars:
window_Title

in my log. I only have a buch of vars named

window_Title.Video
window_Title.Music
window_Title.Pictures
...etc

So I guess it sees the period as end of the var?

It's also mentioning those vars (using the complete names) as unused.

edit: oh and my OCD is forcing me to mention there's a typo on the Texturepacker button (TexutePacker)

(2014-06-11, 19:06)Jeroen Wrote: I don't think this has been mentioned.

I have this one (and others like it) in my log:

Code:
DialogProgress.xml: Invalid Attribute for height: max

example usage:

PHP Code:
<height max="n">auto</height>

Applies to textboxes and grouplists.

Both of these issues should be fixed now: https://dl.dropboxusercontent.com/u/1681...v1.2.2.exe

Thanks for reporting them.

MassIV · 2014-06-16, 18:42

In 'check values' i'm getting something i think is not right:

Invalid Attribute for animation: reversable

**Jeroen** · (This post was last modified: 2014-06-16, 20:22 by Jeroen.)

(2014-06-15, 18:58)Bumpaneer Wrote: Both of these issues should be fixed now: https://dl.dropboxusercontent.com/u/1681...v1.2.2.exe

Thanks for reporting them.

Thanks!

Bumpaneer · 2014-06-16, 23:20

(2014-06-16, 18:42)MassIV Wrote: In 'check values' i'm getting something i think is not right:

Invalid Attribute for animation: reversable

Shouldn't it be reversible?

MassIV · 2014-06-17, 00:11

Oops.

Yes, sorry for wasting your time.

**Martijn** · (This post was last modified: 2014-06-17, 19:37 by Martijn.)

Would it be possible to print line numbers on found issues? Makes it easier to find the culprit i think (i'm being forced to use it now Wink

)

General question. Is this fully updated for Gotham atm? Need to handle skins during time ronie is unavailable.

Bumpaneer · (This post was last modified: 2014-06-18, 01:48 by Bumpaneer.)

(2014-06-17, 19:36)Martijn Wrote: Would it be possible to print line numbers on found issues? Makes it easier to find the culprit i think (i'm being forced to use it now )

(2013-01-28, 00:12)phil65 Wrote: identifying the line numbers is not that easy because i do not parse the xml "as a textfile". will see if i can come up with something.

Looks like phil65 was never able to find a workaround. The xml from the skins is read into the program and parsed like a tree, with each element being a branch. It has no concept of line numbers in its current state.

(2014-06-17, 19:36)Martijn Wrote: General question. Is this fully updated for Gotham atm? Need to handle skins during time ronie is unavailable.

No idea if it is fully updated. That was one of the reasons I offered to help update the code. As people point out problems I can definitely dig into the code to address them, but I'm not aware of all the intricacies of skinning like many of the people posting here are.

**Martijn** · (This post was last modified: 2014-06-19, 23:50 by Martijn.)

Some false reporting by the XML check it seems:

DialogMediaFilter.xml: Invalid Value for //control[@type='button']/*: invalidcolor
“invalidcolor” is a valid Gotham button value (Checked in Confluence/XBMC Code).

According to Nessus this should be valid as well:
“selected” is a valid button value
You can see in his skin code: http://github.com/Nessus85100/Bello

nessus · 2014-06-20, 02:09

Here are some code examples :

“invalidcolor” value
Bello example : https://github.com/Nessus85100/Bello/blo...ry.xml#L39
Confluence example : https://github.com/xbmc/xbmc/blob/master...y.xml#L213

“selected” value
Bello example : https://github.com/Nessus85100/Bello/blo...s.xml#L144
Confluence example : https://github.com/xbmc/xbmc/blob/master...s.xml#L249

Thanks a lot of your work on this tool.

Cheers
Nessus