All makes perfect sense. Thanks for looking at this for me.
The exception catching you added seems to do the trick nicely, I can confirm XSqueeze no longer bails if bits are missing from the window
Although the 'bits missing' log line fills the log fast fast fast, I've personally not had any issues with using window properties just added in parallel to the updateCoverArtFromURLs try block. It also still works with your default skin when they are in place. I *have* only tested on windows mind.
(2012-09-14, 04:01)bossanova808 Wrote: Honestly though - what sort of skin won't have those major controls?
I was coming from the future perspective of hacking up an existing skin MusicVisualisation.xml with the minimum of required changes, or trying to get skinners (or other amateurs like me) interested in including the add on by making it as easy as possible to swap internal music player labels for your external XSqueeze ones. It's no biggy, the exception catch works perfectly.
(2012-09-14, 04:01)bossanova808 Wrote: If you fancy it feel free to hack the Python yourself to see if you can get it working consistently the other way...happy to accept a pull request if so.
Cool, if I do make anything beyond a minor change I'll get all GIT'ed up and submit a pull
(2012-09-14, 04:01)bossanova808 Wrote: So, anyway:
* I have added play/pause logic - I like this too
* I have exposed BITRATE, FILEFORMAT, GENRE to the skin
* I have tried to make it not fail when the controls are absent
Thanks for the extra labels!
Play pause works well, although it's unexpectedly a little counter intuitive when using the Slimplayer infolines interface thingy as it's easy to get to a state where you have to double press play. Adding something like the below to the new condition seems to make it more intuitive by only sending the pause if on Now Playing.
Code:
and "Now Playing" in xbmcgui.Window(self.windowID).getProperty("XSQUEEZE_DISPLAYLINE1")
I really like XSqueeze (and the nifty music chooser), and with the shenanigans around the UE Radio I can only see it becoming more useful in the medium term.