Login at Kodi Home

realjobe · (This post was last modified: 2011-12-25, 15:39 by realjobe.)

Hi there. Using Eden Beta 1 Win32.

When User selects one jpg that has "User Comment" field inside EXif structure, "Picture Information" window shows only One char of the "Comment" field, when there are a lot of text.

Comment, just for info...

ronie Wrote:nope, currently only the resolution and date exif fields are available to the skin.

Could this be extended to have User Comment atleast?

Smile

EDIT.
I also found

Code:
14:32:49 T:1576   DEBUG: SECTION:LoadDLL(special://xbmcbin/system/libexif.dll)

14:32:49 T:2588   DEBUG:   msg: ExifParse: incorrect Exif header

Pics are plain regular pictures with Exif 2.x

sbuckmann · 2011-12-26, 20:22

This happens when the "User Comment" is stored as unicode (UTF-8). In ExifParse.cpp, the 8 byte header ("UNICODE\0") is removed, but the remaining string terminates after the first null character (most unicode characters consist of one null byte).

realjobe · 2011-12-26, 22:29

sbuckmann Wrote:This happens when the "User Comment" is stored as unicode (UTF-8). In ExifParse.cpp, the 8 byte header ("UNICODE\0") is removed, but the remaining string terminates after the first null character (most unicode characters consist of one null byte).

Thank you Very much for this!
User Comments are created with AcDsee 4.0 application, so their ought to be "legit".

Can someone do something about this issue?
Also how problematic is to expose User Comments to skin, like those 2 other Exif specs..

Code:
$INFO[ListItem.PictureDateTime

and

Code:
$INFO[ListItem.PictureResolution

(confluence/720p/ViewsPictures.xml)

realjobe · 2012-02-11, 14:06

Eden Beta3 still does not show EXIF UserComment but one the 1st char..
Sad

**ronie** · 2012-02-11, 14:14

realjobe Wrote:Eden Beta3 still does not show EXIF UserComment but one the 1st char..

please create a bugreport on trac, so the devs can look into it.

realjobe · 2012-02-11, 15:14

http://trac.xbmc.org/ticket/12628
Smile

~~Robotica~~ · 2012-02-12, 01:15

There is a link to a patch to retrieve EXIF-data overhere

~~Robotica~~ · (This post was last modified: 2012-06-29, 03:59 by Robotica.)

sorry

~~Robotica~~ · 2012-08-08, 16:50

(2011-12-26, 22:29)realjobe Wrote:
sbuckmann Wrote:This happens when the "User Comment" is stored as unicode (UTF-8). In ExifParse.cpp, the 8 byte header ("UNICODE\0") is removed, but the remaining string terminates after the first null character (most unicode characters consist of one null byte).

Thank you Very much for this!
User Comments are created with AcDsee 4.0 application, so their ought to be "legit".

Can someone do something about this issue?
Also how problematic is to expose User Comments to skin, like those 2 other Exif specs..

Code:
$INFO[ListItem.PictureDateTime

and

Code:
$INFO[ListItem.PictureResolution

(confluence/720p/ViewsPictures.xml)

Take a look at this: https://github.com/xbmc/xbmc/commit/d9ce...75b38d1afe

There are more fields exposed to the skin only your skin/view (confluence?) doesn't use them.

so you can probably do something like this in viewspictures.xml:

Code:
$INFO[ListItem.LISTITEM_PICTURE_COMMENT

For a better example: https://github.com/fetzerch/xbmc/commit/...5e67a9e114

**fetzerch** · 2012-09-13, 13:58

(2012-02-11, 15:14)realjobe Wrote: http://trac.xbmc.org/ticket/12628

https://github.com/xbmc/xbmc/pull/1417

realjobe · 2012-10-03, 10:32

Well. now that this bug has been taken care of, will there be possibility to Show EXIF:user Comment field on the bottom of the showing picture in any view mode?

Has the field been exposed to skin level to use?

~~Robotica~~ · (This post was last modified: 2012-10-03, 11:15 by Robotica.)

yes it is... See the status of the remaining: http://forum.xbmc.org/showthread.php?tid...pid1204200

realjobe · (This post was last modified: 2012-10-03, 11:35 by realjobe.)

(2012-10-03, 11:14)Robotica Wrote: yes it is... See the status of the remaining: http://forum.xbmc.org/showthread.php?tid...pid1204200

EXCELENT!!! I have been waiting for this over 1,5 years now! FINALLY!
I write all my picture realted info inside EXIF user comment field as it is intended to be used.
GeoLocation is also included in the EXIF..
any possibility to use GoogleMaps to pinpoint the location? Smile

~~Robotica~~ · 2012-10-03, 11:47

btw, see the commit for all available fields. https://github.com/xbmc/xbmc/pull/827

yes, geo coordinates are also stored and avaiable to skinners. The picture addon xcyl is providing the option to show a google map.

realjobe · 2012-10-03, 12:39

(2012-10-03, 11:47)Robotica Wrote: yes, geo coordinates are also stored and avaiable to skinners. The picture addon xcyl is providing the option to show a google map.

THIS IS the best news for a loo-ong time. Everything is coming together here! MARVELLOUS! Can't wait for Frodo to compleate!!!