Posts: 227
Joined: Dec 2010
Reputation:
8
Pecinko, the color of the context menu, that silver-grayish, it doesn't fit good with colors of the skin and all other similar dialog windows are skinned dark. Is it suppose to be this way, or just some texture gone missing?
Posts: 3,956
Joined: Dec 2008
Reputation:
62
OK
If I didn't f*cked up with git commits, Music Videos support should be in GitHub version.
Posts: 3,956
Joined: Dec 2008
Reputation:
62
and PVR should be in place, as well.
Posts: 1,155
Joined: Aug 2008
Poster art for music videos looks great, cannot comment on "music" music videos. Thanks.
Posts: 1,155
Joined: Aug 2008
I hate git and github so much, is it really too much to ask that i could send a pull request only for 1 commit, instead of sending every commit that does not exist upstream.
Posts: 1,251
Joined: Dec 2008
Reputation:
15
Great work on the skin! Some feedback I hope you will take under consideration:
1) Poster aspect ratio doesn't really make sense for music videos, since they use square album covers. Poster aspect ratio is only really suitable for people who put things like DVD concerts into the music video section, which isn't really its primary function.
2) Pressing 'i' during video playback ought to display the progress bar, like when you bring up the OSD or press pause. "So why not press 'm' or pause?", I hear you ask. Pause obviously interrupts playback, which isn't what you want if you just want to check remaining time, and while bringing up the OSD makes sense when you use a keyboard or mouse to control XBMC, it makes less sense when using a remote control.
Posts: 1,155
Joined: Aug 2008
(2013-04-29, 23:11)pecinko Wrote: Sure, go ahead.
It was not a question, just a comment on complexity of GIT.
If i'm not mistaken i have to create a branch, use cherrypick to select the commit, and then send a pull request to this branch.