[Martijn]

oh well maybe it actually is can't remember.

here's the code line so it indeed seems to do that
https://github.com/XBMC-Addons/script.ar...up.py#L187

maybe it's case sensitive.
you could edit that line and replace it with

PHP Code:

elif (('bluray' or 'blu-ray' or 'brrip' or 'bdrip') in filename.lower()): 


[BiTeMeNoW]

Thanks.
just to let you know on the wiki stay something about case insensitive (explicitly marked)

Anyway, I changed the media_setup.py, deleted the .pyo (it will compile again), deleted the cache db, but still getting dvd as disctype.

I see in the file the call for the function:

PHP Code:

disctype = media_disctype(item.get('file','').encode('utf-8').lower(), item['streamdetails']['video']) 


There is already a .lower(). So there is some where another problem maybe.
How can I put a debug line? With log() it doesn't work. Ok it did work, but not there as I would like ...

OK, I found the bug.
I'm not the python specialist (actually today is my first day), but some minor programming skills and the way you search a string in a string (with multiple needle) does not work.
I just tried with a single string in the condition and it did work:

PHP Code:

elif ('bdrip' in filename): 


Now I have to look for a multiple needle search in python and we can get this fixed and updated.

And with this one it works with multiple needles:

PHP Code:

elif any(x in filename for x in ['bluray', 'blu-ray', 'brrip', 'bdrip']): 


Don't know if it is the best way. Now have to look about the other conditions.

How to get this into the github?

---------------------------------------------

PHP Code:

if (('dvd') in filename and not any(x in filename for x in ['hddvd', 'hd-dvd']) or (filename.endswith('.vob') or filename.endswith('.ifo'))):
        disctype = 'dvd'
    elif ('3d' in filename and not 'ac3d' in filename):
        disctype = '3d'
    elif any(x in filename for x in ['bluray', 'blu-ray', 'brrip', 'bdrip']): 


With these changes AD will find all discs for my collection (where applicable). There are some 'hdrip' or 'webrip' but they are normally dvd resolution, so the resolution check will do the rest. As they are not really from a disc source it should not download one.
Also there are dubbed rips tagged as 'ac3d' and AD will recognize them as 3D, so changed the condition.

Where should I ask for a new feature?

[Eko P]

Is the problem fixed? Because still getting 0 downloads.. api is up so don't know why its not downloading anything still..

[BiTeMeNoW]

@Eko P, as Martijn said the Issue is not on the addon side.
Keep in mind that the addon will make use of caching tecnologies, so you have to wait until the caches expires or force it to expire.
Read his post HERE.

[kanepa]

hi,
first of all congratulations for the work you do to make our fabulous media player.
AD for a few days I charge the logo.png in the folder where they are stored movies and I get the mids in the Danish or German, but I set the scraper in the Italian language.
is always a problem of API Fanart.tv or you can edit the script in xml or python to solve this problem?
xbmc 12.2 Frodo running on a snowleopard macmini2010 are updated.

P.S. Where can I find commoncache. in mac?

thanks again

[BiTeMeNoW]

Hi Martijn, I made a pull request on github (if I done all right...) for the discart changes

[kanepa]

i have updated to version .23 but continues to download the logos wrong or you just do not download them.
and always in German.
how can you solve?

thanks a lot

[BiTeMeNoW]

@kanepa, without a log nobody could and will help you ...
Look post #1

[capfuturo]

Hi Martijn, I made a pull request on github (if I done all right...) for the discart changes

Hi BiTeMeNow, could you please link it here? Thanks!

[wgstarks]

i have updated to version .23 but continues to download the logos wrong or you just do not download them.
and always in German.
how can you solve?

thanks a lot

Also, what are your current language settings for this source?

[BiTeMeNoW]

Hi BiTeMeNow, could you please link it here? Thanks!

@capfuturo, scroll up on the previous page, the last piece of code (media_setup.py) on my post.
The github link is also on the previous page at first.
It is already merged into the .23 update.

[kanepa]

@kanepa, without a log nobody could and will help you ...
Look post #1

this is the log. I do not know if the procedure is right.
thanks
http://pastebin.com/Zj2Ddj2M

[AeronNL]

Is it possible to have artwork downloader download everything automatically when my library gets updated?
My library updates automatically when new content is downloaded using Watchdog.
It downloads the cover and synopsis etc., but i have to open the info screen and choose the "auto" option under "choose image" to have all the extra artwork, like fanart, logo, clear art etc. downloaded.
It would be great if i could skip this step and have Artwork Downloader download everything when the library gets updated.

[kanepa]

@kanepa, without a log nobody could and will help you ...
Look post #1

ithis is the log. I do not know if the procedure is right.
thanks
http://pastebin.com/Zj2Ddj2M

I've solve erase commoncache.db in:/Users/MacPlex/.xbmc/temp
thanks

[BiTeMeNoW]

@kanepa, you forgot to set AD in debug mode too, so I don't see anything there, but glad to see that you could solve the issue deleting the cache db.
In the wiki you can see the locations of the dbs for all operating systems.

@AeronNL, why so complicated? If you use Aeon Nox skin, just go into movies in library mode and go to quick navigation and choose Artwork Downloader so it will just scan for all movies (not Music and tv shows) instead of getting it one by one, or just start the app in the app center ...
Oh, and don't use the option for local files if not needed, cause it is really slow.
As I understand how it all works (and believe me, I'm a noob so I can be very wrong on this) to start AD after a lib update I would change the scraper script to fire AD at the end, or if you use a service to schedule lib update set there to also start AD in custom mode ... but be aware that if xbmc doesn't see the folders on scan (maybe on network and the connection is not yet estabilished or just nas offline) all contents will be wiped off the the db !!