2014-01-16, 15:59
Hey Lunatixz, first off fantastic work. Secondly I've made two very minor improvements to help with the wife acceptance factor and thought maybe you could incorporate them into main branch if you like them. The first is functioning page up/down buttons in the EPG. I've added the following code to the onAction function (About line 492 in EPGWindow.py)
and the following functions (Around line 615 again in EPGWindow.py)
This works well for me in the default skin and moves the listing by one page. You can obviously tweak it to your needs.
The second change is to stop fast forward/rewind while watching live tv which causes xbmc to explode (which means I have to get off my ass and restart it
)
In Overlay.py around line 1164 I changed the ACTION_MOVE_LEFT and ACTION_MOVE_RIGHT actions to:
Hope these help, keep up the good work
Code:
elif action == ACTION_MOVE_DOWN:
self.GoDown()
if self.showingInfo:
self.infoOffsetV -= 1
elif action == ACTION_PAGEDOWN:
self.GoPgDown()
elif action == ACTION_MOVE_UP:
self.GoUp()
if self.showingInfo:
self.infoOffsetV += 1
elif action == ACTION_PAGEUP:
self.GoPgUp()Code:
def GoPgDown(self):
self.log('GoPgDown')
newchannel = self.centerChannel
for x in range(0, 6):
newchannel = self.MyOverlayWindow.fixChannel(newchannel + 1)
self.setChannelButtons(self.shownTime, self.MyOverlayWindow.fixChannel(newchannel))
self.setProperButton(0)
self.log('GoPgDown return')
def GoPgUp(self):
self.log('GoPgUp')
newchannel = self.centerChannel
for x in range(0, 6):
newchannel = self.MyOverlayWindow.fixChannel(newchannel - 1, False)
self.setChannelButtons(self.shownTime, self.MyOverlayWindow.fixChannel(newchannel))
self.setProperButton(0)
self.log('GoPgUp return')The second change is to stop fast forward/rewind while watching live tv which causes xbmc to explode (which means I have to get off my ass and restart it
)In Overlay.py around line 1164 I changed the ACTION_MOVE_LEFT and ACTION_MOVE_RIGHT actions to:
Code:
elif action == ACTION_MOVE_LEFT:
if self.showingInfo:
self.infoOffset -= 1
self.showInfo(10.0)
else:
chtype = int(ADDON_SETTINGS.getSetting('Channel_' + str(self.currentChannel) + '_type'))
if chtype != 9:
xbmc.executebuiltin("PlayerControl(SmallSkipBackward)")
elif action == ACTION_MOVE_RIGHT:
if self.showingInfo:
self.infoOffset += 1
self.showInfo(10.0)
else:
chtype = int(ADDON_SETTINGS.getSetting('Channel_' + str(self.currentChannel) + '_type'))
if chtype != 9:
xbmc.executebuiltin("PlayerControl(SmallSkipForward)")Hope these help, keep up the good work
