[jdf76]

@DjSlash,

Gathering from what i read this morning I believe they want one person to manage it, not a group of people. I think they want one person to be responsible to managing the thing and not a group of people, which i can understand why it could be bad and good at the same time. I agree with updating the wiki, that should be left up to the maintainer of the plugin as well. This way the sole job of this individual is to make sure this plugin works the way it should and troubleshoot the thing when it fails.

I've pretty much put my hat in the ring so now it's pretty much down to the group of people who've been involved with keeping the plugin going to agree or disagree with my proposal. I'll go along with the majority and work with whatever they want to do. I've pretty much given my response on this so i'm going to let everyone talk about it and when I feel i need to comment or if someone asks me a question i'll answer then.

Thanks Everyone!
Jeff

I have a few suggestions regarding this.

Create a organisation on github and add permissions to the folks who add contributions to the plugin.

Also, make this (or a new) thread only for support and let code issues be handled on github.

And let's update the Kodi wiki about this plugin, so it contains (the correct) instructions about setting it up.

@Everyone on the Forum who has participated.

I'd like to set up a master repo for official submission to the official repo. At first i wouldn't be able to participate more than what i have been doing which is supporting and asking questions and also popping an idea. Eventually when my python skills become good enough i'd like to even offer to maintain the code as well, but for now i would rely on you guys for your support.

@Kolifanes would you be ok with me taking over the repo or would you prefer to run the repo on your own. I think in order for us to get this back into the kodi repo it needs to be a permanent place.

[Martijn]

fyi a group is fine as long as you agree with each other

[jdf76]

I stand corrected and i'm cool with that too. I would just like to get the plugin into the repo

fyi a group is fine as long as you agree with each other

[Martijn]

A group is better as then it doesn't fall one guy's /girl's shoulder.
As long as there's consensus between involved devs on what to do/fix all should be fine. We simply don't want updates that counter each other out each week cause they're send by different people.

[sunnyhero]

A group is better as then it doesn't fall one guy's /girl's shoulder.
As long as there's consensus between involved devs on what to do/fix all should be fine. We simply don't want updates that counter each other out each week cause they're send by different people.

Very good advise....

[misty01]

I have no problem with that. Is bromix still around because i know his repo is gone. I'll bring up the ideas to the forum and see what they think? I understand what you mean, but by you speaking with me, this opens a dialog to get this guy back in the game for being official again.

@Everyone on the Forum who has participated.

I'd like to set up a master repo for official submission to the official repo. At first i wouldn't be able to participate more than what i have been doing which is supporting and asking questions and also popping an idea. Eventually when my python skills become good enough i'd like to even offer to maintain the code as well, but for now i would rely on you guys for your support.

@Kolifanes would you be ok with me taking over the repo or would you prefer to run the repo on your own. I think in order for us to get this back into the kodi repo it needs to be a permanent place.

@misty01, @Uukru, and any of the other guys who have helped with getting the plugin back to a good running, would you be willing to let me manage the repo but still require your help on getting some technical help with python. I can do my best to get around till i feel comfortable, but i would rely on you guys to help me with the python stuff.

@bromix, if you're still around i would love to get your blessing.

What do you guys think? I want to do whats best for the plugin.

Thanks
Jeff

Hey Jeff,

If you're willing to be the maintainer, then great. I can try to help with some dev stuff, but to be honest I have not looked too deeply at Bromix's code, only enough to patch a thing or two. I also have zero knowledge of Google's YouTube V3 API except for what has been recently discussed in this thread.

When Bromix was the 'keeper of the flame', he had a huge advantage in that he created the add-on from the ground up, so he had / has a very deep understanding of his code, Kodi API and Google YouTube API. He also reviewed any pull request submitted and determined if it was good or would cause something to break.

I guess you can clone / fork Kolifane's repo, then anybody that wants to help in maintaining the code can fork off your repo and submit pull requests for fixes or new features. Someone with a very good understanding of the add-on code would be needed to review and approve code changes. It would be extremely bad to blindly accept pull requests and unexpectedly break things.

Hope that helps.

[*Spider*]

New release https://github.com/Kolifanes/plugin.vide...g/5.1.20.5
With the fix by clarjon1

Kolifanes applied your patch and released 5.1.20.5, but this broke live streams again because itag 92 is now missing.

Restored 5.1.20.4

As previously mentioned in the thread, the best way to keep track of all changes is via git for version control and suggested changes made via pull requests. That way code changes can be reviewed before a new release is made. Let's all work together to have a working youtube add-on.

Someone with a very good understanding of the add-on code would be needed to review and approve code changes. It would be extremely bad to blindly accept pull requests and unexpectedly break things.

Amen to that. You fixed Kolifanes' blind trust to an unverified suggestion and you alone saved the day.
Strangely enough, Kolifanes hasn't made an appearance here since that error in judgement.

[DjDiabolik]

When you add a youtube channel (from the add-on) as a favorite in Kodi, it does not update/refresh the video list. It will take some time to test since you need to add a channel, then wait for it to upload new videos, then access it from your favorite list again. This is not an issue (within the add-on) if you subscribe to the channel. I like to add channels I don't watch to often too favorites, so those videos doesn't "fill" up my subscription list.
If the plugin url is saved as plugin://plugin.video.youtube/user/xxxx, instead of plugin://plugin.video.youtube/channel/yyyy, things works as expected.
I'm guessing this is an issue with the value passed from the add-on to Kodi when the favorite is created. This worked as it should in the "old Bromix version".
CUT CUT

Apparently OSMC when you add a channel to favourites of Kodi from addons use the channelid instead the username........... i speak about this workaround how can you modify manually the favourites.xml and change the channelid whit username but this is not a good solution because in this case when you lauch the addons from favourites of kodi you obtain a result like a search result and not all video posted inside the channel, for obtain this you need to select a video... use the context menu and use the function "Go To (name of channel)".

Otherwise on youtube for some channel you can't obtain the username but some channel using only a channelid......... for this you need to use only the search function for obtain all video upload in this channel.........

Sorry again for my english...........

*EDIT*
I thinks the best solution it's make the add-on working more like the same recent on most recent Smart TV..... i have an LG SmartTV:
1) Lauch the youtube APP
2) Use the search engine
3) On result i can see all in one....... channel most relevant to my "search key", most relevant video this channel and if it's present all live stream from this channel etc etc but all it's be listening in all list

Actualy on this kodi add-on instead:
1) Lauch youtube add-on
2) Use the search engline
3) On result you need to select "Live" "Channel" and below you can obtain some video not exactly related to your "search key" used..........


If this youtube add-on can be adapter to working like recent smart tv app i thinks it's better because we can use only the search history feature and we can reach all channel directly after first search result......... also when you use search function by a browser on pc working in this mode.........

[xbmc_now]

I use version 5.1.16
When this live stream is seen, an error occurs.

https://www.youtube.com/watch?v=KYoVBUjbiUI

That number 91 of yt_format doesn't probably exist in a file as video_info.py seems to be the cause, so I'd like to request correction.

File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\kodion\runner.py", line 32, in run
__RUNNER__.run(provider, context)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\kodion\impl\xbmc\xbmc_runner.py", line 23, in run
results = provider.navigate(context)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\kodion\abstract_provider.py", line 123, in navigate
result = method(context, re_match)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\kodion\register_provider_path.py", line 12, in wrapper
return func(*args, **kwargs)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\youtube\provider.py", line 363, in on_play
return yt_play.play_video(self, context, re_match)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\youtube\helper\yt_play.py", line 17, in play_video
video_streams = client.get_video_streams(context, video_id)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\youtube\client\youtube.py", line 80, in get_video_streams
video_streams = video_info.load_stream_infos(video_id)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\youtube\helper\video_info.py", line 324, in load_stream_infos
return self._method_get_video_info(video_id)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\youtube\helper\video_info.py", line 549, in _method_get_video_info
return self._load_manifest(url, video_id)
File "C:\Users\hoge\AppData\Roaming\Kodi\addons\plugin.video.youtube\resources\lib\youtube\helper\video_info.py", line 495, in _load_manifest
raise Exception('unknown yt_format for itag "%s"' % itag)
Exception: unknown yt_format for itag "91"

[misty01]

@xbmc_now, old news, that was fixed a while ago...

https://github.com/Kolifanes/plugin.vide...1.20.4.zip

[xbmc_now]

@xbmc_now, old news, that was fixed a while ago...

https://github.com/Kolifanes/plugin.vide...1.20.4.zip

thx

[DjSlash]

Ok, let's set up a plan here. Hopefully we, as a community, can solve this once and for all.

Let's contact Kolifanes with the question of he agrees with our plan and ask him to respond within reasonable time (like, until the end of the week). This gives him the oppertunity to react. For all we know he's been very busy IRL, so we should at least give him a chance.

If he responds, then we should proceed from there. His repo should be transferred to an organisation and proper permissions has to be set up. If he doesn't, then we should just fork his repo and continue from there.

Next we should create some guidelines about development, releases and contributions.

@Martijn: I wonder if it would be possible to transfer the plugin-repo to Team Kodi and set up a team for it. This way the plugin gets somewhat protection and not easily lost.

[jdf76]

Ok, let's set up a plan here. Hopefully we, as a community, can solve this once and for all.

Let's contact Kolifanes with the question of he agrees with our plan and ask him to respond within reasonable time (like, until the end of the week). This gives him the oppertunity to react. For all we know he's been very busy IRL, so we should at least give him a chance.

If he responds, then we should proceed from there. His repo should be transferred to an organisation and proper permissions has to be set up. If he doesn't, then we should just fork his repo and continue from there.

Next we should create some guidelines about development, releases and contributions.

@Martijn: I wonder if it would be possible to transfer the plugin-repo to Team Kodi and set up a team for it. This way the plugin gets somewhat protection and not easily lost.

I'm all for that, a group is a good idea for exactly what Martijn said. Let me know what I can do to help.

Jeff

[learningit]

So looking beyond the few small changes to the current version, are folks signing up for the dev and support for the rather large and technical changes that will come in Kodi V17 with this new repo? This comment:

@Martijn: I wonder if it would be possible to transfer the plugin-repo to Team Kodi and set up a team for it. This way the plugin gets somewhat protection and not easily lost.

tends to make me think that there's not a full understanding of what's going on here. I think anyone who contributes to plugin-repo would understand my concern. The YT 3.0 API is a flawed API and IMHO will continue to have problems, at least with the approaches to fixes that I've seen to date. Kodi V17 is going to open a world of potential opportunity for the YT add-on as well as several other services like Amazon Prime, Netflix and Hulu. Folks need to understand that they need to be committed to that long term, as well as these short term issues.

I think that the group idea is great, but people who get involved need understand that the current issues are minor compared to the real work that needs to be done in the not too distant future.

[Kolifanes]

Mine work is only to fix the API(s) and i have do that. I don't have the time and the skills for become the new maintainer of YouTube addon. So anyone can do what they want with the source from GitHub, no problem for me.