[DarrenHill]

I'll give it a try this evening and let you know.

OK we have partial success. BBC 1, CBBC, CBeebies and BBC news channels have logo icons, but BBC2 and BBC two 4 extra (tried as a test) do not.

[primaeval]

I'll give it a try this evening and let you know.

OK we have partial success. BBC 1, CBBC, CBeebies and BBC news channels have logo icons, but BBC2 and BBC two 4 extra (tried as a test) do not.

Can you see all the logos in addons\plugin.video.iplayerwww\media ?
There should be 80 files in there now.

If there is, see whether they show up in the addon in Video\iplayerwww\Watch Live.

Have you removed any wrong addon folders? eg addons\plugin.video.iplayerwww-2.3.4p3

I doubt this applies here but sometimes the Kodi image database and Thumbnail directory need deleting to clear things up.
It is a bit harsh but necessary sometimes.

[DarrenHill]

Yes 80 files in the media folder, which show under watch live in the iPlayer add-on.

Hadn't removed the other folder, but have now and doesn't make a difference.

Don't really want to rebuild the databases as it'll take to long. T the issue is too small and cosmetic to be worthwhile.

I also see now that ITV doesn't have an icon either from the TV catch-up add-on (but channel 4 and 5 both do) so it may be something more fundamental here.

[primaeval]

Yes 80 files in the media folder, which show under watch live in the iPlayer add-on.

Hadn't removed the other folder, but have now and doesn't make a difference.

Don't really want to rebuild the databases as it'll take to long. T the issue is too small and cosmetic to be worthwhile.

I also see now that ITV doesn't have an icon either from the TV catch-up add-on (but channel 4 and 5 both do) so it may be something more fundamental here.

The problem is most probably in the guide then.

Try renaming or deleting the userdata\addon_data\script.tvguide.fullscreen folder and see if it will work now.

There is a lot of convoluted logic about when to overwrite logos: some mine, some inherited.

[donbrew]

That did it!!!!!

Thank you

Now to continue with my learning curve.

Great. Thanks.

I'll change that it the addon and get a new version out.

This is line 58 in 0.0.54
fileName.startswith("https://") or fileName.startswith("ftps://") :


I can add the xxx part, I think.

0.0.54
- smb fix

Please check it still works for you.

smb seems to be broken again in 0.0.54. And now I can't cancel "loading of data". Right now the Pi is busy running WebGrab.

[primaeval]

Great. Thanks.

I'll change that it the addon and get a new version out.

0.0.54
- smb fix

Please check it still works for you.

smb seems to be broken again in 0.0.54. And now I can't cancel "loading of data". Right now the Pi is busy running WebGrab.

That is quite a lot of work for a poor little pi.
One of the reasons I started on the Webgrab addon was to make tiny xmltv files for it.
Even a few channels can take minutes to load.

If it won't work after a reboot with a small xmltv file, after every background service has calmed down, we'll have to start debugging the smb code again.

I only removed the smb check from 0.0.54, so it is strange that it worked with your change and not 0.0.54, which is effectively the same.

There must be something else going on.

[DarrenHill]

The problem is most probably in the guide then.

Try renaming or deleting the userdata\addon_data\script.tvguide.fullscreen folder and see if it will work now.

There is a lot of convoluted logic about when to overwrite logos: some mine, some inherited.

I think it is. Tried again with a fresh add-on data folder and a new xml file from webgrab. Now all BBC icons show up from iPlayer WWW, but none from TV catch-up do. So I think the issue is probably a naming mismatch between the two or something like that.

Going back to the first XML file gives icons for all BBC and all TV catch-up except ITV, so which for me confirms is a naming issue in the xml file in the guide.

Would it be possible to add being able to manually set a logo per channel in the guide setup page for each channel?

[primaeval]

The problem is most probably in the guide then.

Try renaming or deleting the userdata\addon_data\script.tvguide.fullscreen folder and see if it will work now.

There is a lot of convoluted logic about when to overwrite logos: some mine, some inherited.

I think it is. Tried again with a fresh add-on data folder and a new xml file from webgrab. Now all BBC icons show up from iPlayer WWW, but none from TV catch-up do. So I think the issue is probably a naming mismatch between the two or something like that.

Going back to the first XML file gives icons for all BBC and all TV catch-up except ITV, so which for me confirms is a naming issue in the xml file in the guide.

Would it be possible to add being able to manually set a logo per channel in the guide setup page for each channel?

I think that is going to give me a lot of headaches but I'll have a look.

The most solid way to handle logos is to build your own Logo Folder with logos from the Lab\Export Logos command and grab country packs from the TVLogo Downloader addon.
The TVLogo Downloader program needs to shrink the icons by half before the guide will pull them in. I don't know why.

Some of the other TV Guides have good Logo urls that you can use or mirror locally.

There is already some fuzzy matching for logos, so you don't have to do too much renaming. About line 1142 in source.py if you can read python.

[DarrenHill]

I'll give it a go - am currently missing that logo download program I think.

Fundamentally everything is working though, is just cosmetic config now.

[donbrew]

0.0.54
- smb fix

Please check it still works for you.

smb seems to be broken again in 0.0.54. And now I can't cancel "loading of data". Right now the Pi is busy running WebGrab.

That is quite a lot of work for a poor little pi.
One of the reasons I started on the Webgrab addon was to make tiny xmltv files for it.
Even a few channels can take minutes to load.

If it won't work after a reboot with a small xmltv file, after every background service has calmed down, we'll have to start debugging the smb code again.

I only removed the smb check from 0.0.54, so it is strange that it worked with your change and not 0.0.54, which is effectively the same.

There must be something else going on.

It was just too busy. after reboot it works again.

[primaeval]

smb seems to be broken again in 0.0.54. And now I can't cancel "loading of data". Right now the Pi is busy running WebGrab.

That is quite a lot of work for a poor little pi.
One of the reasons I started on the Webgrab addon was to make tiny xmltv files for it.
Even a few channels can take minutes to load.

If it won't work after a reboot with a small xmltv file, after every background service has calmed down, we'll have to start debugging the smb code again.

I only removed the smb check from 0.0.54, so it is strange that it worked with your change and not 0.0.54, which is effectively the same.

There must be something else going on.

It was just too busy. after reboot it works again.

Great. I am starting to get a bit overloaded with all the addons I am working on at the moment.

[iainmacleod]

Yeah you are. What language would I need to learn to branch or assist?

Also, I notice that the TV Guide Fullscreen doesn't load the XML file with the appropriate offsets - but the standard TV Guide does. They are using the same files, I have the source.db of both add-ons and reloaded to confirm.

In addition, what do channels.ini and addons.ini do? I read this thread but didn't see any information.

Thanks

Sent from my ONE A2005

[primaeval]

Yeah you are. What language would I need to learn to branch or assist?

Also, I notice that the TV Guide Fullscreen doesn't load the XML file with the appropriate offsets - but the standard TV Guide does. They are using the same files, I have the source.db of both add-ons and reloaded to confirm.

In addition, what do channels.ini and addons.ini do? I read this thread but didn't see any information.

Thanks

Sent from my ONE A2005

The channels.ini and addons.ini are if you want to import them from somewhere else.
They are optional.
If you use them, then any changes you make to the categories or addon streams will be overwritten on the next xmltv update.
The use case is having a central server and pushing the same changes to all your devices.


The addon is in python with sql for the database and xml for the xmltv.
The quickest way to learn a new programming language that I know of is here:
https://learnxinyminutes.com/

TV Guide actually parses the date in the wrong way and throws away the offset value.
I expect your webgrab setup has compensated for TV Guide and added another offset.

Compare these two:

TV Guide source.py

Code:

def parseXMLTVDate(self, dateString):
        if dateString is not None:
            if dateString.find(' ') != -1:
                # remove timezone information
                dateString = dateString[:dateString.find(' ')]
            t = time.strptime(dateString, '%Y%m%d%H%M%S')
            return datetime.datetime(t.tm_year, t.tm_mon, t.tm_mday, t.tm_hour, t.tm_min, t.tm_sec)
        else:
            return None

TV Guide Fullscreen source.py

Code:

def parseXMLTVDate(self, origDateString):
        if origDateString.find(' ') != -1:
            # get timezone information
            dateParts = origDateString.split()
            if len(dateParts) == 2:
                dateString = dateParts[0]
                offset = dateParts[1]
                if len(offset) == 5:
                    offSign = offset[0]
                    offHrs = int(offset[1:3])
                    offMins = int(offset[-2:])
                    td = datetime.timedelta(minutes=offMins, hours=offHrs)
                else:
                    td = datetime.timedelta(seconds=0)
            elif len(dateParts) == 1:
                dateString = dateParts[0]
                td = datetime.timedelta(seconds=0)
            else:
                return None

            # normalize the given time to UTC by applying the timedelta provided in the timestamp
            try:
                t_tmp = datetime.datetime.strptime(dateString, '%Y%m%d%H%M%S')
            except TypeError:
                xbmc.log('[script.tvguide.fullscreen] strptime error with this date: %s' % dateString, xbmc.LOGDEBUG)
                t_tmp = datetime.datetime.fromtimestamp(time.mktime(time.strptime(dateString, '%Y%m%d%H%M%S')))
            if offSign == '+':
                t = t_tmp - td
            elif offSign == '-':
                t = t_tmp + td
            else:
                t = t_tmp

            # get the local timezone offset in seconds
            is_dst = time.daylight and time.localtime().tm_isdst > 0
            utc_offset = - (time.altzone if is_dst else time.timezone)
            td_local = datetime.timedelta(seconds=utc_offset)

            t = t + td_local

            return t

        else:
            return None

[primaeval]

I'll give it a go - am currently missing that logo download program I think.

Fundamentally everything is working though, is just cosmetic config now.

I think there are some problems with logos.

I keep losing mine when I restart.

I'll have a look at the logic later.

[iainmacleod]

TV Guide works for me because I use the chans2correct.xml of WebGrab+plus to create the offset.

Sent from my ONE A2005