2016-10-11, 07:57
I guess I should have checked that.
(2016-10-11, 01:39)mojo-hakase Wrote: The only problem is i don't know how the user interface can be implemented.@mojo-hakase, have you read this other discussion about timeshift buffer indicator which faces a somewhat similar dilema as yours. Perhaps discuss with FernetMenta if the code he wrote for timeshift buffer indicator could be reused for your purpose as well?:
(2016-10-12, 11:05)AbRASiON Wrote: if it's part of the 'standard' protocol for MKV then I do think it should be included in Kodi, regardless if it's mainly used just for Anime, standards are standards.
(2016-10-11, 16:07)garretn Wrote: The one thing I would like to see is the ability to put some of the segments into the Extras directory to help keep a clean structure, as it's pretty common these external segments are just openings/endings and rarely anything else. I mention the Extras directory specifically as it'd be difficult to store segment IDs, but scanning a specific pre-existing place seems reasonable.
(2016-10-11, 01:39)mojo-hakase Wrote: Hello everyone.
As i use Kodi to watch Animes and also have some files that use ordered chapters, i'm looking forward to this feature being supported by Kodi.
So i've worked the last days implementing this feature and, so far, got a working version:
https://github.com/mojo-hakase/xbmc/tree...edChapters
(2016-11-11, 16:04)Shine Wrote:(2016-10-11, 01:39)mojo-hakase Wrote: Hello everyone.
As i use Kodi to watch Animes and also have some files that use ordered chapters, i'm looking forward to this feature being supported by Kodi.
So i've worked the last days implementing this feature and, so far, got a working version:
https://github.com/mojo-hakase/xbmc/tree...edChapters
This is very cool, thanks a million times for your work!
I tested your squashed version (Nov. 4 commit), works quite well!
The only issue I could see so far is that after switching from one segment to the next (eg. OP -> Ep, or Ep -> ED), subtitles are lost for ~30 seconds (or until you turn subs off and then on again). This doesn't happen with all files, but let's say with about half of these I tested (all of them 5 or more years old - don't have any newer test subjects).
Other than that - pretty fllawless!
(2017-06-27, 20:15)garretn Wrote: I've got a rebased build of @mojo-hakase's patches on 17.3 that seem to still work with minor adjustments. Honestly the use of segment linking has died down significantly recently, which is nice since it's a ridiculous feature to begin with.
(2017-06-27, 20:15)garretn Wrote: I've got a rebased build of @mojo-hakase's patches on 17.3 that seem to still work with minor adjustments. Honestly the use of segment linking has died down significantly recently, which is nice since it's a ridiculous feature to begin with.
(2017-06-30, 15:42)garretn Wrote: Sure, it's a very minor change:
https://github.com/gnoling/xbmc/commit/9...f02099ec18
Here is the original PR btw, 10678 (PR). I hope they don't stick too hard to "do it in ffmpeg", as ffmpeg has said repeatedly over the years that they won't do it.