Posts: 883
Joined: Oct 2009
Reputation:
37
margro
Posting Freak
Posts: 883
Well my question is exactly this: what is "whatever needs to be done". This is not clear to me.
Posts: 6,810
Joined: Jul 2010
Reputation:
198
Inputsteam API has no method OpenLiveStream. As mentioned, this part of the PVR api will die. Inputstream is NOT a singelton. Everytime VP opens a fileitem a new instance of inputstream will be created. There can even be multiple instances of the same type active playing at the same time.
Posts: 1,378
Joined: Oct 2004
Reputation:
37
2017-07-24, 00:54
(This post was last modified: 2017-07-24, 00:55 by scarecrow420.)
Im also a bit lost as to what this actually means for the pvr.wmc addon. I've been getting further and further away from Kodi development in recent months/years but I would be happy to make changes to keep pvr.wmc/ServerWMC functioning with Kodi, but Im not an expert in this and simply don't know what we need to do to ensure addons still continue to function once this change goes through? Any pointers would be appreciated
Posts: 118
Joined: Apr 2017
Reputation:
0
I see in the recent commit that strStreamURL is gone in master, yet GetLiveStreamURL remains.
Is the plan to remove the latter also? If not, how would you get it to be called?
Posts: 6,252
Joined: Jun 2009
Reputation:
115
da-anda
Team-Kodi Member
Posts: 6,252
guys, it looks like you're kinda lost atm. I'm not at all into anything PVR or binary add-ons, but Fernet wrote that your add-ons now need to support ReadRecordedStream and ReadLiveStream API functions. From a quick look, these require buffers to be filled and passed around. Now, it doesn't make much sense that each and every PVR add-on is writing it's own buffer logic, so I suggest to maybe write some helper lib (or abstract PVR add-on / foundation) that all add-on can be based on. Alternatively, your add-ons could use current PVR API to provide EPG, recordigns etc and utilize the inputstream API for playback. That's at last what I gathered. Now, the inputstream API is not yet fixed and could be modified to suite your needs, but you have to check out the API and give feedback. Thanks.
Posts: 6,252
Joined: Jun 2009
Reputation:
115
da-anda
Team-Kodi Member
Posts: 6,252
Btw, please don't hesitate to speak freely and keep asking. I try to get and provide answers for your questions.
Posts: 6,252
Joined: Jun 2009
Reputation:
115
da-anda
Team-Kodi Member
Posts: 6,252
2017-07-28, 11:47
(This post was last modified: 2017-07-28, 11:49 by da-anda.)
guys, it looks like we got FernetMenta wrong - or at least I did. As part of the refactoring of the PVR feature to decouple it from videoplayer using inputstream API (internally I guess), ALL playback related function will get dropped from the PVR API, so also ReadLiveStream etc.
Thus, FernetMenta would like to open up the discussion on how the new API (that has to go through the inputstream interface) should look like, or which requirements you have on it. To temporarily fix your add-ons until ReadLiveStream etc will get dropped, you can use the buffer dummy stuff linked by negge above.