(2019-10-02, 19:31)edjalmo Wrote: (2019-10-02, 17:50)bsoriano Wrote: (2019-10-02, 03:35)edjalmo Wrote: Thanks!
The online info as a button are really good! I just have a few considerations/suggestions.- Can you add "L" as a Brazil rating too? This is the same rating as "Classificação Livre" and "Brazil: Livre", it's because TMDb use this instead "Livre", and this way Amber not show the apropiate image;
- Also, Brazil ratings are a little bigger in embuary info then default video info. I think this is because you use the same size for all not english ratings, and if that's why, no problem, they are not touching the border line;
- Embuary info have support for RT Critics Consensus? If yes, please add, I like this very much!;
- You can localize the answers for "Known For" too, like "writing", "directing"...?;
- I don't like very much the buttons "close" and "embuary info settings", but I think you added because without they would have no buttons when it is the people page, and would not be nice and I agree with you. I don't know what to show instead;
- I noticed that when a movie are in progress now they show "resume" instead "play". This is nice! Theres just a little bug with this, because when are in "resume" they show the Artwork Beef option in the menu that open;
- Othe labels to localize is "collection", "hours" and "minutes";
- I now that a Amber thing but consider put the "choose art" inside Extras too;
- Hide the arrow in "show fanart" after a little seconds, like in embuary.
I think you are in the right directions for show all details list, buttons and custom list in default position in video info. The details list and buttons are going back to default position when press back and ESC buttons, just the custom list that is not good yet., just the custom list that are not good yet.
Again, thanks!
@edjalmo, thank you for your feedback! Please test the latest from Git.
As to your considerations/suggestions:
1 & 2. Added L for Brazil for embuary-info-video. And yes, I am using only one size of cert. flag for that window.
3. Embuary info does not provide RT consensus, so I cannot show that in that window.
4. I could not find a full list of "known_for_department" for tmdb, so I localized all that I could discern from my movies. If you find any that I missed, please let me know. Thanks.
5. I needed the Close button to have a consistent control to be the default in the online info windows, so that one will stay. I have removed the Embuary Info Settings button.
6. Resume is working fine for me, the context menu just shows "Resume from xxxx" and "Play from the beginning".
7. I localized "Collection"; "Hours" and "Minutes" are Kodi core lables, so they should show up in your interface language.
8. The "Choose Art" is a Kodi provided control for video info, with standard functionality that I don't know how to replicate with my own code. Thus, it will stay where it is.
9. I hid the arrows after a couple of seconds, please let me know if this is what you were looking for.
10. I made some changes to the video and person info windows to try to address always going back to the first list (Cast or other). You might see that another list is being shown, but when you press down from the buttons row, you should always be going to the first list.
Again, please test and let me know your thoughts. Thanks.
Regards,
Bart
1 & 2: Thanks! Can you add for TMDb helper too? I don't have noticed that use "L" there too. And in the case add this for local ratings too, for people that use TMDb scraper.
3: This is sad 
Hope they add in future.
4: Right! Thanks! Will be much work add this localized label for the crew info in custom list too? It would be great if the API already sent the translations, as they exist on the site.
5: You can add Embuary Info Settings in Amber Settings > Video Info, when you ask for show this button. Something like
Quote:Show TMDb info button
Embuary Info Settings
It's a nice shortcut!
6: Here (in Leia) continue show Artwork Beef option. See screenshort:
7: Right! I didn't saw in .po file and confuse myself, sorry! I thing I noticed is when the durations have 0 minutes they show "2 hours, 0". Can you remove the ", 0" in this cases?
8: Check Arctic: Zephyr 2, there they show inside a "manager" button.
9: It's good! Thanks!
10: I saw! It's better now, but if in future you find a way to show cast directly without have to press anything, it's even better.
@
edjalmo, thanks for your quick reply.
1. I will add to the other cert flag options, sure.
4. Yes, it would be a lot of work, since there are many possible roles there. The known for is a much smaller list. I will not be localizing that at this time.
5. That is a good idea, thanks. I will think about it a bit, since the Amber settings option is not just to show the button or not.
6. It will take me a bit to look at this, I only have a Matrix environment to test right now.
7. I thought I had addressed this case. Can you give me an example of a movie where it shows 2hours, 0?
8. I will look, but I think that Arctic Zephyr 2 is not using a separate dialog, but showing something inside the same video info dialog (more complex code for me).
10. I hope I will be able to do so in the future.
I will work on these points later on today.
Regards,
Bart
