Posts: 41
Joined: Dec 2019
Reputation:
0
fihc
Junior Member
Posts: 41
thats what they called double work
-->
Posts: 15,282
Joined: Jan 2009
Reputation:
738
ronie
Team-Kodi Member
Posts: 15,282
just as a sidenode: all of our skinners have to update their skin each and every kodi release.
some skinners maintain three versions of their skins (kodi 17 / kodi 18 / kodi 19)
somehow none of them ever complain....
-->
Posts: 15,282
Joined: Jan 2009
Reputation:
738
ronie
Team-Kodi Member
Posts: 15,282
2020-03-03, 18:00
(This post was last modified: 2020-03-08, 03:59 by ronie.)
i think... no i'm sure, skins are addons as well.
-->
Posts: 13
Joined: Jan 2019
Reputation:
0
@ronie: I think my complain is legit, all the add-ons I work on are Py2/Py3 compatible and there was a lot of time invested to do so.
How hard can it be to make sure that addon.xml is also Py2/Py3 compatible so that add-on developers can submit a Py2/Py3 compatible add-on just once?
In my opinion the release of Kodi 19 should be postponed until Py2/Py3 compatibility in addon.xml is implemented the right way!
-->
Posts: 188
Joined: Feb 2019
Reputation:
90
It would have made sense to announce such a hard break at the Kodi 18 release rather than having devs waste a lot of time making the code py2&3 compatible (as was requested and required) and then flagging all these compatible addons as incompatible anyway.
On my Kodi19 installation, 41 addons are now deemed incompatible and have been forcefully disabled, even though almost all of them were working absolutely fine. Kodi doesn't let me enable them either. Rather than forcefully blocking them, there should be a way to at least manually reactivate them while displaying a warning that they may not work as expected. Or as suggested above, add an addon.xml attribute to mark compatible addons as py2&3 compatible and only disable addons that require py2 and do not have this flag. Addons requiring py3 don't need that flag and are fine anyway. This avoids having to maintain multiple versions of exactly the same codebase, submitted to multiple branches and avoids the mess.
I've picked up and worked on quite a few unmaintained addons and made them py3 compatible, then spent more time re-adding py2 support for the current Kodi18 users and now all of them stopped working again.
-->
Posts: 1,964
Joined: Jul 2012
Reputation:
71
Hi I develop an unofficial plugin that doesn't even go through the Kodi repo that no longer works. It is a specialty addon used by a handful of users and how does it makes sense for Kodi to demand a minimum version which in fact is not actually correct since te addon works fine with python2 in v18 and with python 3 up to now. If Kodi wants to control the official repository that it fine but why does this need to apply to unofficial addons?
Martin
-->
Posts: 5,461
Joined: Jul 2012
Reputation:
383
ISTM in the long or even medium run, it's easier to maintain separate addons rather than try to maintain 2/3 compatibility (unless you do something like if py2 do this, if py3 do that which amounts to separate addons combined into one). If the addon is truly 2/3 compatible, then the only difference is addon.xml?
scott s.
.
-->
Posts: 188
Joined: Feb 2019
Reputation:
90
With separate versions you also need separate repositories, you can't submit a PRs to existing addons without either breaking backwards compatibility to the current release version of Kodi, not supporting Kodi 19 by maintaining the py2 requirement, requiring the maintainer to create a separate branch and/or forking completely and possibly ending up with various versions all over the place.
The kodi team decided 2 years ago to require py2&3 compatibility and there are good reasons for it. Requiring separate versions now after the work has been done to fix the compatibility issues, doesn't make sense.
I could have saved a lot of time not learning how to keep the py2 versions working and only concentrated on py3.
-->
Posts: 15,282
Joined: Jan 2009
Reputation:
738
ronie
Team-Kodi Member
Posts: 15,282
good point. i'll add dependency versions to the list in the first post.
-->
Posts: 271
Joined: Jan 2013
Reputation:
14
One final version to support for a short while... either way python3 is the future
-->
Posts: 13
Joined: Jan 2019
Reputation:
0
There is still great confusion for me regarding this change which makes it impossible for me to customize add-ons for use with Kodi 19 Matrix.
What's the best practice regarding version numbers for Py2/3 compatible add-ons that should work flawlessly for existing users using Kodi 18 who will eventually upgrade to Kodi 19?
-->
Posts: 15,282
Joined: Jan 2009
Reputation:
738
ronie
Team-Kodi Member
Posts: 15,282
could you please be a bit more specific? :-)
the guidelines are outlined in the first post, if you can let me know which part is confusing i'll gladly clarify it.
-->