Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
in it current state it definitely won't be merged. there is absolutely no reason to limit this to external players.
i'll discuss with the author on trac as to why that is, when i get around to it.
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
yes, there is no reason to limit the configuration file to externalplayers. i have always wanted this functionality in general to rid the code of a nasty function. instead we can configure using an xml file, set a default and override where we see fit.
so tiben20, not a slamming of your stuff, just think it can be more
Posts: 144
Joined: Oct 2008
Reputation:
0
moby-uk
Team-XBMC Developer
Posts: 144
I had, I think, the same thoughts; replacing the entire PlayerCoreFactory with something XML-driven. However, I didn't expect that much of a change to be welcomed since it largely benefits the externalplayer which I thought was viewed a bit like a ginger step-child [somewhat rightly so, no-one wants to see XBMC as a launcher].
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
well, if other parts can benefit...
and my personal view in general; if people want to use xbmc as a launcher, why should we limit their option to do so? while i wouldn't put any effort into it myself, you guys have done all the work and everyone benefits..
Posts: 144
Joined: Oct 2008
Reputation:
0
moby-uk
Team-XBMC Developer
Posts: 144
fair enough.
i guess we should take the implementation discussion to trac.
Posts: 1,075
Joined: Jun 2008
Reputation:
128
tiben20
Team-XBMC Developer
Posts: 1,075
The only reason why i did this patch. its only because im having some playback problem with wmv file. And i hate having to use the sub menu to select a different player everytime i play a wmv file.
And just for telling everyone its the first time i was coding in c++. So dont expect too much from me to develop this patch very far.
Posts: 3,904
Joined: Mar 2006
Reputation:
165
What spiff was suggesting should be simple I guess (I'm not a programmer, so I might be totally wrong). Just allow for DVDplayer to be one of the players that can be chosen. Well, now that I think of it... there's no executable to call directly, maybe it's not so simple.
Posts: 4,058
Joined: Oct 2007
Reputation:
89
zag
Team-Kodi Member
Posts: 4,058
2009-04-22, 09:39
(This post was last modified: 2009-04-22, 10:01 by zag.)
What would be even better is to allow conditions like filename so external players could be launched for MMS:// streams or HTTP:// streams.