[DeltaMikeCharlie]

1) My main confusion is around what is relating to Kodi features and what is relating to Estuary design, as reading along, from a purely outside perspective, it feels like these two separate conversations have become a bit entwined.

You are right, the 2 conversations have been intertwined.

There are 2 parts:
Getting the parental rating data into Kodi and available to skins.  This is now complete.
Displaying the parental rating data in Estuary.  This is where we are up to now and the current focus of the discussion.
 

2) I'm still not fully clear how this works. In terms of choosing the user's preferred classification system, is that all going to be handled by the user in their PVR backend?

For now, the PVR addon needs to provide Kodi with one or more parental rating fields (age, code, icon, source). The code is like 'PG' and the icon is a graphical representation hosted by the PVR backend. The PVR backend is currently responsible for working out the users' classification system, etc.

The ParentalRatingSource field was added to allow Kodi to eventually work out the classification system for itself and display the appropriate icon. There has been talk of a 'central addon' to do this, and I already have some ideas, but this is still in the future. The 'central addon' should be able to serve parental rating for TV, movies, games, music, whatever…

pvr.hts and pvr.demo have been updated to provide these extra fields and I am pretty sure that pvr.nextpvr is being updated too.

[emveepee]

Yes I have a PR for pvr.nextpvr with artifacts to support the new fields including classifications system, just waiting for an Estuary or other skin that supports it to test.  I took a different approach to TVHeadend since I don't feel that user should be required to supply the artwork or do any work to support this, I just don't think many will be inclined to do it and built it into the Kodi client. 

My logic is based on the XML file https://movielabs.com/md/ratings/  and really my initial interest was not in providing the icon eye candy it was to extract the age code so all EPG entries with rating would have something, currently this is value pretty much limited to those using DVB for their OTA EPG and PVR is so much more that that.   I actually though the parental rating system in PVR was show based but I think I was wrong since I couldn't restrict individual shows or recordings but it does give core the values should improved parental controls be implemented (or I figure out what I was doing wrong)

pvr.nextpvr uses a configured 2 letter country to distinguish when there is a conflict in text codes used in multiple regions and it uses the EPG genre to help identify movies vs TV.  Nothing is better than the text code that is in the EPG, but it helps with the eye-candy.   Living in Canada where we don't use MPAA it is better to show the appropriated icon.

As for the icon itself they will come from that movielabs site, but the addon also support resource file of icons so that the icons can match the skin.  For the template I used resource.images.classificationicons.colour from https://github.com/wyrm65/resource.image.../resources since it was so well done.  Users can also create their own resource files.  I am hoping that one day there is a Kodi standard resource to to this.

Martin

[emveepee]

Having a bit of a chance to play with DMC's skin I added a standard text box to his skin for comparison and to me text seems more consistent with Estuary.  If any users are viewing this discussion I would be interested in your input.  Should the option by in the skin or the addon?



Martin

[DeltaMikeCharlie]

Thanks for the feedback.  Can you please clarify?

Are you suggesting to always show the parental rating code and icon, as in your examples?

-or-

Are you suggesting adding an option to the Skin to control what is displayed? (I had already thought of this one)

-or-

Are you suggesting adding an option to the PVR addon to control which data is provided?

[emveepee]

First no I am not considering showing both, that would be redundant. I just did that for comparison for others to comment on.

As for preference I am trying to decide if it should be the addon or skin deciding on whether to display icons or text.  For you because the user must configure TVHeadend it isn't quite the same decision.  It could vary by screen since some screens do look better with text and some with the icon.  This one maybe is more a case for text especially the space you need to leave for square icons.

Martin

[DeltaMikeCharlie]

OK, thanks for clarifying.

I think that going down to a screen-by-screen level could lead to inconsistency.  If there is an option, I think that it should be global.

[DeltaMikeCharlie]

Any other comments?