[amasephy]

Great, we finally figure this out.

Btw, I noticed thumbnail resizing in grid view outside of fullscreen mode when entering the search bar. It’s only noticeable on some thumbnails. Three times entering the search bar resets the cycle pattern I was seeing.

[Buschel]

Btw, I noticed thumbnail resizing in grid view outside of fullscreen mode when entering the search bar. It’s only noticeable on some thumbnails. Three times entering the search bar resets the cycle pattern I was seeing.

Hmm, this does not match to how I understood the underlying issue ... But let's see. Btw, how the pattern looks like depends on screen size, the item sizes shown and the amount of items. For example, in my case the issue only flipped between two items.

[amasephy]

Might be unrelated. I could only see the issue on a couple of poster arts and it appeared to be something like a 1 pixel wide border appearing. Should I post images or wait for next TF to see if it’s fixed?

[Buschel]

1.16 build 4861
Release Notes

This build fixes the immovable iPad stack view, the glitch when closing iPad stack during a running bounce animation, the default thumbs for timers and recordings in grid view, applies some cleanup for the deallocation of objects, and it provides a bigger rework on grid view and implementation of "rounded edges". See the release notes and the PRs which are linked from there for further details.

@amasephy, please retest with the new build.

[amasephy]

Thanks for the new build.

One issue we missed and that wasn’t fixed in this build is the same jitter (and even erratic font sizing issues) is present in fullscreen movies recently added view (the view with poster art and banner art side by side). (iPad only)

Secondly, a regression is present likely from your rounded corner refactoring. Recently added movie view doesn’t respect “use rounded corner” setting. With latest TF they’re always presented with rounded corners. (iPhone and iPad).


The issues targeted to be fixed in this TF appear to be corrected now. 👍🏻

[Buschel]

The issues targeted to be fixed in this TF appear to be corrected now. 👍🏻

That's great. I was hoping that the grid view (PosterCell) rework resolved the glitches.

One issue we missed and that wasn’t fixed in this build is the same jitter (and even erratic font sizing issues) is present in fullscreen movies recently added view (the view with poster art and banner art side by side). (iPad only)

Yes, I did not touch this code. This would require similar changes like done for the standard grid view (PosterCell). I will look into this, but this does not hold back the release.

Secondly, a regression is present likely from your rounded corner refactoring. Recently added movie view doesn’t respect “use rounded corner” setting. With latest TF they’re always presented with rounded corners. (iPhone and iPad).

I need a facepalm icon. I was even reviewing this very change and did not see this obvious error. I just called the wrong method, the one which does not check for the setting but just applies rounded corners... Fixed.

[Buschel]

This would require similar changes like done for the standard grid view (PosterCell). I will look into this, but this does not hold back the release.

This looked really bad, so I reworked this now. Also did some more changes to improve readability and avoid code duplication. I am quite happy with this now and hope no other issues pop up.

[amasephy]

I am really glad to hear you looked into that section. I was considering urging you to look at it before release because it was way worse than the previous jitter issue. 🙂

Kudos 👍🏻

[amasephy]

Found another bug related to global search. Near as I can tell this is the only spot this kind of issue exists.

Set the sort to reverse sorting for type.

Tap in search box.

Sorting of view immediately inverts sorting of the view but the index stays reversed.

All other views and libraries maintain the reversing sorting while search box is active.


Edit: Second bug. Start party mode from now playing.

Navigate to movies. Long press on a movie. Select play trailer.

Maybe it’s because trailers are not working because the YouTube plugin is broken but when it takes me back to now playing party mode is still appears to be activated but it’s really not activated.

[Buschel]

I am really glad to hear you looked into that section.

I was not aware how bad the behaviour actually was. Even the official release looks horrible, with lots of images reloading and labels moving around.

Found another bug related to global search. Near as I can tell this is the only spot this kind of issue exists.

Yep, another hard-coding which came in with the very first implementation of the feature to keep showing section for sort-by-type in Global Search. Fixed.

Edit: Second bug. Start party mode from now playing.

Works for me. I am also quite sure this is a Kodi problem. The party mode is read from server each second and then displayed.

@amasephy, you see any change in scroll smoothness with rounded corners enabled -- in grid view or in list view?

[amasephy]

Buttery smooth here.

Another bug discovered. A recent change you made was when clearing a search you are supposed to be taken back to the top of a list.

This works but only when you press cancel. If you press the X within the search box it only scrolls up a little, not back to the top.

The funny thing is if you start scrolling even a little you are swept to the top of the list. Like the app knows it was supposed to have done that in the first place.

[Buschel]

Buttery smooth here.

That's what I was hoping for

Another bug discovered.

Pressing cancel really ends the search, whereas pressing "x" just deletes the input to search field. So these are different things. But I agree, it could make sense to also move back to top, especially as the next scrolling attempt anyway does this. A quick try (just moving to top, if the search field is empty) had side effects. I will keep my fingers off this for now.

[amasephy]

Thanks for looking at and clarifying. The subtle nuance of intended behaviors is obvious now that you explain it.

While the current behavior is wonky I definitely understand not wanting to mess with it right before release. We’ve seen how fun the search bar is to make changes to. 🙂

Hopefully this is the end of things to report for this release. 👍🏻

[Buschel]

1.16 build 4870
Release Notes

Fixes the erratic visual glitches with „recently added“ in grid view, brings back non-rounded corner for the same and lets GlobalSearch by-type follow selected sort order during active search.

@kambala, thanks for the quick support on making this happen 👍

[amasephy]

All targeted fixes seem to be working.

I did find two minor issues, nothing worth holding up release though imo.

First is if you haven’t connected to Kodi server yet and it’s attempting in the background, if you happen to have the mascot screen up the toast starts appearing there on that panel and it looks really weird. Very minor thing.


Secondly, more noticeable. If you have banner art view enabled for TV shows and you make a selection, the blue highlight does not work. It works for list view, and grid view everywhere but not banner art.

Edit: Btw I forgot to mention but the app crashed on me last night while I was scrolling through global search. I hit submit feedback or crash report so you should be getting that information from Apple.