Posts: 26,215
Joined: Oct 2003
Reputation:
187
I don't see why we can't use the dialog: It automatically gives categories to allow you to split things up anyway.
A shortcut to skin settings available in Appearance->Skin makes sense.
Cheers,
Jonathan
Posts: 17,414
Joined: Aug 2007
Reputation:
590
Hitcher
Team-Kodi Member
Posts: 17,414
I can see the need to have them in the same fullscreen layout as the standard settings (SettingsCategory) as opposed to a dialog like the addon settings (DialogAddonSettings) and also accessed from the Settings screen (Settings > Current Skin).
To achieve this couldn't we have a new dialog - DialogSkinSettings?
It could use the same controls as DialogAddonSettings but it would allow us skinners to display it as a fullscreen window just like the standard settings.
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
sure, that is very much doable, i never imagined anything but a shortcut in the settings (and it's already supported actually - addon.default.OpenSettings(xbmc.skin) (don't try this in current master, it will likely fail horribly). but i don't see how anyone can get confused which skin they are configuring, since you will have to go through the browser to configure anything but the currently used one, that was my point.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Why do you want skin settings full screen but other addons not full screen?
Some addons have lots and lots of settings (youtube for instance) - some more than some skins have.
Either way I think you could achieve a fullscreen look in a dialog for your skin settings via a conditional include?
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
Only objection I have against this is that it's up to the skinner to decide where to place the settings. Not everybody will move the settings to the add-on settings or will have additional settings windows. This can be confusing to the end-user imo.
Posts: 17,414
Joined: Aug 2007
Reputation:
590
Hitcher
Team-Kodi Member
Posts: 17,414
Surely the end-user wont know the difference?
Selecting 'Add-on Settings' will either take you a custom Skin Settings window (if present) or Add-on Settings.
Or selecting 'Skin Settings' from Appearance will take you to either the Skin Settings window or Add-on Settings.
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
I missed page 2 there...
How will that work, do we get a new window id for the skin settings adn if that is used that window will pop-up and otherwise add-on settings screen?