[thica]

The following code segment will enable movieset Fanart , if those pictures are available.

I will not submit a patch, as even simple bugfixes are ignored.

It's a six line change, so its easy to implement:

file:FileItem.cpp

Code:

CStdString CFileItem::GetCachedFanart() const
{
  // get the locally cached thumb
  if (IsVideoDb())
  {
    if (!HasVideoInfoTag())
      return "";
    if (!GetVideoInfoTag()->m_strArtist.IsEmpty())
      return GetCachedThumb(GetVideoInfoTag()->m_strArtist,g_settings.GetMusicFanartFolder());
    if (!m_bIsFolder && !GetVideoInfoTag()->m_strShowTitle.IsEmpty())
    {
      CVideoDatabase database;
      database.Open();
      int iShowId = database.GetTvShowId(GetVideoInfoTag()->m_strPath);
      CStdString showPath;
      database.GetFilePathById(iShowId,showPath,VIDEODB_CONTENT_TVSHOWS);
      return GetCachedThumb(showPath,g_settings.GetVideoFanartFolder());
    }

[color=red]    if (m_bIsFolder)
    {
      if (GetVideoInfoTag()->m_strPath.empty())
      {
        // For Movieset Fanart
        return GetCachedThumb(m_strPath ,g_settings.GetVideoFanartFolder());
      }
      else
      {
        return GetCachedThumb(GetVideoInfoTag()->m_strPath ,g_settings.GetVideoFanartFolder());
      }
    }
    else
    {
      return GetCachedThumb(GetVideoInfoTag()->m_strFileNameAndPath,g_settings.GetVideoFanartFolder());
    }
  }[/color]
  if (HasMusicInfoTag())
    return GetCachedThumb(GetMusicInfoTag()->GetArtist(),g_settings.GetMusicFanartFolder());

  return GetCachedThumb(m_strPath,g_settings.GetVideoFanartFolder());
}

For hash of Movieset Fanart please look at:
http://forum.xbmc.org/showthread.php?p=8...post822991

This code fragment will not cover the gui part to set the movie set fanart by the user.

[thica]

Did someone picked that up?

[Memphiz]

if you have the feeling the team ignores your fixes how about getting a github account and feed your work in by using pull requests ... that way all devs get mailed with your work and a review and merge into master is more likely... just my 2 cents

its not by intention to "ignore" patches ... more about lack of time to get them adapted to fit the project - which might be needed sometimes ... github allows a much better handling and communication with code contributors and other devs...

[spiff]

i for one stopped reading on line 2.

[thica]

Your choice...

btw: I have a github account

[da-anda]

what is this patch doing? I nightly builds I already can set a movieset fanart.

[thica]

This enables to show Fanart-Pics for moviesets, if they are present. If this is already included in the nightlys, then it is great. This was missing in Dharma.