[Windows] AudioEngine testers - Windows platform only
(2012-04-30, 12:37)gnif Wrote: @PanDaMan - DaniellaE's branch will also be clipping, this is an existing issue, what's different is that AE reports it so we know when it occurs. We are currently working on a DRC patch that will help with this behaviour instead of just clamping the buffer. (We never output clipped audio, we have a soft clamper that performs a poor mans DRC to the samples when this occurs).

@gnif - Thanks. I did not hear any distortion with DaniellaE's, I also don't hear anything or get any clamping logged if I set the volume in guisettings to 0.999999 which should be close enough to 1.0 not to matter. See http://xbmclogs.com/show.php?id=2103
My C is very rusty, but wouldn't the missing 'f' suffix on line 939 in SoftAE.cpp mean it's being compared as a double rather than float and could the promotion be marginal making it think it needed to clamp when it didn't?

By "poor man's DRC" did you mean the tanh approximation? That looks well off for values |x| > 0.5 if I'm reading the plot here correctly: http://bit.ly/Jx4ULG Applying this only on blocks with values > 1.0 means there's additional non-linearity between blocks that get clamped and those that don't. That might also cause the distortion I was hearing.

Finally, the SSE clamp looks broken, implementing (x * (c1 + x^2)) / (c2 + x^2). c2 should just be 9.0f and an additional multiply operation is needed (x * (c1 + x^2)) / (c1 + (c2 * x^2))
Reply


Messages In This Thread
[No subject] - by GreenEyez - 2012-03-04, 12:35
[No subject] - by liquidskin76 - 2012-03-04, 14:01
[No subject] - by Dixon Butz - 2012-03-04, 14:55
[No subject] - by P-I H - 2012-03-04, 17:16
[No subject] - by DDDamian - 2012-03-04, 20:12
[No subject] - by P-I H - 2012-03-04, 20:43
[No subject] - by DDDamian - 2012-03-04, 20:47
[No subject] - by P-I H - 2012-03-04, 22:27
[No subject] - by DDDamian - 2012-03-04, 22:37
[No subject] - by liquidskin76 - 2012-03-05, 02:42
[No subject] - by DDDamian - 2012-03-05, 05:07
[No subject] - by liquidskin76 - 2012-03-05, 10:55
[No subject] - by P-I H - 2012-03-05, 12:48
[No subject] - by DDDamian - 2012-03-06, 04:31
New build posted - by DDDamian - 2012-03-06, 11:08
[No subject] - by liquidskin76 - 2012-03-06, 13:51
[No subject] - by P-I H - 2012-03-06, 21:43
[No subject] - by DDDamian - 2012-03-07, 00:31
[No subject] - by DDDamian - 2012-03-07, 01:22
[No subject] - by liquidskin76 - 2012-03-07, 01:48
[No subject] - by DDDamian - 2012-03-07, 01:52
[No subject] - by -JK- - 2012-03-07, 02:08
[No subject] - by DDDamian - 2012-03-07, 09:30
[No subject] - by liquidskin76 - 2012-03-07, 11:04
[No subject] - by DDDamian - 2012-03-07, 15:53
[No subject] - by DDDamian - 2012-03-07, 16:52
[No subject] - by P-I H - 2012-03-07, 18:17
[No subject] - by DDDamian - 2012-03-07, 18:26
[No subject] - by P-I H - 2012-03-07, 18:31
[No subject] - by -JK- - 2012-03-07, 18:33
[No subject] - by DDDamian - 2012-03-08, 01:47
[No subject] - by -JK- - 2012-03-09, 01:44
[No subject] - by DDDamian - 2012-03-09, 02:25
[No subject] - by HeresJohnny - 2012-03-09, 08:41
[No subject] - by DDDamian - 2012-03-09, 08:58
[No subject] - by -JK- - 2012-03-11, 02:10
Audio clamping - by PanDaMan - 2012-04-30, 00:56
RE: [Windows] AudioEngine testers - Windows platform only - by PanDaMan - 2012-05-01, 06:17
Logout Mark Read Team Forum Stats Members Help
[Windows] AudioEngine testers - Windows platform only3