[bossanova808]

Hey pkscout

Anyway we can improve on the exit resiliance of XSqueeze/AS? I am having some issues - due to some necessary changes in my threading, I am hanging on:

Code:

#wait here for Artist slideshow to finish, can occasionally take several seconds
      while (not xbmcgui.Window(xbmcgui.getCurrentWindowId()).getProperty("ArtistSlideshow.CleanupComplete") == "True"):
        log("Still waiting for artistslideshow to stop")
        xbmc.sleep(1000)

...I think the call to xbmc.sleep means the thread never unlocks from the current lock this is all wrapped in, so it just hangs there....

AS takes a *long* time to exit - without it my addon exits instantly, but even without this hang, it can take up to 10+ seconds, which is...inelegant.

If I remove the while loop above, AS will crash:

Code:

16:39:44 T:6008   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.RuntimeError'>
                                            Error Contents: access_voilation
                                            Traceback (most recent call last):
                                              File "C:\Users\x\AppData\Roaming\XBMC\addons\script.artistslideshow\default.py", line 743, in <module>
                                                slideshow = Main()
                                              File "C:\Users\x\AppData\Roaming\XBMC\addons\script.artistslideshow\default.py", line 155, in __init__
                                                self.WINDOW.clearProperty("ArtistSlideshowRunning")
                                            RuntimeError: access_voilation
                                            -->End of Python script error report<--

Can you maybe check if the window exists or just wrap it up in a try/except or something?

I'd really like to
a) not hang
and
b) exit much more quickly if possible.

Any ideas on improvements

(testing with Frodo nightlies, which are a bit of a mess from a Python perspective!)