[felle42]

Hi,

at first: thank for this beautiful plugin. Really good work! I think I've found a bug while playing music via Airplay.
The first artist art is loading but then artist slideshow keeps artist art of the first title even the next songs are played.
A deeper look into the code showed something that I changed. In line 706 I changed:

Code:

playing_file = xbmc.Player().getPlayingFile()

to

Code:

playing_id = xbmc.Player().getMusicInfoTag().getTitle() + xbmc.Player().getPlayingFile()

and of course in line 713ff

Code:

if playing_id != self.LASTPLAYINGFILE:    
  # if the same file is playing, use cached JSON response instead of doing a new query
                response = xbmc.executeJSONRPC ( '{"jsonrpc":"2.0", "method":"Player.GetItem", "params":{"playerid":0, "properties":["artist", "musicbrainzartistid"]},"id":1}' )
                self.LASTPLAYINGFILE = playing_id
                self.LASTJSONRESPONSE = response

xbmc.Player().getPlayingFile() always return something like stream://pipe1 and did not change while the airplay stream
was continous.


I am not a Python developer and have no deep knowledge of the xbmc-api so you have to verify my change. For music from the database and internet radio my code also did the trick.

Also there is a smaller bug if you have turned on htbackdrops for artist retrieval. Since you removed the lastFM support the variables for image width and height caused an error because of missing variables(line 877 in default.py). I put in some hardcoded width and height in the url for htbackdrops and solved this for me.
Perhaps you could find a better solution here.

It would be nice if you could add a fix, so updates don't let me lose airplay-support.

Keep up your nice work!

Best regards
Ralf