[amet]

Hi Amet,

I saw you pull request (https://github.com/xbmc/xbmc/pull/1444#i...nt-9219031) about subtitle addons restructuring, and i find this idea great. Anybody could give a hand and do his own xbmc.subtitle.module using you amazing script.
The fact you close this request, does it mean you dropped the idea of developing xbmc subtitle 4.0.0 with separate xbmc.subtitle.module?

Thank you very much for the great work, I am using your addon every single day!

that was the idea, we were very close to frodo release and didn't feel confident enough that it wont break stuff

as soon as Frodo is out of the door, I'll submit it again and start the work on it again. main addon is done(gui part) and I have converted 2 services as a guide.

https://github.com/amet/script.xbmc.subt....subtitles should work with above PR and here is one of the services -> https://github.com/amet/OpenSubtitles-service

service.py has some commented code and should be pretty self-explanatory.if you are thinking of doing a service please wait until its in so you dont waste time doing it if it doesn't make it

if anyone has any suggestions for this transition, I am all ears... idea is that I will maintain main GUI part of the addon and some of my services, and other services will be maintained and submitted directly to XBMC official repo by authors themselves.

more to come once/if we get that PR in

amet

[Temhil]

That is a great news, it would have been a shame not to go forward with this idea.
I am curious what would be the management of xbmc.subtitle.module in XBMC subtitle, via the settings menu, or totally up to XBMC via enabling or not the xbmc.subtitle.module? My guess is that would the the 2nd one otherwise XBMC setting management would have to change too.

[amet]

That is a great news, it would have been a shame not to go forward with this idea.
I am curious what would be the management of xbmc.subtitle.module in XBMC subtitle, via the settings menu, or totally up to XBMC via enabling or not the xbmc.subtitle.module? My guess is that would the the 2nd one otherwise XBMC setting management would have to change too.

ATM, the idea is to have all module specific settings in a module itself, and all GUI script(XBMC Subtitles 4.0.0) settings in it as we are now.there is no way to pull all other settings from service modules in the main addon. some addons might not need anything, some have 10 settings, it all depends on teh service and how its coded. main thing is to remove those out of main addon and keep that clean.

it might be a bit involved to initially setup but once done, it would be a breeze...

amet

[Temhil]

Yes, you can get update per service, very well designed, I really like the idea and looking forward to it.
Also less time consuming for you, it must have been a nightmare to maintain each service in xbmc subtitle. I know what it is.
Thank you!

[amet]

Yes, you can get update per service, very well designed, I really like the idea and looking forward to it.
Also less time consuming for you, it must have been a nightmare to maintain each service in xbmc subtitle. I know what it is.
Thank you!

yeah, thx for the support

it wasn't easy maintaining it, most problems came from uses demanding fixes and I had nothing to do with the service. at first I got upset about it, now I just ignore it and wait for authors to fix stuff

[Phantom_Zone]

Did you try deleting the add on folder AND the user addon folder ?
Then redownload and parameter the add on?

There is now a function in the parameter that allow you to automatically donwload the sync sub (if founded of course)

It actually looks like recent builds...I tried some pre 12 builds and they work fine (within 10 seconds)

I'll have a look at a full reinstall and check out your suggestions...was meaning to do it anyway! Cheers for the reply...

[fernandovg]

Amet, is it possible to include a text at the SETTINGS ?

Users that has media on shares always complain about the subtitle not showing.

I would suggest change the text:

"Subtitle Download Folder Same As Movie (disable to use with shares)"
"Custom sub downloaded path (Enable to use with shares)
"Add language to Filename (disable to use with shares)"

What do you think?
Otherwise subtitles wont show up if you don't set this options this way;
Thanks

[Pienoet]

Hi amet,

I have a problem with pneumatic.

If I stream a movie while downloading I would I get a message that the only choose subtitles for series and on bierdopje nothing is found.

While this is still a movie not a tv show then he would have to look at ondertitel.com or opensubtitles instead of bierdopje?

Sorry for my bad english.

[ashenha]

hi amet i m so grateful for your efforts thanxxxxxxxxxxxxxxxxxx


i have this one issue with subscene it does search subs but doesn t download them plzzzzzzzzzzzzzz
helppppppppppppppp

[amet]

Debug Log gggggggggg

[fernandovg]

Amet, what do you think about my suggestion?

[amet]

@fernandovg
shares? as in SMB://? I only have media there and dont have any issues. its a share setup issue

[ashenha]

soryyyyyyyyyyyy amet this is the debug log if u were referring to me


http://pastebin.com/S2PVxsgz

[amet]

not a Debug Log

[ashenha]

sorrryyy again i hope this it after enabling debug logging

but this is for version 3.5.1

http://pastebin.com/E10Ht5u0