2012-12-14, 00:15
(2012-12-13, 23:08)Temhil Wrote: Hi Amet,
I saw you pull request (https://github.com/xbmc/xbmc/pull/1444#i...nt-9219031) about subtitle addons restructuring, and i find this idea great. Anybody could give a hand and do his own xbmc.subtitle.module using you amazing script.
The fact you close this request, does it mean you dropped the idea of developing xbmc subtitle 4.0.0 with separate xbmc.subtitle.module?
Thank you very much for the great work, I am using your addon every single day!
that was the idea, we were very close to frodo release and didn't feel confident enough that it wont break stuff
as soon as Frodo is out of the door, I'll submit it again and start the work on it again. main addon is done(gui part) and I have converted 2 services as a guide.
https://github.com/amet/script.xbmc.subt....subtitles should work with above PR and here is one of the services -> https://github.com/amet/OpenSubtitles-service
service.py has some commented code and should be pretty self-explanatory.if you are thinking of doing a service please wait until its in so you dont waste time doing it if it doesn't make it
if anyone has any suggestions for this transition, I am all ears... idea is that I will maintain main GUI part of the addon and some of my services, and other services will be maintained and submitted directly to XBMC official repo by authors themselves.
more to come once/if we get that PR in
amet