[olympia]

Really...?! I am running quite behind then, right?

[DaveBlake]

Something for you to look at @olympia  when you get back, just logging details here so I don't forget.

Sometimes the artist scraper is picking up "url" as artist type rather than values like "Person" or "group" (or nothing), I'm pretty sure it is because the parsing is hitting the wrong bit of xml.
For example an artist that ends up with type = "url":

Code:

http://musicbrainz.org/ws/2/artist/09c815d1-121e-45f4-a643-f6b846141218?inc=url-rels

The result doesn't have an artist type

Code:

<metadata>
<artist id="09c815d1-121e-45f4-a643-f6b846141218">
<name>Bop City</name>
<sort-name>Bop City</sort-name>
<relation-list target-type="url">
<relation type="discogs" type-id="04a5b104-a4c2-4bac-99a1-7b837c37d9e4">
<target id="4e6f8927-57e5-4d1a-9d43-17b1d13589fe">https://www.discogs.com/artist/1122255</target>
</relation>
</relation-list>
</artist>
</metadata>

While results with an artist type are like this

Code:

<metadata>
<artist type-id="b6e035f4-3ce9-331c-97df-83397230b0df" type="Person" id="1d543e07-d0d2-4834-a8db-d65c50c2a856">
<name>Dolly Parton</name>
<sort-name>Parton, Dolly</sort-name>
...

Hope that you can work your magic with the regexp and the fix is obvious

[olympia]

I think I have got this fixed with v4.1.3 (Leia). Assuming there is only "Person" and "Group" or nothing can be taken as applicable values. Now it is actually restricted to these.

[DaveBlake]

Thanks @olympia, but what are you doing scraper things while on holiday?

Assuming there is only "Person" and "Group" or nothing can be taken as applicable values. Now it is actually restricted to these.

Sorry more values are possible and acceptable, as the Musicbrainz documentation provides https://musicbrainz.org/doc/Artist#Type

Just not sure how to catch "type" only when within the "artist" tag with regexp.

[olympia]

Thanks for the feelings Dave! I can do smaller things.
I included those other artist types in v4.1.4, so should be good now. BTW, is anything in Kodi using this field yet?

[DaveBlake]

Thanks @olympia.  Artist type is available as a filter criteria on both side blade filter dialog and smart playlist rules. Skins could show it too, there is an info label, but whether they do or not is up to the skinner.

[olympia]

Any Liea nightly from the last 2 months I think. I've been using the new types from my local artwork successfully in that time.

EDIT: Actually, how time flies... 6 months ago!

https://github.com/xbmc/xbmc/pull/13848
https://github.com/xbmc/xbmc/pull/13101
https://github.com/xbmc/xbmc/pull/13352

 Hey Zag,

Try Universal Artist Scraper v4.2.0 and Universal Album Scraper v3.1.0 and let me know your thoughts, issues, etc.

@Karellen, I would appreciate if you could also do some testing on these, thank you in advance.

[djc5166]

Trying to update to Universal Artist Scraper v4.2.0 but it says it depends on metadata.common.theaudiodb.com v3.0.0, and only v2.0.0 is available. Am I missing something?

[Karellen]

Yep, thanks @djc5166 It has already been reported. olympia will need to look at it.

[Karellen]

metadata.artists.universal-4.2.1 for v18-Leia is now available.
http://mirrors.kodi.tv/addons/leia/metad...universal/

This version requires a number of dependencies be installed as follows.

metadata.common.theaudiodb.com-2.0.0 - http://mirrors.kodi.tv/addons/leia/metad...diodb.com/
metadata.common.fanart.tv-3.5.0 - http://mirrors.kodi.tv/addons/leia/metad...fanart.tv/

We recommend waiting for your local repository to update

[docwra]

Apologies for the delay, I've been sunning myself in the Bahamas :p

I'm testing with a single artist, on a brand new Kodi install with latest nightly:

A quick test shows that the scraper seems to be doing what its supposed to do, but I don't see any of the artwork links written to the database. Only thumb and Fanart still.

Code:

00:12:34.746 T:2484   DEBUG: CurlFile::Open(0x27ca6aad400) http://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/artist-mb.php?i=8e68819d-71be-4e7d-b41d-f1df81b01d3f
00:12:34.801 T:2484   DEBUG: CCurlFile::Open - effective URL: <https://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/artist-mb.php?i=8e68819d-71be-4e7d-b41d-f1df81b01d3f&i=8e68819d-71be-4e7d-b41d-f1df81b01d3f>
00:12:34.820 T:2484   DEBUG: CScraperUrl::Get: Using content of "http://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/artist-mb.php?i=8e68819d-71be-4e7d-b41d-f1df81b01d3f" as binary or text with "UTF-8" charset
00:12:34.845 T:2484   DEBUG: scraper: ParseTADBArtistThumbs returned <details><thumb preview="https://www.theaudiodb.com/images/media/artist/thumb/yrsrpu1340531686.jpg/preview">https://www.theaudiodb.com/images/media/artist/thumb/yrsrpu1340531686.jpg</thumb></details>
00:12:34.845 T:2484   DEBUG: scraper: GetTADBArtistClearlogoByMBID returned <details><url function="ParseTADBArtistClearlogo" cache="tadb-8e68819d-71be-4e7d-b41d-f1df81b01d3f-artist.json">http://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/artist-mb.php?i=8e68819d-71be-4e7d-b41d-f1df81b01d3f</url></details>
00:12:34.847 T:2484   DEBUG: scraper: ParseTADBArtistClearlogo returned <details><thumb aspect="clearlogo" preview="https://www.theaudiodb.com/images/media/artist/logo/uswwup1521466960.png/preview">https://www.theaudiodb.com/images/media/artist/logo/uswwup1521466960.png</thumb></details>
00:12:34.848 T:2484   DEBUG: scraper: GetTADBArtistClearartByMBID returned <details><url function="ParseTADBArtistClearart" cache="tadb-8e68819d-71be-4e7d-b41d-f1df81b01d3f-artist.json">http://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/artist-mb.php?i=8e68819d-71be-4e7d-b41d-f1df81b01d3f</url></details>
00:12:34.850 T:2484   DEBUG: scraper: ParseTADBArtistClearart returned <details><thumb aspect="clearart" preview="https://www.theaudiodb.com/images/media/artist/clearart/ttysqp1521467214.png/preview">https://www.theaudiodb.com/images/media/artist/clearart/ttysqp1521467214.png</thumb></details>
00:12:34.850 T:2484   DEBUG: scraper: GetTADBArtistLandscapeByMBID returned <details><url function="ParseTADBArtistLandscape" cache="tadb-8e68819d-71be-4e7d-b41d-f1df81b01d3f-artist.json">http://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/artist-mb.php?i=8e68819d-71be-4e7d-b41d-f1df81b01d3f</url></details>
00:12:34.852 T:2484   DEBUG: scraper: ParseTADBArtistLandscape returned <details><thumb aspect="landscape" preview="https://www.theaudiodb.com/images/media/artist/widethumb/uyvttt1521467081.jpg/preview">https://www.theaudiodb.com/images/media/artist/widethumb/uyvttt1521467081.jpg</thumb></details>
00:12:34.852 T:2484   DEBUG: scraper: GetTADBArtistBannerByMBID returned <details><url function="ParseTADBArtistBanner" cache="tadb-8e68819d-71be-4e7d-b41d-f1df81b01d3f-artist.json">http://www.theaudiodb.com/api/v1/json/58424d43204d6564696120/artist-mb.php?i=8e68819d-71be-4e7d-b41d-f1df81b01d3f</url></details>
00:12:34.854 T:2484   DEBUG: scraper: ParseTADBArtistBanner returned <details><thumb aspect="banner" preview="https://www.theaudiodb.com/images/media/artist/banner/wxvpvx1362645850.jpg/preview">https://www.theaudiodb.com/images/media/artist/banner/wxvpvx1362645850.jpg</thumb></details>

Full log: https://paste.ubuntu.com/p/9RDr8BDWdm/

Artwork table only seems to have thumb and Fanart in it:



Test Database: https://1drv.ms/u/s!ApVfAvr-zU1_hJhtaTVLdr0WEQQokQ

@DaveBlake any ideas whats going on? Do the new artwork types perhaps need to be added to the default Kodi installation before scraping?
When I go to artist information and click "Choose Art", I still do not see any extra artwork such as "ClearArt" or "Banner" after the initial scrape (using these new scrapers with download ClearArt and Banner enabled).

[Karellen]

@docwra

Did you add the code to advancedsettings.xml? See lines 19-28... https://kodi.wiki/view/Advancedsettings....siclibrary

[docwra]

@docwra

Did you add the code to advancedsettings.xml? See lines 19-28... https://kodi.wiki/view/Advancedsettings....siclibrary

 Great! that was it

The obvious question now, is how to make this as default in Kodi? Advanced settings is not suitable for "normal" users as @Martijn mentioned on GitHub. I understand this is a "first step" though and wonderful to see it working and extensible for the future.
SIDE NOTE: The music artwork image types are set and won't change going forward (other than perhaps to add new ones, but this will be very rare). So I hope some way is found to default these in Kodi, so we can finally start getting artwork and skins up-to-speed. Something like 5,000+ of these new image types have been uploaded on TADB in the last few months

For anyone wishing to test it out here are the settings for artist artwork:

C:\Users\user\AppData\Roaming\Kodi\userdata\advancedsettings.xml

Code:

<advancedsettings>
    <musiclibrary>    
        <artistextraart>
            <arttype>clearlogo</arttype>
            <arttype>discart</arttype>
            <arttype>banner</arttype>
            <arttype>landscape</arttype>
        </artistextraart>
    </musiclibrary>
</advancedsettings>

[DaveBlake]

The obvious question now, is how to make this as default in Kodi? Advanced settings is not suitable for "normal" users as @Martijn mentioned on GitHub. I understand this is a "first step" though and wonderful to see it working and extensible for the future.

That the scraper can return URL links for extended art types (and that TADB has those images to use) is a recent addition, that has come after my initial implementation of support for extended art types in core code that works for automatically picking up locally held art. With the right entries in advancedsettings.xml it works for scraped art links as well, but I know it is a little clunky. In v18 this is more an advanced users facility for those with an interest in local art and or skins than something automated for the beginner. The latter will come but, since we are (finally) in beta phase and the addition of new features frozen, not in v18. I know how enthusiastic you are for more art @docwra, but I am reluctant to actively promote what functionality we have now if it will just lead to user (+ team)  frustration and moaning because it isn't fully automated and integrated yet.

I am happy to discuss how we achieve an automated, fully integrated and flexible extended art facility, just not sure this support thread for the artist scraper is the best place to do it. I'll start something in Music Support, users are used to seeing my design discussion there, rather than further divert this thread.

[HeresJohnny]

I would like to throw a "problem" with musicbrainz out there that is driving me nuts. When refreshing certain artists from their information overview, those artists are not found by UAS at all. What those artists have in common is that musicbrainz doesn't list them with their latin/ASCII character names but in their native characterset, be it Cyrillic, Japanese, Chinese, whatever. Obviously, I don't know how to enter that information with my keyboard and I find this style decision absolutely insane for a service that aims to be universal. When browsing musicbrainz directly, my way of writing is at least listed as an alias or as the sort name.

Example:
Musicbrainz artist: Пётр Ильич Чайковский
Sortname: Tchaikovsky, Pyotr Ilyich

Long story short, would it be possible to use sortname or alias to expand search criteria? Could be a setting in options with a warning that this may make search less accurate (A similar thing happens when searching IMDB for short films).

Thanks in advance!