[wellspokenman]

It's still pending approval for the main repo, but the 0.5 commit I've submitted is in the OP. Don't know how long submission takes these days, but it's been a week now, so shouldn't be too much longer.

I recently upgraded to krypton 17.3 and while checking if everything works, I remembered, that you mentioned v0.5 but kodi only shows v0.4 as an available update. Did your addon didn't approve, or does it take that long? (a shame, if so) :-)

The submission process has changed significantly since I last did this. The Kodi team is helping me with it, but there were many things I had to change to get approval, resulting in some lengthy delays. I resubmitted on June 13 and am hoping this one ticks all the boxes. I've updated OP with this most recent 0.5 commit if you'd like to try it manually - fingers crossed we get this sorted soon.

[xbozzo]

Hi,
I randomly checked the kodi log and found this:

Code:

12:52:50.275 T:1710457760  NOTICE: TAG-GEN: Starting IMDB tag writing.
12:52:52.016 T:1710457760  NOTICE: TAG-GEN: http://rss.imdb.com/list/ls004187379/ contains no IMDB IDs. Check URL and retry.
12:52:52.017 T:1710457760    INFO: CPythonInvoker(6, /storage/.kodi/addons/script.tag-generator/main.py): script aborted
12:52:52.081 T:1710457760    INFO: Python script stopped

After checking the mentioned URL, I know: "contains no IMDB IDs" was a HTTP 404 error.

Luckily, it was the first URL in my list which was not available anymore. So I repleaced it with another working URL.

What happended? The IMDB user who created the list, deleted it, which then stopped you addon after the first URL.

Can you consider, anywhen, to SKIP (and report to the log) 404 URLs or lists with problems, instead of stopping the complete process of fetching?

So the tags are written for all lists which are valid and skipped for the non-valid ones... however, tags are written/updated, which is important :-) now, no tags are written.



Anyways, your addon is absolutly the best, to find movies of a specific genre in our movie collection. It shows some movies, I forgot about and now can watch, whereas I never had searched for in our collection 8-)

[wellspokenman]

Can you consider, anywhen, to SKIP (and report to the log) 404 URLs or lists with problems, instead of stopping the complete process of fetching?

Shouldn't be too hard; it's a good idea that will improve the addon.

[xbozzo]

Hello wellspokenman,

the last days an update to your fine addon was anounced to my kodi 17.3. machine :-)

Unfortunately, it did not auto-update, because of:

Code:

DEBUG: CAddonInstallJob[script.tag-generator]: requires script.module.oauthlib version 2.1.0 which is not available
ERROR: CAddonInstallJob[script.tag-generator]: The dependency on script.module.oauthlib version 2.1.0 could not be satisfied.

I did a web research, but got irritating information on what this oautlib is good for. There were some download links, but I hesitated to download something from the net, which I expect must be available from my kodi repository.

I searched within the kodi addons, but it did not find any results on oautlib.

So how can I manually update your addon? Please advise.

[wellspokenman]

Hi,
Sorry you're having trouble, and thank you for including the error. This has to do with one of my dependencies for trakt (oauthlib). Specifically, it has to do with how I include it in the addon. In the previous version I included the files that I needed directly, but this wasn't considered best practice, so it was changed to include a reference to the Kodi version of oauth (script.module.oath...). Clearly that hasn't worked. I can only recommend you go back to the previous version until I figure this out (the only difference in the versions is the way dependencies are included - no bugfixes or functionality have been added).

[xbozzo]

Hi,
no trouble at all :-) just curious!
Thanks for clarifying.

Until the dependency is solved, no update is possible (kodi won't me me install the new version), therefore, I'll be using the previous version anyways....

Also, I'm not using trakt features, so I guess, I don't "need" the update...

(furthermore, I was curious, if my modified code of your addon would be silently overwritten by the newer version of the addon.)

Thank you for investing your private time!

[wellspokenman]

I've submitted the pull request, it's a really small fix, so hopefully it goes through quickly. Edit: yep, its in the Krypton branch now. That should fix the error.

[bluenote]

I've submitted the pull request, it's a really small fix, so hopefully it goes through quickly. Edit: yep, its in the Krypton branch now. That should fix the error.

Hi

Love to use this, but I get "could not retrieve movies from trakt api". Can you suggest what I should do?

Thanks

[elenthil]

hi wellspokenman,

i also get the "could not retrieve movies from trakt api" error. But is it possible that it has to do with the fact that i only have tvshows in the list?

Can you modify the script that it also can write tags to tvshows?

Your script is exactly what i need, great work.

[xbozzo]

Hello Wellspokenman,

Thanks a lot, the update of your fine Addon was as easy as pressing a button (now, after all adjustments have been made to delight the kodi team) :-)

I made some changes in the source to suite my need to add more than 5 lists and updated the wikipedia links for my local comedians too, and after that, the Addon run like a charm :-) (I don't use trak, so I can't help the above users)

I had an known error too, and I also thought about my wish to not stop the fetching process, but to write into the log instead, and I must admit, if this would be done, the user would'nt (or would harldy) realise, that some lists are 404, because of no visual output.

Maybe, sometime, you could change the code to check first if any of the given URLs throw a 404 (or similar) and then show the broken all at once in the popup?

That way, the user (me, here and now) doesn't have to update each URL successively. This is somewhat inconvenient right now (only with a lot of URLS...): start the writting process (wait some time), get a failure popup. correct the url. start the writting process again. get a failure popup again. correct the url. and again, and again.
It would be nicer, if all the invalid URLS would popup at the begin and not within the process.

Anyways, I 've read the souce and saw that you have changed to please the kodi team. good work! thank you for this very useful and enhancing addon!!

[xbozzo]

Did I say "like a charm" ? ;-)

Ok, the addon worked its way all through the lists, but did not get any tag for any movie in my db.
I reinstalled the original script from the kodi repository which is 0.5.2,
and added only one list (check the log for the link) and deleted the tag I used in the addons settings from my db by using kodi -> tags -> remove tags.
I then started the script and it told me, that 0 movies are updated with 0 tags.

Maybe the RSS FEED isn't available anymore on IMDB ?

This is the log:

Code:

03:34:24.229 T:7468 WARNING: RunScript called for a non-script addon 'script.tag-generator'. This behaviour is deprecated.
03:34:24.230 T:19104   DEBUG: Thread LanguageInvoker start, auto delete: false
03:34:24.230 T:19104    INFO: initializing python engine.
03:34:24.230 T:19104   DEBUG: CPythonInvoker(50, C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator\main.py): start processing
03:34:24.258 T:19104   DEBUG: -->Python Interpreter Initialized<--
03:34:24.258 T:19104   DEBUG: CPythonInvoker(50, C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator\main.py): the source file to load is "C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator\main.py"
03:34:24.259 T:19104   DEBUG: CPythonInvoker(50, C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator\main.py): setting the Python path to C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.certifi\lib;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.chardet\lib;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.idna\lib;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.oauthlib\lib;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.requests\lib;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.requests_oauthlib\lib;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.simplejson\lib;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.six\lib;C:\Users\user\AppData\Roaming\Kodi\addons\script.module.urllib3\lib;E:\Programme\Kodi\system\python\DLLs;E:\Programme\Kodi\system\python\Lib;E:\Programme\Kodi\python27.zip;E:\Programme\Kodi\system\python\lib\plat-win;E:\Programme\Kodi\system\python\lib\lib-tk;E:\Programme\Kodi;E:\Programme\Kodi\system\python;E:\Programme\Kodi\system\python\lib\site-packages
03:34:24.259 T:19104   DEBUG: CPythonInvoker(50, C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator\main.py): entering source directory C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator
03:34:24.260 T:19104   DEBUG: CPythonInvoker(50, C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator\main.py): instantiating addon using automatically obtained id of "script.tag-generator" dependent on version 2.25.0 of the xbmc.python api
03:34:24.711 T:19104  NOTICE: TAG-GEN: Starting scraped tag generation.
03:34:24.711 T:19104   DEBUG: DialogProgress::Open called
03:34:24.711 T:19104   DEBUG: ------ Window Init (DialogConfirm.xml) ------
03:34:24.711 T:19104  NOTICE: TAG-GEN: Starting IMDB tag writing.
03:34:25.951 T:19104   DEBUG: CVideoDatabase::RunQuery took 1235 ms for 11934 items query: select * from movie_view
03:34:31.409 T:7468   DEBUG: CWinEventsWin32::WndProc: window move event
03:34:34.003 T:7468   DEBUG: Previous line repeats 26 times.
03:34:34.004 T:7468   DEBUG: ------ Window Deinit (Pointer.xml) ------
03:34:34.630 T:7952   DEBUG: Thread JobWorker 7952 terminating (autodelete)
03:34:34.631 T:39852   DEBUG: Thread JobWorker 39852 terminating (autodelete)
03:34:34.762 T:16332   DEBUG: Thread JobWorker 16332 terminating (autodelete)
03:34:35.002 T:7468   DEBUG: CWinEventsWin32::WndProc: window move event
03:34:38.478 T:7468   DEBUG: Previous line repeats 16 times.
03:34:38.478 T:7468   DEBUG: ------ Window Init (Pointer.xml) ------
03:34:39.525 T:7468   DEBUG: CWinEventsWin32::WndProcWindow is active
03:34:39.526 T:7468   DEBUG: CWinEventsWin32::WndProc: Focus switched to process E:\m\p\npp\notepad++.exe
03:34:43.496 T:7468   DEBUG: ------ Window Deinit (Pointer.xml) ------
03:34:52.679 T:19104  NOTICE: TAG-GEN: Found these IMDB tags on []'s watchlist: http://rss.imdb.com/list/ls052566024/: []
03:34:52.686 T:7468   DEBUG: ------ Window Init (DialogConfirm.xml) ------
03:35:10.571 T:7468   DEBUG: CWinEventsWin32::WndProcWindow is active
03:35:13.094 T:7468   DEBUG: ------ Window Init (Pointer.xml) ------
03:35:14.840 T:7468   DEBUG: CInputManager::ProcessMouse: trying mouse action leftclick
03:35:15.107 T:7468   DEBUG: ------ Window Deinit (DialogConfirm.xml) ------
03:35:15.134 T:19104    INFO: CPythonInvoker(50, C:\Users\user\AppData\Roaming\Kodi\addons\script.tag-generator\main.py): script aborted
03:35:15.172 T:19104    INFO: Python script stopped
03:35:15.173 T:19104   DEBUG: Thread LanguageInvoker 19104 terminating
03:35:15.411 T:7468   DEBUG: ------ Window Deinit (DialogConfirm.xml) ------
03:35:16.446 T:7468   DEBUG: CWinEventsWin32::WndProcWindow is active
03:35:16.447 T:7468   DEBUG: CWinEventsWin32::WndProc: Focus switched to process E:\m\p\BareTail.exe

The Stand Up Comedy part seems to work, the addon told me, that two movies were tagged.

[bigwillch]

This is a handy addon. Do you have any plans to extend it to work for TV shows too?

[wellspokenman]

@xbozzo
I'm not sure what's causing those errors (I read the log, but can't see anything meaningful). Most likely thing to break is of course the imdb page itself, as if they change the structure of that page too much, I will no longer be able to get the imdbids from it. Does it do this for all imdb urls?

@bigwillch
Hadn't planned on it, as I can't imagine having so many TV shows that they would need their own playlists. Maybe I should spend more money on storage.

[bluenote]

I'd love to use this but the last time I tried this is what i got: "could not retrieve movies from trakt api"  
Can you suggest how I could move forward?

[kingkearney]

Great addon for kodi that works well with trakt for tagging. I've edited the settings file to change it from 5 to 20 lists, I am unable to make more lists due to the 'id' numbers now overlapping.

I'd like to be able to get up to 200+ lists as I use tags for my Netflix genres, I currently have about 170 trakt lists.

How do I go about making it possible to make more than 20 lists for trakt tagging?