2012-07-15, 10:34
Hi all,
I've started on supporting banners/posters as a starting point simultaneously. More image types can be added later once we get to grips with the basics.
I've got a work in progress branch here: https://github.com/jmarshallnz/xbmc/bran...ter_banner
A win32 build is available here: http://mirrors.xbmc.org/test-builds/win3...banner.exe
I've added support for ListItem.Art(banner) and ListItem.Art(poster) alongside ListItem.Art(fanart) and ListItem.Art(thumb). They return nothing if nothing is available - no fallbacks at all - you can do that from the skin.
The tvdb.com scraper included handles specifying poster + banner for the image types, so on a scrape you'll get banner + poster types available in the database, and thus available via the above info labels.
No local art supported as yet - atm if you have local art then it'll be set as thumb, poster + banner all at once I think - don't use local thumbs for testing
At the moment, "thumb" just returns the first image returned by the scraper. This is a poster for thetvdb.com. I'm not sure how to best deal with this - in some instances, "thumb" might make sense to refer to the landscape art type for example, and makes sense for episode images as well.
Other things to think of are what to do with the Get Thumb/Get Fanart buttons. Obviously Get Thumb by itself doesn't make sense - atm I've hacked in a nasty context menu chooser when you Get Thumb to specify poster/banner/thumb so you can see the different types returned.
Obviously still quite a bit of work to do, but the main thing to sort out first and foremost is how to treat the "thumb" type. Should it be unique, or should it be reserved for the first image found (perhaps with some priority order). This obviously has implications for local art - folder.jpg and <moviename>.tbn offer no information as to their type.
Cheers,
Jonathan
I've started on supporting banners/posters as a starting point simultaneously. More image types can be added later once we get to grips with the basics.
I've got a work in progress branch here: https://github.com/jmarshallnz/xbmc/bran...ter_banner
A win32 build is available here: http://mirrors.xbmc.org/test-builds/win3...banner.exe
I've added support for ListItem.Art(banner) and ListItem.Art(poster) alongside ListItem.Art(fanart) and ListItem.Art(thumb). They return nothing if nothing is available - no fallbacks at all - you can do that from the skin.
The tvdb.com scraper included handles specifying poster + banner for the image types, so on a scrape you'll get banner + poster types available in the database, and thus available via the above info labels.
No local art supported as yet - atm if you have local art then it'll be set as thumb, poster + banner all at once I think - don't use local thumbs for testing
At the moment, "thumb" just returns the first image returned by the scraper. This is a poster for thetvdb.com. I'm not sure how to best deal with this - in some instances, "thumb" might make sense to refer to the landscape art type for example, and makes sense for episode images as well.
Other things to think of are what to do with the Get Thumb/Get Fanart buttons. Obviously Get Thumb by itself doesn't make sense - atm I've hacked in a nasty context menu chooser when you Get Thumb to specify poster/banner/thumb so you can see the different types returned.
Obviously still quite a bit of work to do, but the main thing to sort out first and foremost is how to treat the "thumb" type. Should it be unique, or should it be reserved for the first image found (perhaps with some priority order). This obviously has implications for local art - folder.jpg and <moviename>.tbn offer no information as to their type.
Cheers,
Jonathan