Login at Kodi Home

davilla · 2013-01-23, 20:48

nice, now they have a choice Smile

squash the PR down, let's go over it and get it in.

kemonine96 · 2013-01-23, 20:55

No choice yet in the UI, but the underlying code to make it a 100% choice is there.

How do you recommend squashing down the PR?

davilla · (This post was last modified: 2013-01-23, 21:29 by davilla.)

squash down the previous commits into one, looks like everything can go into one. The idea of a PR is to commit a new feature, you don't really want to show the process in getting there. In other words, you don't have to show your work Smile

kemonine96 · 2013-01-23, 21:41

(2013-01-23, 21:27)davilla Wrote: squash down the previous commits into one, looks like everything can go into one. The idea of a PR is to commit a new feature, you don't really want to show the process in getting there. In other words, you don't have to show your work

Just create a new PR with a single commit and close the original?

**Martijn** · 2013-01-23, 21:43

(2013-01-23, 21:41)kemonine96 Wrote:
(2013-01-23, 21:27)davilla Wrote: squash down the previous commits into one, looks like everything can go into one. The idea of a PR is to commit a new feature, you don't really want to show the process in getting there. In other words, you don't have to show your work

Just create a new PR with a single commit and close the original?

Squash commits and force push to your branch will auto update the PR Smile

kemonine96 · 2013-01-23, 21:51

(2013-01-23, 21:43)Martijn Wrote: Squash commits and force push to your branch will auto update the PR

I was unaware git let you do this. Thanks for the trick, done on PR.

kemonine96 · 2013-01-25, 17:04

The PR for getting native volume controls working has been merged. Do you want to keep the thread open still?

davilla · 2013-01-25, 18:44

no, close it. any issues can be handled in a new thread.