Player.SetShuffle | SetRepeat | SetPartymode
#1
Hi
Juste a little question/reflexion to the maestro (Montellese) about 3 JSONRPC method

Player.SetShuffle
Player.SetRepeat
Player.SetPartymode

This 3 method return a string "OK"
It's not be better to return the current status change (boolean)??


Or change the method name to Player.ToggleShuffle Player.ToggleRepeat Player.TogglePartymode ?
Or do a method Player.GetPlayOrder with value: shuffle | partymode | repeatone | repeatall ... ??


I read this after post so just consider the green remark...

(2013-02-23, 15:08)montellese Wrote: Thursday, October 4nd 2012:
Commits: 552580d9007b1959c500

merge Player.Move(Left|Right|Up|Down) into Player.Move which takes a "direction" parameter which can be "left", "right", "up" or "down"
merge Player.Zoom(In|Out) into Player.Zoom which takes a "zoom" parameter which can be "in", "out" or any integer between 1 and 10 (zoom level)
merge Player.(Un)Shuffle into Player.SetShuffle with a "shuffle" parameter which can be true, false or "toggle" so this adds the toggle functionality which wasn't possible up until now
rename Player.Repeat to Player.SetRepeat to match the naming convention and renames the "state" parameter to "repeat" and add "cycle" to the list of possible values for the "repeat" parameter
merge Player.Go(Previous|Next|To) into Player.GoTo with a "to" parameter (not "position") which can be "previous", "next" or any integer number describing a position in the playlist


Have a nice day, and continued to do excellent work!!!!

You can do what you want with this thread: delete|answer|other...
Reply
#2
Probably yeah but it would break backwards compatibility. Right now you can retrieve the state of those properties through Player.GetProperties. If something is missing, let me know.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply

Logout Mark Read Team Forum Stats Members Help
Player.SetShuffle | SetRepeat | SetPartymode0